mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 12:31:52 +03:00
bacadc30da
## Remaining Work - [x] changelog entry - [x] more tests: `<backend>_delete_remote_relationship` is definitely untested - [x] negative tests: we probably want to assert that there are some APIs we DON'T support - [x] update the console to use the new API, if necessary - [x] ~~adding the corresponding documentation for the API for other backends (only `pg_` was added here)~~ - deferred to https://github.com/hasura/graphql-engine-mono/issues/3170 - [x] ~~deciding which backends should support this API~~ - deferred to https://github.com/hasura/graphql-engine-mono/issues/3170 - [x] ~~deciding what to do about potentially overlapping schematic representations~~ - ~~cf. https://github.com/hasura/graphql-engine-mono/pull/3157#issuecomment-995307624~~ - deferred to https://github.com/hasura/graphql-engine-mono/issues/3171 - [x] ~~add more descriptive versioning information to some of the types that are changing in this PR~~ - cf. https://github.com/hasura/graphql-engine-mono/pull/3157#discussion_r769830920 - deferred to https://github.com/hasura/graphql-engine-mono/issues/3172 ## Description This PR fixes several important issues wrt. the remote relationship API. - it fixes a regression introduced by [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124), which prevented `<backend>_create_remote_relationship` from accepting the old argument format (break of backwards compatibility, broke the console) - it removes the command `create_remote_relationship` added to the v1/metadata API as a work-around as part of [#3124](https://github.com/hasura/graphql-engine-mono/pull/3124) - it reverts the subsequent fix in the console: [#3149](https://github.com/hasura/graphql-engine-mono/pull/3149) Furthermore, this PR also addresses two other issues: - THE DOCUMENTATION OF THE METADATA API WAS WRONG, and documented `create_remote_relationship` instead of `<backend>_create_remote_relationship`: this PR fixes this by adding `pg_` everywhere, but does not attempt to add the corresponding documentation for other backends, partly because: - `<backend>_delete_remote_relationship` WAS BROKEN ON NON-POSTGRES BACKENDS; it always expected an argument parameterized by Postgres. As of main, the `<backend>_(create|update|delete)_remote_relationship` commands are supported on Postgres, Citus, BigQuery, but **NOT MSSQL**. I do not know if this is intentional or not, if it even should be publicized or not, and as a result this PR doesn't change this. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3157 Co-authored-by: jkachmar <8461423+jkachmar@users.noreply.github.com> GitOrigin-RevId: 37e2f41522a9229a11c595574c3f4984317d652a
126 lines
5.5 KiB
Haskell
126 lines
5.5 KiB
Haskell
-- | BackendAPI
|
|
--
|
|
-- This module defines the 'BackendAPI' class, alongside a few helpers. Its goal is to delegate to
|
|
-- backends the responsibility of creating the parsers for the metadata API. Each backend is expected
|
|
-- to provide a list of 'CommandParser', which in turn is a simple function from command name and
|
|
-- command arguments to a corresponding parser. Command parsers can easily be created using the
|
|
-- 'commandParser' function.
|
|
--
|
|
-- Furthermore, for each set of related features, such as table tracking commands, or permission
|
|
-- commands, a helper function is provided, that allows a backend to write its instance by simply
|
|
-- listing the set of features it supports.
|
|
module Hasura.Server.API.Backend
|
|
( BackendAPI (..),
|
|
commandParser,
|
|
eventTriggerCommands,
|
|
functionCommands,
|
|
functionPermissionsCommands,
|
|
relationshipCommands,
|
|
remoteRelationshipCommands,
|
|
sourceCommands,
|
|
tableCommands,
|
|
tablePermissionsCommands,
|
|
)
|
|
where
|
|
|
|
import Data.Aeson ((<?>))
|
|
import Data.Aeson.Types (modifyFailure)
|
|
import Data.Aeson.Types qualified as J
|
|
import Data.Text qualified as T
|
|
import Hasura.Prelude
|
|
import Hasura.RQL.Types.Backend
|
|
import Hasura.SQL.AnyBackend
|
|
import Hasura.SQL.Backend
|
|
import {-# SOURCE #-} Hasura.Server.API.Metadata
|
|
|
|
-- API class
|
|
|
|
type CommandParser = Text -> J.Value -> J.Parser (Maybe RQLMetadataV1)
|
|
|
|
class BackendAPI (b :: BackendType) where
|
|
metadataV1CommandParsers :: [CommandParser]
|
|
|
|
-- helpers
|
|
|
|
commandParser ::
|
|
J.FromJSON a =>
|
|
-- | expected command name
|
|
Text ->
|
|
-- | corresponding parser
|
|
(a -> RQLMetadataV1) ->
|
|
CommandParser
|
|
commandParser expected constructor provided arguments =
|
|
-- We return a Maybe parser here if the command name doesn't match, as Aeson's alternative
|
|
-- instance backtracks: if we used 'fail', we would not be able to distinguish between "this is
|
|
-- the correct branch, the name matches, but the argument fails to parse, we must fail" and "this
|
|
-- is not the command we were expecting here, it is fine to continue with another".
|
|
whenMaybe (expected == provided) $
|
|
modifyFailure withDetails $ constructor <$> (J.parseJSON arguments <?> J.Key "args")
|
|
where
|
|
withDetails internalErrorMessage =
|
|
intercalate
|
|
"\n"
|
|
[ "Error when parsing command " <> T.unpack expected <> ".",
|
|
"See our documentation at https://hasura.io/docs/latest/graphql/core/api-reference/metadata-api/index.html#metadata-apis.",
|
|
"Internal error message: " <> internalErrorMessage
|
|
]
|
|
|
|
sourceCommands,
|
|
tableCommands,
|
|
tablePermissionsCommands,
|
|
functionCommands,
|
|
functionPermissionsCommands,
|
|
relationshipCommands,
|
|
remoteRelationshipCommands,
|
|
eventTriggerCommands ::
|
|
forall (b :: BackendType).
|
|
Backend b =>
|
|
[CommandParser]
|
|
sourceCommands =
|
|
[ commandParser "add_source" $ RMAddSource . mkAnyBackend @b,
|
|
commandParser "drop_source" $ RMDropSource,
|
|
commandParser "set_table_customization" $ RMSetTableCustomization . mkAnyBackend @b
|
|
]
|
|
tableCommands =
|
|
[ commandParser "track_table" $ RMTrackTable . mkAnyBackend @b,
|
|
commandParser "untrack_table" $ RMUntrackTable . mkAnyBackend @b
|
|
]
|
|
tablePermissionsCommands =
|
|
[ commandParser "create_insert_permission" $ RMCreateInsertPermission . mkAnyBackend @b,
|
|
commandParser "create_select_permission" $ RMCreateSelectPermission . mkAnyBackend @b,
|
|
commandParser "create_update_permission" $ RMCreateUpdatePermission . mkAnyBackend @b,
|
|
commandParser "create_delete_permission" $ RMCreateDeletePermission . mkAnyBackend @b,
|
|
commandParser "drop_insert_permission" $ RMDropInsertPermission . mkAnyBackend @b,
|
|
commandParser "drop_select_permission" $ RMDropSelectPermission . mkAnyBackend @b,
|
|
commandParser "drop_update_permission" $ RMDropUpdatePermission . mkAnyBackend @b,
|
|
commandParser "drop_delete_permission" $ RMDropDeletePermission . mkAnyBackend @b,
|
|
commandParser "set_permission_comment" $ RMSetPermissionComment . mkAnyBackend @b
|
|
]
|
|
functionCommands =
|
|
[ commandParser "track_function" $ RMTrackFunction . mkAnyBackend @b,
|
|
commandParser "untrack_function" $ RMUntrackFunction . mkAnyBackend @b,
|
|
commandParser "set_function_customization" $ RMSetFunctionCustomization . mkAnyBackend @b
|
|
]
|
|
functionPermissionsCommands =
|
|
[ commandParser "create_function_permission" $ RMCreateFunctionPermission . mkAnyBackend @b,
|
|
commandParser "drop_function_permission" $ RMDropFunctionPermission . mkAnyBackend @b
|
|
]
|
|
relationshipCommands =
|
|
[ commandParser "create_object_relationship" $ RMCreateObjectRelationship . mkAnyBackend @b,
|
|
commandParser "create_array_relationship" $ RMCreateArrayRelationship . mkAnyBackend @b,
|
|
commandParser "set_relationship_comment" $ RMSetRelationshipComment . mkAnyBackend @b,
|
|
commandParser "rename_relationship" $ RMRenameRelationship . mkAnyBackend @b,
|
|
commandParser "drop_relationship" $ RMDropRelationship . mkAnyBackend @b
|
|
]
|
|
remoteRelationshipCommands =
|
|
[ commandParser "create_remote_relationship" $ RMCreateRemoteRelationship . mkAnyBackend @b,
|
|
commandParser "update_remote_relationship" $ RMUpdateRemoteRelationship . mkAnyBackend @b,
|
|
commandParser "delete_remote_relationship" $ RMDeleteRemoteRelationship . mkAnyBackend @b
|
|
]
|
|
eventTriggerCommands =
|
|
[ commandParser "invoke_event_trigger" $ RMInvokeEventTrigger . mkAnyBackend @b,
|
|
commandParser "create_event_trigger" $ RMCreateEventTrigger . mkAnyBackend @b,
|
|
commandParser "delete_event_trigger" $ RMDeleteEventTrigger . mkAnyBackend @b,
|
|
commandParser "redeliver_event" $ RMRedeliverEvent . mkAnyBackend @b
|
|
]
|