graphql-engine/server/src-lib/Hasura/Backends/MSSQL/Instances/Transport.hs
Antoine Leblanc dec8579db8 Allow backend execution to happen on the base app monad.
### Description

Each Backend executes queries against the database in a slightly different stack: Postgres uses its own `TXeT`, MSSQL uses a variant of it, BigQuery is simply in `ExceptT QErr IO`... To accommodate those variations, we had originally introduced an `ExecutionMonad b` type family in `BackendExecute`, allowing each backend to describe its own stack. It was then up to that backend's `BackendTransport` instance to implement running said stack, and converting the result back into our main app monad.

However, this was not without complications: `TraceT` is one of them: as it usually needs to be on the top of the stack, converting from one stack to the other implies the use `interpTraceT`, which is quite monstrous. Furthermore, as part of the Entitlement Services work, we're trying to move to a "Services" architecture in which the entire engine runs in one base monad, that delegates features and dependencies to monad constraints; and as a result we'd like to minimize the number of different monad stacks we have to maintain and translate from and to in the codebase.

To improve things, this PR changes `ExecutionMonad b` from an _absolute_ stack to a _relative_ one: i.e.: what needs to be stacked on top of our base monad for the execution. In `Transport`, we then only need to pop the top of the stack, and voila. This greatly simplifies the implementation of the backends, as there's no longer any need to do any stack transformation: MySQL's implementation becomes a `runIdentityT`! This also removes most mentions of `TraceT` from the execution code since it's no longer required: we can rely on the base monad's existing `MonadTrace` constraint.

To continue encapsulating monadic actions in `DBStepInfo` and avoid threading a bunch of `forall` all over the place, this PR introduces a small local helper: `OnBaseMonad`. One only downside of all this is that this requires adding `MonadBaseControl IO m` constraint all over the place: previously, we would run directly on `IO` and lift, and would therefore not need to bring that constraint all the way.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7789
GitOrigin-RevId: e9b2e431c5c47fa9851abf87545c0415ff6d1a12
2023-02-09 14:40:04 +00:00

165 lines
5.8 KiB
Haskell

{-# OPTIONS_GHC -fno-warn-orphans #-}
-- | MSSQL Instances Transport
--
-- Defines the MSSQL instance of 'BackendTransport' and how to
-- interact with the database for running queries, mutations, subscriptions,
-- and so on.
module Hasura.Backends.MSSQL.Instances.Transport () where
import Control.Exception.Safe (throwIO)
import Control.Monad.Trans.Control
import Data.Aeson qualified as J
import Data.ByteString qualified as B
import Data.String (fromString)
import Data.Text.Encoding (encodeUtf8)
import Data.Text.Extended
import Database.MSSQL.Transaction (forJsonQueryE)
import Database.ODBC.SQLServer qualified as ODBC
import Hasura.Backends.MSSQL.Connection
import Hasura.Backends.MSSQL.Execute.QueryTags (withQueryTags)
import Hasura.Backends.MSSQL.Instances.Execute
import Hasura.Backends.MSSQL.SQL.Error
import Hasura.Backends.MSSQL.ToQuery
import Hasura.Base.Error
import Hasura.EncJSON
import Hasura.GraphQL.Execute.Backend
import Hasura.GraphQL.Execute.Subscription.Plan
import Hasura.GraphQL.Logging
import Hasura.GraphQL.Namespace (RootFieldAlias)
import Hasura.GraphQL.Transport.Backend
import Hasura.GraphQL.Transport.HTTP.Protocol
import Hasura.Logging qualified as L
import Hasura.Prelude
import Hasura.RQL.Types.Backend
import Hasura.SQL.Backend
import Hasura.Server.Types (RequestId)
import Hasura.Session
import Hasura.Tracing
instance BackendTransport 'MSSQL where
runDBQuery = runQuery
runDBQueryExplain = runQueryExplain
runDBMutation = runMutation
runDBSubscription = runSubscription
runDBStreamingSubscription _ _ _ _ =
liftIO . throwIO $ userError "runDBSubscription: not implemented for MS-SQL sources."
newtype CohortResult = CohortResult (CohortId, Text)
instance J.FromJSON CohortResult where
parseJSON = J.withObject "CohortResult" \o -> do
cohortId <- o J..: "result_id"
cohortData <- o J..: "result"
pure $ CohortResult (cohortId, cohortData)
runQuery ::
( MonadIO m,
MonadBaseControl IO m,
MonadQueryLog m,
MonadTrace m,
MonadError QErr m
) =>
RequestId ->
GQLReqUnparsed ->
RootFieldAlias ->
UserInfo ->
L.Logger L.Hasura ->
SourceConfig 'MSSQL ->
OnBaseMonad (ExceptT QErr) EncJSON ->
Maybe (PreparedQuery 'MSSQL) ->
ResolvedConnectionTemplate 'MSSQL ->
-- | Also return the time spent in the PG query; for telemetry.
m (DiffTime, EncJSON)
runQuery reqId query fieldName _userInfo logger _sourceConfig tx genSql _ = do
logQueryLog logger $ mkQueryLog query fieldName genSql reqId
withElapsedTime $
trace ("MSSQL Query for root field " <>> fieldName) $
run tx
runQueryExplain ::
( MonadIO m,
MonadBaseControl IO m,
MonadError QErr m,
MonadTrace m
) =>
DBStepInfo 'MSSQL ->
m EncJSON
runQueryExplain (DBStepInfo _ _ _ action _) = run action
runMutation ::
( MonadIO m,
MonadBaseControl IO m,
MonadQueryLog m,
MonadTrace m,
MonadError QErr m
) =>
RequestId ->
GQLReqUnparsed ->
RootFieldAlias ->
UserInfo ->
L.Logger L.Hasura ->
SourceConfig 'MSSQL ->
OnBaseMonad (ExceptT QErr) EncJSON ->
Maybe (PreparedQuery 'MSSQL) ->
ResolvedConnectionTemplate 'MSSQL ->
-- | Also return 'Mutation' when the operation was a mutation, and the time
-- spent in the PG query; for telemetry.
m (DiffTime, EncJSON)
runMutation reqId query fieldName _userInfo logger _sourceConfig tx _genSql _ = do
logQueryLog logger $ mkQueryLog query fieldName Nothing reqId
withElapsedTime $
trace ("MSSQL Mutation for root field " <>> fieldName) $
run tx
runSubscription ::
(MonadIO m, MonadBaseControl IO m) =>
SourceConfig 'MSSQL ->
MultiplexedQuery 'MSSQL ->
[(CohortId, CohortVariables)] ->
ResolvedConnectionTemplate 'MSSQL ->
m (DiffTime, Either QErr [(CohortId, B.ByteString)])
runSubscription sourceConfig (MultiplexedQuery' reselect queryTags) variables _ = do
let mssqlExecCtx = _mscExecCtx sourceConfig
multiplexed = multiplexRootReselect variables reselect
query = toQueryFlat (fromSelect multiplexed)
-- Append query tags comment to the query. We cannot use 'toSQL' to convert
-- QueryTagsComment to Query, because it escapes the query tags comment which
-- will create a badly formatted query. Hence we use the 'rawUnescapedText' to
-- append the comment without any escaping.
queryWithQueryTags = query `withQueryTags` queryTags
withElapsedTime $ runExceptT $ executeMultiplexedQuery mssqlExecCtx queryWithQueryTags
executeMultiplexedQuery ::
(MonadIO m, MonadBaseControl IO m) =>
MSSQLExecCtx ->
ODBC.Query ->
ExceptT QErr m [(CohortId, B.ByteString)]
executeMultiplexedQuery mssqlExecCtx query = do
let parseResult r = J.eitherDecodeStrict (encodeUtf8 r) `onLeft` \s -> throw400 ParseFailed (fromString s)
convertFromJSON :: [CohortResult] -> [(CohortId, B.ByteString)]
convertFromJSON = map \(CohortResult (cid, cresult)) -> (cid, encodeUtf8 cresult)
-- Because the 'query' will have a @FOR JSON@ clause at the toplevel it will
-- be split across multiple rows, hence use of 'forJsonQueryE' which takes
-- care of concatenating the results.
textResult <- liftEitherM $ runExceptT $ mssqlRunReadOnly mssqlExecCtx $ forJsonQueryE defaultMSSQLTxErrorHandler query
parsedResult <- parseResult textResult
pure $ convertFromJSON parsedResult
run :: (MonadIO m, MonadBaseControl IO m, MonadError QErr m, MonadTrace m) => OnBaseMonad (ExceptT QErr) a -> m a
run = liftEitherM . runExceptT . runOnBaseMonad
mkQueryLog ::
GQLReqUnparsed ->
RootFieldAlias ->
Maybe (PreparedQuery 'MSSQL) ->
RequestId ->
QueryLog
mkQueryLog gqlQuery fieldName preparedSql requestId =
-- @QueryLogKindDatabase Nothing@ means that the backend doesn't support connection templates
QueryLog gqlQuery ((fieldName,) <$> generatedQuery) requestId (QueryLogKindDatabase Nothing)
where
generatedQuery =
preparedSql <&> \queryString ->
GeneratedQuery queryString J.Null