graphql-engine/server/src-lib/Hasura/RQL/DDL/Webhook/Transform/Body.hs
Auke Booij cdac24c79f server: delete the Cacheable type class in favor of Eq
What is the `Cacheable` type class about?
```haskell
class Eq a => Cacheable a where
  unchanged :: Accesses -> a -> a -> Bool
  default unchanged :: (Generic a, GCacheable (Rep a)) => Accesses -> a -> a -> Bool
  unchanged accesses a b = gunchanged (from a) (from b) accesses
```
Its only method is an alternative to `(==)`. The added value of `unchanged` (and the additional `Accesses` argument) arises _only_ for one type, namely `Dependency`. Indeed, the `Cacheable (Dependency a)` instance is non-trivial, whereas every other `Cacheable` instance is completely boilerplate (and indeed either generated from `Generic`, or simply `unchanged _ = (==)`). The `Cacheable (Dependency a)` instance is the only one where the `Accesses` argument is not just passed onwards.

The only callsite of the `unchanged` method is in the `ArrowCache (Rule m)` method. That is to say that the `Cacheable` type class is used to decide when we can re-use parts of the schema cache between Metadata operations.

So what is the `Cacheable (Dependency a)` instance about? Normally, the output of a `Rule m a b` is re-used when the new input (of type `a`) is equal to the old one. But sometimes, that's too coarse: it might be that a certain `Rule m a b` only depends on a small part of its input of type `a`. A `Dependency` allows us to spell out what parts of `a` are being depended on, and these parts are recorded as values of types `Access a` in the state `Accesses`.

If the input `a` changes, but not in a way that touches the recorded `Accesses`, then the output `b` of that rule can be re-used without recomputing.

So now you understand _why_ we're passing `Accesses` to the `unchanged` method: `unchanged` is an equality check in disguise that just needs some additional context.

But we don't need to pass `Accesses` as a function argument. We can use the `reflection` package to pass it as type-level context. So the core of this PR is that we change the instance declaration from
```haskell
instance (Cacheable a) => Cacheable (Dependency a) where
```
to
```haskell
 instance (Given Accesses, Eq a) => Eq (Dependency a) where
```
and use `(==)` instead of `unchanged`.

If you haven't seen `reflection` before: it's like a `MonadReader`, but it doesn't require a `Monad`.

In order to pass the current `Accesses` value, instead of simply passing the `Accesses` as a function argument, we need to instantiate the `Given Accesses` context. We use the `give` method from the `reflection` package for that.
```haskell
give :: forall r. Accesses -> (Given Accesses => r) -> r

unchanged :: (Given Accesses => Eq a) => Accesses -> a -> a -> Bool
unchanged accesses a b = give accesses (a == b)
```
With these three components in place, we can delete the `Cacheable` type class entirely.

The remainder of this PR is just to remove the `Cacheable` type class and its instances.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6877
GitOrigin-RevId: 7125f5e11d856e7672ab810a23d5bf5ad176e77f
2022-11-21 16:35:37 +00:00

182 lines
6.1 KiB
Haskell

{-# LANGUAGE DeriveAnyClass #-}
{-# LANGUAGE UndecidableInstances #-}
module Hasura.RQL.DDL.Webhook.Transform.Body
( -- * Body Transformations
Body (..),
TransformFn (..),
TransformCtx (..),
BodyTransformFn (..),
foldFormEncoded,
validateBodyTransformFn,
)
where
-------------------------------------------------------------------------------
import Data.Aeson (FromJSON, ToJSON)
import Data.Aeson qualified as J
import Data.ByteString (ByteString)
import Data.ByteString.Lazy qualified as LBS
import Data.HashMap.Internal.Strict qualified as M
import Data.List qualified as L
import Data.Text qualified as T
import Data.Text.Encoding qualified as TE
import Data.Validation (Validation)
import Data.Validation qualified as V
import Hasura.Prelude
import Hasura.RQL.DDL.Webhook.Transform.Class
( Template (..),
TemplatingEngine,
Transform (..),
TransformErrorBundle (..),
UnescapedTemplate,
)
import Hasura.RQL.DDL.Webhook.Transform.Request
( RequestTransformCtx,
runRequestTemplateTransform,
runUnescapedRequestTemplateTransform',
validateRequestTemplateTransform',
validateRequestUnescapedTemplateTransform',
)
import Network.URI.Extended qualified as URI
-------------------------------------------------------------------------------
-- | HTTP message body being transformed.
data Body
= JSONBody (Maybe J.Value)
| RawBody LBS.ByteString
deriving stock (Eq, Show)
instance Transform Body where
-- NOTE: GHC does not let us attach Haddock documentation to data family
-- instances, so 'BodyTransformFn' is defined separately from this wrapper.
newtype TransformFn Body = BodyTransformFn_ BodyTransformFn
deriving stock (Eq, Generic, Show)
deriving newtype (NFData, FromJSON, ToJSON)
newtype TransformCtx Body = TransformCtx RequestTransformCtx
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
-- method implementations, so 'applyBodyTransformFn' is defined separately.
transform (BodyTransformFn_ fn) (TransformCtx reqCtx) = applyBodyTransformFn fn reqCtx
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
-- method implementations, so 'validateBodyTransformFn' is defined
-- separately.
validate engine (BodyTransformFn_ fn) = validateBodyTransformFn engine fn
-- | The transformations which can be applied to an HTTP message body.
data BodyTransformFn
= -- | Remove the HTTP message body.
Remove
| -- | Modify the JSON message body by applying a 'Template' transformation.
ModifyAsJSON Template
| -- | Modify the JSON message body by applying 'UnescapedTemplate'
-- transformations to each field with a matching 'Text' key.
ModifyAsFormURLEncoded (M.HashMap Text UnescapedTemplate)
deriving stock (Eq, Generic, Show)
deriving anyclass (NFData)
-- | Provide an implementation for the transformations defined by
-- 'BodyTransformFn'.
--
-- If one views 'BodyTransformFn' as an interface describing HTTP message body
-- transformations, this can be seen as an implementation of these
-- transformations as normal Haskell functions.
applyBodyTransformFn ::
MonadError TransformErrorBundle m =>
BodyTransformFn ->
RequestTransformCtx ->
Body ->
m Body
applyBodyTransformFn fn context _originalBody = case fn of
Remove ->
pure $ JSONBody Nothing
ModifyAsJSON template -> do
result <- liftEither $ runRequestTemplateTransform template context
pure . JSONBody . Just $ result
ModifyAsFormURLEncoded formTemplates -> do
result <-
liftEither . V.toEither . for formTemplates $
runUnescapedRequestTemplateTransform' context
pure . RawBody $ foldFormEncoded result
-- | Validate that the provided 'BodyTransformFn' is correct in the context of
-- a particular 'TemplatingEngine'.
--
-- This is a product of the fact that the correctness of a given transformation
-- may be dependent on zero, one, or more of the templated transformations
-- encoded within the given 'BodyTransformFn'.
validateBodyTransformFn ::
TemplatingEngine ->
BodyTransformFn ->
Validation TransformErrorBundle ()
validateBodyTransformFn engine = \case
Remove ->
pure ()
ModifyAsJSON template ->
validateRequestTemplateTransform' engine template
ModifyAsFormURLEncoded templateMap ->
traverse_ (validateRequestUnescapedTemplateTransform' engine) templateMap
-- | Fold a 'M.HashMap' of header key/value pairs into an
-- @x-www-form-urlencoded@ message body.
foldFormEncoded :: M.HashMap Text ByteString -> LBS.ByteString
foldFormEncoded =
(fold @[] @LBS.ByteString)
. L.intersperse "&"
. M.foldMapWithKey @[LBS.ByteString]
\k v ->
[ LBS.fromStrict $
TE.encodeUtf8 (escapeURIText k)
<> "="
<> escapeURIBS v
]
-- | URI-escape 'Text' blobs.
escapeURIText :: T.Text -> T.Text
escapeURIText =
T.pack . URI.escapeURIString URI.isUnescapedInURIComponent . T.unpack
-- | URI-escape 'ByteString' blobs, which are presumed to represent 'Text'.
--
-- XXX: This function makes internal usage of 'TE.decodeUtf8', which throws an
-- impure exception when the supplied 'ByteString' cannot be decoded into valid
-- UTF8 text!
escapeURIBS :: ByteString -> ByteString
escapeURIBS =
TE.encodeUtf8
. T.pack
. URI.escapeURIString URI.isUnescapedInURIComponent
. T.unpack
. TE.decodeUtf8
instance FromJSON BodyTransformFn where
parseJSON = J.withObject "BodyTransformFn" \o -> do
action <- o J..: "action"
case (action :: Text) of
"remove" -> pure Remove
"transform" -> do
template <- o J..: "template"
pure $ ModifyAsJSON template
"x_www_form_urlencoded" -> do
formTemplates <- o J..: "form_template"
pure $ ModifyAsFormURLEncoded formTemplates
_ -> fail "invalid transform action"
instance ToJSON BodyTransformFn where
toJSON = \case
Remove -> J.object ["action" J..= ("remove" :: Text)]
ModifyAsJSON a ->
J.object
[ "action" J..= ("transform" :: Text),
"template" J..= J.toJSON a
]
ModifyAsFormURLEncoded formTemplates ->
J.object
[ "action" J..= ("x_www_form_urlencoded" :: Text),
"form_template" J..= J.toJSON formTemplates
]