mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-21 22:41:43 +03:00
cdac24c79f
What is the `Cacheable` type class about? ```haskell class Eq a => Cacheable a where unchanged :: Accesses -> a -> a -> Bool default unchanged :: (Generic a, GCacheable (Rep a)) => Accesses -> a -> a -> Bool unchanged accesses a b = gunchanged (from a) (from b) accesses ``` Its only method is an alternative to `(==)`. The added value of `unchanged` (and the additional `Accesses` argument) arises _only_ for one type, namely `Dependency`. Indeed, the `Cacheable (Dependency a)` instance is non-trivial, whereas every other `Cacheable` instance is completely boilerplate (and indeed either generated from `Generic`, or simply `unchanged _ = (==)`). The `Cacheable (Dependency a)` instance is the only one where the `Accesses` argument is not just passed onwards. The only callsite of the `unchanged` method is in the `ArrowCache (Rule m)` method. That is to say that the `Cacheable` type class is used to decide when we can re-use parts of the schema cache between Metadata operations. So what is the `Cacheable (Dependency a)` instance about? Normally, the output of a `Rule m a b` is re-used when the new input (of type `a`) is equal to the old one. But sometimes, that's too coarse: it might be that a certain `Rule m a b` only depends on a small part of its input of type `a`. A `Dependency` allows us to spell out what parts of `a` are being depended on, and these parts are recorded as values of types `Access a` in the state `Accesses`. If the input `a` changes, but not in a way that touches the recorded `Accesses`, then the output `b` of that rule can be re-used without recomputing. So now you understand _why_ we're passing `Accesses` to the `unchanged` method: `unchanged` is an equality check in disguise that just needs some additional context. But we don't need to pass `Accesses` as a function argument. We can use the `reflection` package to pass it as type-level context. So the core of this PR is that we change the instance declaration from ```haskell instance (Cacheable a) => Cacheable (Dependency a) where ``` to ```haskell instance (Given Accesses, Eq a) => Eq (Dependency a) where ``` and use `(==)` instead of `unchanged`. If you haven't seen `reflection` before: it's like a `MonadReader`, but it doesn't require a `Monad`. In order to pass the current `Accesses` value, instead of simply passing the `Accesses` as a function argument, we need to instantiate the `Given Accesses` context. We use the `give` method from the `reflection` package for that. ```haskell give :: forall r. Accesses -> (Given Accesses => r) -> r unchanged :: (Given Accesses => Eq a) => Accesses -> a -> a -> Bool unchanged accesses a b = give accesses (a == b) ``` With these three components in place, we can delete the `Cacheable` type class entirely. The remainder of this PR is just to remove the `Cacheable` type class and its instances. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6877 GitOrigin-RevId: 7125f5e11d856e7672ab810a23d5bf5ad176e77f
162 lines
6.1 KiB
Haskell
162 lines
6.1 KiB
Haskell
{-# LANGUAGE ApplicativeDo #-}
|
|
{-# LANGUAGE DeriveAnyClass #-}
|
|
{-# LANGUAGE UndecidableInstances #-}
|
|
|
|
module Hasura.RQL.DDL.Webhook.Transform.Headers
|
|
( -- * Header Transformations
|
|
Headers (..),
|
|
TransformFn (..),
|
|
TransformCtx (..),
|
|
HeadersTransformFn (..),
|
|
AddReplaceOrRemoveFields (..),
|
|
)
|
|
where
|
|
|
|
-------------------------------------------------------------------------------
|
|
|
|
import Data.Aeson (FromJSON, ToJSON)
|
|
import Data.Aeson qualified as J
|
|
import Data.CaseInsensitive qualified as CI
|
|
import Data.HashMap.Strict qualified as M
|
|
import Data.Text.Encoding qualified as TE
|
|
import Data.Validation (Validation)
|
|
import Data.Validation qualified as V
|
|
import Hasura.Prelude
|
|
import Hasura.RQL.DDL.Webhook.Transform.Class
|
|
( TemplatingEngine,
|
|
Transform (..),
|
|
TransformErrorBundle (..),
|
|
UnescapedTemplate (..),
|
|
)
|
|
import Hasura.RQL.DDL.Webhook.Transform.Request
|
|
( RequestTransformCtx,
|
|
runUnescapedRequestTemplateTransform',
|
|
validateRequestUnescapedTemplateTransform',
|
|
)
|
|
import Network.HTTP.Types qualified as HTTP.Types
|
|
|
|
-------------------------------------------------------------------------------
|
|
|
|
-- | The actual header data we are transforming..
|
|
--
|
|
-- This newtype is necessary because otherwise we end up with an
|
|
-- orphan instance.
|
|
newtype Headers = Headers [HTTP.Types.Header]
|
|
|
|
instance Transform Headers where
|
|
-- NOTE: GHC does not let us attach Haddock documentation to data family
|
|
-- instances, so 'HeadersTransformFn' is defined separately from this
|
|
-- wrapper.
|
|
newtype TransformFn Headers = HeadersTransformFn_ HeadersTransformFn
|
|
deriving stock (Eq, Generic, Show)
|
|
deriving newtype (NFData, FromJSON, ToJSON)
|
|
|
|
newtype TransformCtx Headers = TransformCtx RequestTransformCtx
|
|
|
|
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
|
|
-- method implementations, so 'applyHeadersTransformFn' is defined
|
|
-- separately.
|
|
transform (HeadersTransformFn_ fn) (TransformCtx reqCtx) = applyHeadersTransformFn fn reqCtx
|
|
|
|
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
|
|
-- method implementations, so 'validateHeadersTransformFn' is defined
|
|
-- separately.
|
|
validate engine (HeadersTransformFn_ fn) =
|
|
validateHeadersTransformFn engine fn
|
|
|
|
-- | The defunctionalized transformation on 'Headers'
|
|
newtype HeadersTransformFn
|
|
= -- | Add or replace matching 'HTTP.Types.Header's.
|
|
AddReplaceOrRemove AddReplaceOrRemoveFields
|
|
deriving stock (Eq, Generic, Show)
|
|
deriving newtype (NFData, FromJSON, ToJSON)
|
|
|
|
-- | The user can supply a set of header keys to be filtered from the
|
|
-- request and a set of headers to be added to the request.
|
|
data AddReplaceOrRemoveFields = AddReplaceOrRemoveFields
|
|
{ -- | A list of key-value pairs for 'HTTP.Types.Header's which
|
|
-- should be added (if they don't exist) or replaced (if they do) within
|
|
-- the HTTP message.
|
|
addOrReplaceHeaders :: [(CI.CI Text, UnescapedTemplate)],
|
|
-- | A list of 'HTTP.Type.Header' keys which should be removed from the
|
|
-- HTTP message.
|
|
removeHeaders :: [CI.CI Text]
|
|
}
|
|
deriving stock (Show, Eq, Ord, Generic)
|
|
deriving anyclass (NFData)
|
|
|
|
-- | Provide an implementation for the transformations defined by
|
|
-- 'HeadersTransformFn'.
|
|
--
|
|
-- If one views 'HeadersTransformFn' as an interface describing HTTP message
|
|
-- header transformations, this can be seen as an implementation of these
|
|
-- transformations as normal Haskell functions.
|
|
applyHeadersTransformFn ::
|
|
MonadError TransformErrorBundle m =>
|
|
HeadersTransformFn ->
|
|
RequestTransformCtx ->
|
|
Headers ->
|
|
m Headers
|
|
applyHeadersTransformFn fn context (Headers originalHeaders) = case fn of
|
|
AddReplaceOrRemove fields -> do
|
|
-- NOTE: 'TE.decodeUtf8' can fail with an impure exception; conversion
|
|
-- to bytes is infallible.
|
|
let AddReplaceOrRemoveFields {addOrReplaceHeaders, removeHeaders} = fields
|
|
removeHeadersBytes = fmap (CI.map TE.encodeUtf8) removeHeaders
|
|
filteredHeaders =
|
|
originalHeaders & filter \(key, _val) ->
|
|
key `notElem` removeHeadersBytes
|
|
|
|
-- NOTE: We use `ApplicativeDo` here to take advantage of Validation's
|
|
-- applicative sequencing
|
|
newHeaders <- liftEither . V.toEither $
|
|
for addOrReplaceHeaders \(rawKey, rawValue) -> do
|
|
let key = CI.map TE.encodeUtf8 rawKey
|
|
value <- runUnescapedRequestTemplateTransform' context rawValue
|
|
pure (key, value)
|
|
|
|
pure . Headers $ filteredHeaders <> newHeaders
|
|
|
|
-- | Validate that the provided 'HeadersTransformFn' is correct in the context
|
|
-- of a particular 'TemplatingEngine'.
|
|
--
|
|
-- This is a product of the fact that the correctness of a given transformation
|
|
-- may be dependent on zero, one, or more of the templated transformations
|
|
-- encoded within the given 'HeadersTransformFn'.
|
|
validateHeadersTransformFn ::
|
|
TemplatingEngine ->
|
|
HeadersTransformFn ->
|
|
Validation TransformErrorBundle ()
|
|
validateHeadersTransformFn engine = \case
|
|
AddReplaceOrRemove fields -> do
|
|
let templates = fields & addOrReplaceHeaders & map snd
|
|
traverse_ (validateRequestUnescapedTemplateTransform' engine) templates
|
|
|
|
instance FromJSON AddReplaceOrRemoveFields where
|
|
parseJSON = J.withObject "AddReplaceRemoveFields" $ \o -> do
|
|
addOrReplaceHeadersTxt <- o J..:? "add_headers" J..!= mempty
|
|
let addOrReplaceHeaders = M.toList $ mapKeys CI.mk addOrReplaceHeadersTxt
|
|
|
|
removeHeadersTxt <- o J..:? "remove_headers" J..!= mempty
|
|
-- NOTE: Ensure that the FromJSON instance is used for deserialization.
|
|
let removeHeaders = coerce @[HeaderKey] removeHeadersTxt
|
|
|
|
pure AddReplaceOrRemoveFields {addOrReplaceHeaders, removeHeaders}
|
|
|
|
instance ToJSON AddReplaceOrRemoveFields where
|
|
toJSON AddReplaceOrRemoveFields {..} =
|
|
J.object
|
|
[ "add_headers" J..= M.fromList (fmap (first CI.original) addOrReplaceHeaders),
|
|
"remove_headers" J..= fmap CI.original removeHeaders
|
|
]
|
|
|
|
-- | This newtype exists solely to anchor a `FromJSON` instance and is
|
|
-- eliminated in the `TransformHeaders` `FromJSON` instance.
|
|
newtype HeaderKey = HeaderKey {unHeaderKey :: CI.CI Text}
|
|
deriving stock (Show, Eq, Ord, Generic)
|
|
deriving anyclass (NFData)
|
|
|
|
instance FromJSON HeaderKey where
|
|
parseJSON = J.withText "HeaderKey" \txt -> case CI.mk txt of
|
|
key -> pure $ HeaderKey key
|