graphql-engine/server/src-lib/Hasura/RQL/DDL/Webhook/Transform/QueryParams.hs
Puru Gupta 698190894f server: use kriti template to generate query param from list
## Description ✍️
This PR adds support to generate query params directly using a kriti template which can be used to flatten a list of parameter arguments as well.

### Changes in the Metadata API
Earlier the `query_params` key inside `request_transform` used to take in an object of key/value pairs where the `key` represents the query parameter name and `value` points to the value of the parameter or a kriti template which could be resolved to the value.

With this PR, we provide the user with more freedom to generate the complete query string using kriti template. The  `query_params` can now take in a string as well which will be a kriti template. This new change needs to be incorporated on the console and CLI metadata import/export as well.
- [x] CLI: Compatible, no changes required
- [ ] Console

## Changelog ✍️

__Component__ : server

__Type__: feature

__Product__: community-edition

### Short Changelog

use kriti template to generate query param from list of arguments

### Related Issues ✍
https://hasurahq.atlassian.net/browse/GS-243

### Solution and Design ✍
We use a kriti template to generate the complete query parameter string.

| Query Template | Output |
|---|---|
| `{{ concat ([concat({{ range _, x := [\"apple\", \"banana\"] }} \"tags={{x}}&\" {{ end }}), \"flag=smthng\"]) }}`| `tags=apple&tags=banana&flag=smthng`  |
| `{{ concat ([\"tags=\", concat({{ range _, x := $body.input }} \"{{x}},\" {{ end }})]) }}` | `tags=apple%2Cbanana%2C` |

### Steps to test and verify ✍
- start HGE and make the following request to `http://localhost:8080/v1/metadata`:
```json
{
    "type": "test_webhook_transform",
    "args": {
        "webhook_url": "http://localhost:3000",
        "body": {
            "action": {
                "name": "actionName"
            },
            "input": ["apple", "banana"]
        },
        "request_transform": {
            "version": 2,
            "url": "{{$base_url}}",
            "query_params": "{{ concat ([concat({{ range _, x := $body.input }} \"tags={{x}}&\" {{ end }}), \"flag=smthng\"]) }}",
            "template_engine": "Kriti"
        }
    }
}
```
- you should receive the following as output:
```json
{
    "body": {
        "action": {
            "name": "actionName"
        },
        "input": [
            "apple",
            "banana"
        ]
    },
    "headers": [],
    "method": "GET",
    "webhook_url": "http://localhost:3000?tags=apple&tags=banana&flag=smthng"
}
```

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6961
Co-authored-by: Tirumarai Selvan <8663570+tirumaraiselvan@users.noreply.github.com>
GitOrigin-RevId: 712ba038f03009edc3e8eb0435e723304943399a
2022-11-29 20:27:41 +00:00

134 lines
5.2 KiB
Haskell

{-# LANGUAGE ApplicativeDo #-}
{-# LANGUAGE DeriveAnyClass #-}
module Hasura.RQL.DDL.Webhook.Transform.QueryParams
( -- * Query transformations
QueryParams (..),
TransformFn (..),
TransformCtx (..),
QueryParamsTransformFn (..),
)
where
-------------------------------------------------------------------------------
import Data.Aeson (FromJSON, ToJSON)
import Data.Aeson qualified as J
import Data.HashMap.Strict qualified as M
import Data.Validation (Validation)
import Data.Validation qualified as V
import Hasura.Prelude
import Hasura.RQL.DDL.Webhook.Transform.Class
( TemplatingEngine,
Transform (..),
TransformErrorBundle (..),
UnescapedTemplate (..),
)
import Hasura.RQL.DDL.Webhook.Transform.Request
( RequestTransformCtx,
runUnescapedRequestTemplateTransform',
validateRequestUnescapedTemplateTransform',
)
import Network.HTTP.Client.Transformable qualified as HTTP
import Network.HTTP.Types.URI (parseQuery)
-------------------------------------------------------------------------------
-- | The actual query params we are transforming.
--
-- This newtype is necessary because otherwise we end up with an
-- orphan instance.
newtype QueryParams = QueryParams {unQueryParams :: HTTP.Query}
instance Transform QueryParams where
-- NOTE: GHC does not let us attach Haddock documentation to data family
-- instances, so 'QueryParamsTransformFn' is defined separately from this
-- wrapper.
newtype TransformFn QueryParams
= QueryParamsTransformFn_ QueryParamsTransformFn
deriving stock (Show, Eq, Generic)
deriving newtype (NFData, FromJSON, ToJSON)
newtype TransformCtx QueryParams = TransformCtx RequestTransformCtx
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
-- method implementations, so 'applyQueryParamsTransformFn' is defined
-- separately.
transform (QueryParamsTransformFn_ fn) (TransformCtx reqCtx) = applyQueryParamsTransformFn fn reqCtx
-- NOTE: GHC does not let us attach Haddock documentation to typeclass
-- method implementations, so 'validateQueryParamsTransformFn' is defined
-- separately.
validate engine (QueryParamsTransformFn_ fn) =
validateQueryParamsTransformFn engine fn
-- | The defunctionalized transformation 'QueryParams'
data QueryParamsTransformFn
= AddOrReplace [(UnescapedTemplate, Maybe UnescapedTemplate)]
| ParamTemplate UnescapedTemplate
deriving (NFData)
deriving stock (Eq, Generic, Show)
-- | Provide an implementation for the transformations defined by
-- 'QueryParamsTransformFn'.
--
-- If one views 'QueryParamsTransformFn' as an interface describing HTTP method
-- transformations, this can be seen as an implementation of these
-- transformations as normal Haskell functions.
applyQueryParamsTransformFn ::
MonadError TransformErrorBundle m =>
QueryParamsTransformFn ->
RequestTransformCtx ->
QueryParams ->
m QueryParams
applyQueryParamsTransformFn fn context _oldQueryParams = case fn of
AddOrReplace addOrReplaceParams -> do
-- NOTE: We use `ApplicativeDo` here to take advantage of Validation's
-- applicative sequencing
queryParams <- liftEither . V.toEither $
for addOrReplaceParams \(rawKey, rawValue) -> do
key <- runUnescapedRequestTemplateTransform' context rawKey
value <- traverse (runUnescapedRequestTemplateTransform' context) rawValue
pure $
if key == "null" || value == Just "null"
then Nothing
else Just (key, value)
pure $ QueryParams (catMaybes queryParams)
ParamTemplate template -> do
resolvedValue <- liftEither . V.toEither $ runUnescapedRequestTemplateTransform' context template
pure $ QueryParams (parseQuery resolvedValue)
-- | Validate that the provided 'QueryParamsTransformFn' is correct in the
-- context of a particular 'TemplatingEngine'.
--
-- This is a product of the fact that the correctness of a given transformation
-- may be dependent on zero, one, or more of the templated transformations
-- encoded within the given 'QueryParamsTransformFn'.
validateQueryParamsTransformFn ::
TemplatingEngine ->
QueryParamsTransformFn ->
Validation TransformErrorBundle ()
validateQueryParamsTransformFn engine = \case
AddOrReplace addOrReplaceParams ->
-- NOTE: We use `ApplicativeDo` here to take advantage of
-- Validation's applicative sequencing
for_ addOrReplaceParams \(key, val) -> do
validateRequestUnescapedTemplateTransform' engine key
traverse_ (validateRequestUnescapedTemplateTransform' engine) val
-- NOTE: There's a bug in `ApplicativeDo` which infers a `Monad`
-- constraint on this block if it doens't end with `pure ()`
pure ()
ParamTemplate template -> do
validateRequestUnescapedTemplateTransform' engine template
pure ()
{-# ANN validateQueryParamsTransformFn ("HLint: ignore Redundant pure" :: String) #-}
instance J.ToJSON QueryParamsTransformFn where
toJSON (AddOrReplace addOrReplace) = J.toJSON $ M.fromList addOrReplace
toJSON (ParamTemplate template) = J.toJSON template
instance J.FromJSON QueryParamsTransformFn where
parseJSON xs@(J.Object _) = AddOrReplace . M.toList <$> J.parseJSON xs
parseJSON xs@(J.String _) = ParamTemplate <$> J.parseJSON xs
parseJSON _ = fail "Invalid query parameter"