mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 20:41:49 +03:00
6e1761f8f9
### Description This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`). For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys). Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases. Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it). While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs. ### Keeping track of concrete type names The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens: ```graphql query { author(id: 53478) { ... on Writer { name articles { title } } ... on Artist { name articles { title } } } } ``` If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query. To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810 GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
432 lines
17 KiB
Haskell
432 lines
17 KiB
Haskell
module Hasura.GraphQL.Execute.RemoteJoin.Join
|
|
( processRemoteJoins,
|
|
)
|
|
where
|
|
|
|
import Control.Lens (view, _3)
|
|
import Data.Aeson qualified as J
|
|
import Data.Aeson.Ordered qualified as JO
|
|
import Data.Environment qualified as Env
|
|
import Data.HashMap.Strict.Extended qualified as Map
|
|
import Data.HashMap.Strict.InsOrd qualified as OMap
|
|
import Data.HashMap.Strict.NonEmpty qualified as NEMap
|
|
import Data.HashSet qualified as HS
|
|
import Data.IntMap.Strict.Extended qualified as IntMap
|
|
import Data.List.NonEmpty qualified as NE
|
|
import Data.Scientific qualified as Scientific
|
|
import Data.Text qualified as T
|
|
import Data.Text.Read qualified as TR
|
|
import Data.Tuple (swap)
|
|
import Hasura.Base.Error
|
|
import Hasura.EncJSON
|
|
import Hasura.GraphQL.Execute.Backend qualified as EB
|
|
import Hasura.GraphQL.Execute.Instances ()
|
|
import Hasura.GraphQL.Execute.RemoteJoin.RemoteSchema qualified as RS
|
|
import Hasura.GraphQL.Execute.RemoteJoin.Types
|
|
import Hasura.GraphQL.Logging (MonadQueryLog)
|
|
import Hasura.GraphQL.Namespace
|
|
import Hasura.GraphQL.RemoteServer (execRemoteGQ)
|
|
import Hasura.GraphQL.Transport.Backend qualified as TB
|
|
import Hasura.GraphQL.Transport.HTTP.Protocol (GQLReqUnparsed)
|
|
import Hasura.GraphQL.Transport.Instances ()
|
|
import Hasura.Logging qualified as L
|
|
import Hasura.Prelude
|
|
import Hasura.RQL.Types
|
|
import Hasura.SQL.AnyBackend qualified as AB
|
|
import Hasura.Server.Types (RequestId)
|
|
import Hasura.Session
|
|
import Hasura.Tracing qualified as Tracing
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
|
import Network.HTTP.Client qualified as HTTP
|
|
import Network.HTTP.Types qualified as HTTP
|
|
|
|
forRemoteJoins ::
|
|
(Applicative f) =>
|
|
Maybe RemoteJoins ->
|
|
a ->
|
|
(RemoteJoins -> f a) ->
|
|
f a
|
|
forRemoteJoins remoteJoins onNoJoins f =
|
|
maybe (pure onNoJoins) f remoteJoins
|
|
|
|
processRemoteJoins ::
|
|
( MonadError QErr m,
|
|
MonadIO m,
|
|
EB.MonadQueryTags m,
|
|
MonadQueryLog m,
|
|
Tracing.MonadTrace m
|
|
) =>
|
|
RequestId ->
|
|
L.Logger L.Hasura ->
|
|
Env.Environment ->
|
|
HTTP.Manager ->
|
|
[HTTP.Header] ->
|
|
UserInfo ->
|
|
EncJSON ->
|
|
Maybe RemoteJoins ->
|
|
GQLReqUnparsed ->
|
|
m EncJSON
|
|
processRemoteJoins requestId logger env manager reqHdrs userInfo lhs joinTree gqlreq = do
|
|
forRemoteJoins joinTree lhs $ \remoteJoins -> do
|
|
lhsParsed <- onLeft (JO.eitherDecode $ encJToLBS lhs) (throw500 . T.pack)
|
|
encJFromOrderedValue . runIdentity
|
|
<$> processRemoteJoins_
|
|
requestId
|
|
logger
|
|
env
|
|
manager
|
|
reqHdrs
|
|
userInfo
|
|
(Identity lhsParsed)
|
|
remoteJoins
|
|
gqlreq
|
|
|
|
processRemoteJoins_ ::
|
|
( MonadError QErr m,
|
|
MonadIO m,
|
|
EB.MonadQueryTags m,
|
|
MonadQueryLog m,
|
|
Tracing.MonadTrace m,
|
|
Traversable f
|
|
) =>
|
|
RequestId ->
|
|
L.Logger L.Hasura ->
|
|
Env.Environment ->
|
|
HTTP.Manager ->
|
|
[HTTP.Header] ->
|
|
UserInfo ->
|
|
f JO.Value ->
|
|
RemoteJoins ->
|
|
GQLReqUnparsed ->
|
|
m (f JO.Value)
|
|
processRemoteJoins_ requestId logger env manager requestHeaders userInfo lhs joinTree gqlreq = do
|
|
(compositeValue, joins) <- collectJoinArguments (assignJoinIds joinTree) lhs
|
|
joinIndices <- fmap IntMap.catMaybes $
|
|
for joins $ \JoinArguments {..} -> do
|
|
let joinArguments = IntMap.fromList $ map swap $ Map.toList _jalArguments
|
|
previousStep <- case _jalJoin of
|
|
RemoteJoinRemoteSchema remoteSchemaJoin childJoinTree -> do
|
|
let remoteSchemaInfo = rsDef $ _rsjRemoteSchema remoteSchemaJoin
|
|
networkCall = fmap (view _3) . execRemoteGQ env manager userInfo requestHeaders remoteSchemaInfo
|
|
maybeJoinIndex <- RS.makeRemoteSchemaJoinCall networkCall userInfo remoteSchemaJoin joinArguments
|
|
pure $ fmap (childJoinTree,) maybeJoinIndex
|
|
RemoteJoinSource sourceJoin childJoinTree -> AB.dispatchAnyBackend @TB.BackendTransport sourceJoin \(RemoteSourceJoin {..} :: RemoteSourceJoin b) -> do
|
|
let rows = flip map (IntMap.toList joinArguments) $ \(argumentId, argument) ->
|
|
Map.insert "__argument_id__" (J.toJSON argumentId) $
|
|
Map.fromList $
|
|
map (getFieldNameTxt *** JO.fromOrdered) $
|
|
Map.toList $ unJoinArgument argument
|
|
rowSchema = fmap (\(_, rhsType, rhsColumn) -> (rhsColumn, rhsType)) _rsjJoinColumns
|
|
|
|
for (NE.nonEmpty rows) $ \nonEmptyRows -> do
|
|
stepInfo <-
|
|
EB.mkDBRemoteRelationshipPlan
|
|
userInfo
|
|
_rsjSource
|
|
_rsjSourceConfig
|
|
nonEmptyRows
|
|
rowSchema
|
|
(FieldName "__argument_id__")
|
|
(FieldName "f", _rsjRelationship)
|
|
|
|
let fieldNameText = getFieldNameTxt _jalFieldName
|
|
-- This should never fail, as field names in remote relationships
|
|
-- are validated when building the schema cache.
|
|
fieldName <-
|
|
G.mkName fieldNameText
|
|
`onNothing` throw500 ("'" <> fieldNameText <> "' is not a valid GraphQL name")
|
|
(_, sourceResponse) <-
|
|
TB.runDBQuery @b
|
|
requestId
|
|
gqlreq
|
|
-- NOTE: We're making an assumption that the 'FieldName' propagated
|
|
-- upwards from 'collectJoinArguments' is reasonable to use for
|
|
-- logging.
|
|
(mkUnNamespacedRootFieldAlias fieldName)
|
|
userInfo
|
|
logger
|
|
_rsjSourceConfig
|
|
(EB.dbsiAction stepInfo)
|
|
(EB.dbsiPreparedQuery stepInfo)
|
|
(childJoinTree,) <$> buildSourceDataJoinIndex sourceResponse
|
|
for previousStep $ \(childJoinTree, joinIndex) -> do
|
|
forRemoteJoins childJoinTree joinIndex $ \childRemoteJoins -> do
|
|
results <-
|
|
processRemoteJoins_
|
|
requestId
|
|
logger
|
|
env
|
|
manager
|
|
requestHeaders
|
|
userInfo
|
|
(IntMap.elems joinIndex)
|
|
childRemoteJoins
|
|
gqlreq
|
|
pure $ IntMap.fromAscList $ zip (IntMap.keys joinIndex) results
|
|
|
|
joinResults joinIndices compositeValue
|
|
|
|
-- | Attempt to construct a 'JoinIndex' from some 'EncJSON' source response.
|
|
buildSourceDataJoinIndex :: (MonadError QErr m) => EncJSON -> m (IntMap.IntMap JO.Value)
|
|
buildSourceDataJoinIndex response = do
|
|
json <-
|
|
JO.eitherDecode (encJToLBS response) `onLeft` \err ->
|
|
throwInvalidJsonErr $ T.pack err
|
|
case json of
|
|
JO.Array arr -> fmap IntMap.fromList $ for (toList arr) \case
|
|
JO.Object obj -> do
|
|
argumentResult <-
|
|
JO.lookup "f" obj
|
|
`onNothing` throwMissingRelationshipDataErr
|
|
argumentIdValue <-
|
|
JO.lookup "__argument_id__" obj
|
|
`onNothing` throwMissingArgumentIdErr
|
|
(argumentId :: Int) <-
|
|
case argumentIdValue of
|
|
JO.Number n ->
|
|
Scientific.toBoundedInteger n
|
|
`onNothing` throwInvalidArgumentIdValueErr
|
|
JO.String s ->
|
|
intFromText s
|
|
`onNothing` throwInvalidArgumentIdValueErr
|
|
_ -> throwInvalidArgumentIdValueErr
|
|
pure (argumentId, argumentResult)
|
|
_ -> throwNoNestedObjectErr
|
|
_ -> throwNoListOfObjectsErr
|
|
where
|
|
intFromText txt = case TR.decimal txt of
|
|
Right (i, "") -> pure i
|
|
_ -> Nothing
|
|
throwInvalidJsonErr errMsg =
|
|
throw500 $
|
|
"failed to decode JSON response from the source: " <> errMsg
|
|
throwMissingRelationshipDataErr =
|
|
throw500 $
|
|
"cannot find relationship data (aliased as 'f') within the source \
|
|
\response"
|
|
throwMissingArgumentIdErr =
|
|
throw500 $
|
|
"cannot find '__argument_id__' within the source response"
|
|
throwInvalidArgumentIdValueErr =
|
|
throw500 $ "expected 'argument_id' to get parsed as backend integer type"
|
|
throwNoNestedObjectErr =
|
|
throw500 $
|
|
"expected an object one level deep in the remote schema's response, \
|
|
\but found an array/scalar value instead"
|
|
throwNoListOfObjectsErr =
|
|
throw500 $
|
|
"expected a list of objects in the remote schema's response, but found \
|
|
\an object/scalar value instead"
|
|
|
|
type CompositeObject a = OMap.InsOrdHashMap Text (CompositeValue a)
|
|
|
|
-- | A hybrid JSON value representation which captures the context of remote join field in type parameter.
|
|
data CompositeValue a
|
|
= CVOrdValue !JO.Value
|
|
| CVObject !(CompositeObject a)
|
|
| CVObjectArray ![CompositeValue a]
|
|
| CVFromRemote !a
|
|
deriving (Show, Eq, Functor, Foldable, Traversable)
|
|
|
|
compositeValueToJSON :: CompositeValue JO.Value -> JO.Value
|
|
compositeValueToJSON = \case
|
|
CVOrdValue v -> v
|
|
CVObject obj -> JO.object $ OMap.toList $ OMap.map compositeValueToJSON obj
|
|
CVObjectArray vals -> JO.array $ map compositeValueToJSON vals
|
|
CVFromRemote v -> v
|
|
|
|
-- | A token used to uniquely identify the results within a join call that are
|
|
-- associated with a particular argument.
|
|
data ReplacementToken = ReplacementToken
|
|
{ -- | Unique identifier for a remote join call.
|
|
_rtCallId :: !JoinCallId,
|
|
-- | Unique identifier for an argument to some remote join.
|
|
_rtArgumentId :: !JoinArgumentId
|
|
}
|
|
|
|
joinResults ::
|
|
forall f m.
|
|
(MonadError QErr m, Traversable f) =>
|
|
IntMap.IntMap (IntMap.IntMap JO.Value) ->
|
|
f (CompositeValue ReplacementToken) ->
|
|
m (f JO.Value)
|
|
joinResults remoteResults compositeValues = do
|
|
traverse (fmap compositeValueToJSON . traverse replaceToken) compositeValues
|
|
where
|
|
replaceToken :: ReplacementToken -> m JO.Value
|
|
replaceToken (ReplacementToken joinCallId argumentId) = do
|
|
joinCallResults <-
|
|
onNothing (IntMap.lookup joinCallId remoteResults) $
|
|
throw500 $
|
|
"couldn't find results for the join with id: "
|
|
<> tshow joinCallId
|
|
onNothing (IntMap.lookup argumentId joinCallResults) $
|
|
throw500 $
|
|
"couldn't find a value for argument id in the join results: "
|
|
<> tshow (argumentId, joinCallId)
|
|
|
|
-- | When traversing a responses's json, wherever the join columns of a remote
|
|
-- join are expected, we want to collect these arguments.
|
|
--
|
|
-- However looking up by a remote join's definition to collect these arguments
|
|
-- does not work because we don't have an 'Ord' or a 'Hashable' instance (it
|
|
-- would be a bit of work).
|
|
--
|
|
-- So this assigned each remote join a unique integer ID by using just the 'Eq'
|
|
-- instance. This ID then can be used for the collection of arguments (which
|
|
-- should also be faster).
|
|
assignJoinIds :: JoinTree RemoteJoin -> JoinTree (JoinCallId, RemoteJoin)
|
|
assignJoinIds joinTree =
|
|
evalState (traverse assignId joinTree) (0, [])
|
|
where
|
|
assignId ::
|
|
RemoteJoin ->
|
|
State (JoinCallId, [(JoinCallId, RemoteJoin)]) (JoinCallId, RemoteJoin)
|
|
assignId remoteJoin = do
|
|
(joinCallId, joinIds) <- get
|
|
let mJoinId = joinIds & find \(_, j) -> j == remoteJoin
|
|
mJoinId `onNothing` do
|
|
put (joinCallId + 1, (joinCallId, remoteJoin) : joinIds)
|
|
pure (joinCallId, remoteJoin)
|
|
|
|
collectJoinArguments ::
|
|
forall f m.
|
|
(MonadError QErr m, Traversable f) =>
|
|
JoinTree (JoinCallId, RemoteJoin) ->
|
|
f JO.Value ->
|
|
m (f (CompositeValue ReplacementToken), IntMap.IntMap JoinArguments)
|
|
collectJoinArguments joinTree lhs = do
|
|
result <- flip runStateT (0, mempty) $ traverse (traverseValue joinTree) lhs
|
|
-- Discard the 'JoinArgumentId' from the intermediate state transformation.
|
|
pure $ second snd result
|
|
where
|
|
getReplacementToken ::
|
|
IntMap.Key ->
|
|
RemoteJoin ->
|
|
JoinArgument ->
|
|
FieldName ->
|
|
StateT
|
|
(JoinArgumentId, IntMap.IntMap JoinArguments)
|
|
m
|
|
ReplacementToken
|
|
getReplacementToken joinId remoteJoin argument fieldName = do
|
|
(counter, joins) <- get
|
|
case IntMap.lookup joinId joins of
|
|
-- XXX: We're making an explicit decision to ignore the existing
|
|
-- 'fieldName' and replace it with the argument provided to this
|
|
-- function.
|
|
--
|
|
-- This needs to be tested so we can verify that the result of this
|
|
-- function call is reasonable.
|
|
Just (JoinArguments _remoteJoin arguments _fieldName) ->
|
|
case Map.lookup argument arguments of
|
|
Just argumentId -> pure $ ReplacementToken joinId argumentId
|
|
Nothing -> addNewArgument counter joins arguments
|
|
Nothing -> addNewArgument counter joins mempty
|
|
where
|
|
addNewArgument counter joins arguments = do
|
|
let argumentId = counter
|
|
newArguments =
|
|
JoinArguments
|
|
remoteJoin
|
|
(Map.insert argument argumentId arguments)
|
|
fieldName
|
|
put (counter + 1, IntMap.insert joinId newArguments joins)
|
|
pure $ ReplacementToken joinId argumentId
|
|
|
|
traverseValue ::
|
|
JoinTree (IntMap.Key, RemoteJoin) ->
|
|
JO.Value ->
|
|
StateT
|
|
(JoinArgumentId, IntMap.IntMap JoinArguments)
|
|
m
|
|
(CompositeValue ReplacementToken)
|
|
traverseValue joinTree_ = \case
|
|
-- 'JO.Null' is a special case of scalar value here, which indicates that
|
|
-- the previous step did not return enough data for us to continue
|
|
-- traversing down this path.
|
|
--
|
|
-- This can occur in the following cases:
|
|
-- * Permission errors; when the user joins on a value they are not
|
|
-- allowed to access
|
|
-- * Queries with remote sources that resolve to null, for example:
|
|
-- {
|
|
-- q {
|
|
-- user_by_pk() {
|
|
-- id
|
|
-- name
|
|
-- r {
|
|
-- }
|
|
-- address {
|
|
-- r_geo {
|
|
-- }
|
|
-- }
|
|
-- }
|
|
-- }
|
|
-- }
|
|
JO.Null -> pure $ CVOrdValue JO.Null
|
|
JO.Object object -> CVObject <$> traverseObject joinTree_ object
|
|
JO.Array array -> CVObjectArray <$> mapM (traverseValue joinTree_) (toList array)
|
|
_ -> throw500 "found a scalar value when traversing with a non-empty join tree"
|
|
|
|
traverseObject ::
|
|
JoinTree (IntMap.Key, RemoteJoin) ->
|
|
JO.Object ->
|
|
StateT
|
|
(JoinArgumentId, IntMap.IntMap JoinArguments)
|
|
m
|
|
(InsOrdHashMap Text (CompositeValue ReplacementToken))
|
|
traverseObject joinTree_ object = do
|
|
let joinTreeNodes = unJoinTree joinTree_
|
|
phantomFields =
|
|
HS.fromList $
|
|
map getFieldNameTxt $
|
|
concatMap (getPhantomFields . snd) $ toList joinTree_
|
|
|
|
-- If we need the typename to disambiguate branches in the join tree, it
|
|
-- will be present in the answer as a placeholder internal field.
|
|
--
|
|
-- We currently have no way of checking whether we explicitly requested
|
|
-- that field, and it would be possible for a malicious user to attempt to
|
|
-- spoof that value by explicitly requesting a value they control.
|
|
-- However, there's no actual risk: we only use that value for lookups
|
|
-- inside the join tree, and if we didn't request this field, the keys in
|
|
-- the join tree map will explicitly require a typename NOT to be
|
|
-- provided. Meaning that any spoofing attempt will just, at worst, result
|
|
-- in remote joins not being performed.
|
|
--
|
|
-- We always remove that key from the resulting object.
|
|
joinTypeName <- case JO.lookup "__hasura_internal_typename" object of
|
|
Nothing -> pure Nothing
|
|
Just (JO.String typename) -> pure $ Just typename
|
|
Just value -> throw500 $ "The reserved __hasura_internal_typename field contains an unexpected value: " <> tshow value
|
|
|
|
-- during this traversal we assume that the remote join column has some
|
|
-- placeholder value in the response. If this weren't present it would
|
|
-- involve a lot more book-keeping to preserve the order of the original
|
|
-- selection set in the response
|
|
compositeObject <- for (JO.toList object) $ \(fieldName, value_) ->
|
|
(fieldName,) <$> case NEMap.lookup (QualifiedFieldName joinTypeName fieldName) joinTreeNodes of
|
|
Just (Leaf (joinId, remoteJoin)) -> do
|
|
joinArgument <- forM (getJoinColumnMapping remoteJoin) $ \alias -> do
|
|
let aliasTxt = getFieldNameTxt $ getAliasFieldName alias
|
|
onNothing (JO.lookup aliasTxt object) $
|
|
throw500 $ "a join column is missing from the response: " <> aliasTxt
|
|
if Map.null (Map.filter (== JO.Null) joinArgument)
|
|
then
|
|
Just . CVFromRemote
|
|
<$> getReplacementToken joinId remoteJoin (JoinArgument joinArgument) (FieldName fieldName)
|
|
else -- we do not join with the remote field if any of the leaves of
|
|
-- the join argument are null
|
|
pure $ Just $ CVOrdValue JO.Null
|
|
Just (Tree joinSubTree) ->
|
|
Just <$> traverseValue joinSubTree value_
|
|
Nothing ->
|
|
if HS.member fieldName phantomFields || fieldName == "__hasura_internal_typename"
|
|
then pure Nothing
|
|
else pure $ Just $ CVOrdValue value_
|
|
|
|
pure . OMap.fromList $
|
|
-- filter out the Nothings
|
|
mapMaybe sequenceA compositeObject
|