mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 09:22:43 +03:00
7bead93827
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary. Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost. Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into. Implementation The following have been removed: - The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs` - The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types: - - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors. - - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers. - Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed . - References to query plan caching in the documentation. - The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.) - The metrics no longer send cache hit/miss messages. There are a few places in which one can still find references to query plan caching: - We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read. https://github.com/hasura/graphql-engine-mono/pull/1815 GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
175 lines
7.9 KiB
Haskell
175 lines
7.9 KiB
Haskell
{-# LANGUAGE UndecidableInstances #-}
|
|
module Main (main) where
|
|
|
|
import Hasura.Prelude
|
|
|
|
import qualified Data.Aeson as A
|
|
import qualified Data.ByteString.Lazy.Char8 as BL
|
|
import qualified Data.Environment as Env
|
|
import qualified Data.NonNegativeIntSpec as NonNegetiveIntSpec
|
|
import qualified Data.Parser.CacheControlSpec as CacheControlParser
|
|
import qualified Data.Parser.JSONPathSpec as JsonPath
|
|
import qualified Data.Parser.URLTemplate as URLTemplate
|
|
import qualified Data.TimeSpec as TimeSpec
|
|
import qualified Database.PG.Query as Q
|
|
import qualified Network.HTTP.Client as HTTP
|
|
import qualified Network.HTTP.Client.TLS as HTTP
|
|
import qualified Test.Hspec.Runner as Hspec
|
|
|
|
import Control.Concurrent.MVar
|
|
import Control.Natural ((:~>) (..))
|
|
import Data.Time.Clock (getCurrentTime)
|
|
import Data.URL.Template
|
|
import Options.Applicative
|
|
import System.Environment (getEnvironment)
|
|
import System.Exit (exitFailure)
|
|
import Test.Hspec
|
|
|
|
import qualified Hasura.EventingSpec as EventingSpec
|
|
import qualified Hasura.GraphQL.Parser.DirectivesTest as GraphQLDirectivesSpec
|
|
import qualified Hasura.GraphQL.Schema.RemoteTest as GraphRemoteSchemaSpec
|
|
import qualified Hasura.IncrementalSpec as IncrementalSpec
|
|
import qualified Hasura.RQL.Types.EndpointSpec as EndpointSpec
|
|
import qualified Hasura.SQL.WKTSpec as WKTSpec
|
|
import qualified Hasura.Server.AuthSpec as AuthSpec
|
|
import qualified Hasura.Server.MigrateSpec as MigrateSpec
|
|
import qualified Hasura.Server.TelemetrySpec as TelemetrySpec
|
|
|
|
import Hasura.App (PGMetadataStorageAppT (..),
|
|
mkPgSourceResolver)
|
|
import Hasura.Metadata.Class
|
|
import Hasura.RQL.DDL.Schema.Cache
|
|
import Hasura.RQL.DDL.Schema.Cache.Common
|
|
import Hasura.RQL.Types
|
|
import Hasura.Server.Init
|
|
import Hasura.Server.Migrate
|
|
import Hasura.Server.Types
|
|
import Hasura.Server.Version
|
|
import Hasura.Server.Version.TH
|
|
|
|
|
|
data TestSuites
|
|
= AllSuites !(Maybe URLTemplate)
|
|
-- ^ Run all test suites. It probably doesn't make sense to be able to specify additional
|
|
-- hspec args here.
|
|
| SingleSuite ![String] !TestSuite
|
|
-- ^ Args to pass through to hspec (as if from 'getArgs'), and the specific suite to run.
|
|
|
|
data TestSuite
|
|
= UnitSuite
|
|
| PostgresSuite !(Maybe URLTemplate)
|
|
|
|
main :: IO ()
|
|
main = withVersion $$(getVersionFromEnvironment) $ parseArgs >>= \case
|
|
AllSuites pgConnOptions -> do
|
|
postgresSpecs <- buildPostgresSpecs pgConnOptions
|
|
runHspec [] (unitSpecs *> postgresSpecs)
|
|
SingleSuite hspecArgs suite -> runHspec hspecArgs =<< case suite of
|
|
UnitSuite -> pure unitSpecs
|
|
PostgresSuite pgConnOptions -> buildPostgresSpecs pgConnOptions
|
|
|
|
unitSpecs :: Spec
|
|
unitSpecs = do
|
|
-- describe "Hasura.RQL.Metadata" MetadataSpec.spec -- Commenting until optimizing the test in CI
|
|
describe "Data.NonNegativeInt" NonNegetiveIntSpec.spec
|
|
describe "Data.Parser.CacheControl" CacheControlParser.spec
|
|
describe "Data.Parser.JSONPath" JsonPath.spec
|
|
describe "Data.Parser.URLTemplate" URLTemplate.spec
|
|
describe "Data.Time" TimeSpec.spec
|
|
describe "Hasura.Eventing" EventingSpec.spec
|
|
describe "Hasura.GraphQL.Parser.Directives" GraphQLDirectivesSpec.spec
|
|
describe "Hasura.GraphQL.Schema.Remote" GraphRemoteSchemaSpec.spec
|
|
describe "Hasura.Incremental" IncrementalSpec.spec
|
|
describe "Hasura.RQL.Types.Endpoint" EndpointSpec.spec
|
|
describe "Hasura.SQL.WKT" WKTSpec.spec
|
|
describe "Hasura.Server.Auth" AuthSpec.spec
|
|
describe "Hasura.Server.Telemetry" TelemetrySpec.spec
|
|
|
|
buildPostgresSpecs :: HasVersion => Maybe URLTemplate -> IO Spec
|
|
buildPostgresSpecs maybeUrlTemplate = do
|
|
env <- getEnvironment
|
|
let envMap = Env.mkEnvironment env
|
|
|
|
pgUrlTemplate <- flip onLeft printErrExit $ runWithEnv env $ do
|
|
let envVar = fst databaseUrlEnv
|
|
maybeV <- withEnv maybeUrlTemplate envVar
|
|
onNothing maybeV $ throwError $
|
|
"Expected: --database-url or " <> envVar
|
|
|
|
pgUrlText <- flip onLeft printErrExit $ renderURLTemplate envMap pgUrlTemplate
|
|
let pgConnInfo = Q.ConnInfo 1 $ Q.CDDatabaseURI $ txtToBs pgUrlText
|
|
urlConf = UrlValue $ InputWebhook pgUrlTemplate
|
|
sourceConnInfo =
|
|
PostgresSourceConnInfo urlConf (Just setPostgresPoolSettings) True Q.ReadCommitted Nothing
|
|
sourceConfig = PostgresConnConfiguration sourceConnInfo Nothing
|
|
|
|
pgPool <- Q.initPGPool pgConnInfo Q.defaultConnParams { Q.cpConns = 1 } print
|
|
let pgContext = mkPGExecCtx Q.Serializable pgPool
|
|
|
|
setupCacheRef = do
|
|
httpManager <- HTTP.newManager HTTP.tlsManagerSettings
|
|
let sqlGenCtx = SQLGenCtx False False
|
|
maintenanceMode = MaintenanceModeDisabled
|
|
serverConfigCtx =
|
|
ServerConfigCtx FunctionPermissionsInferred RemoteSchemaPermsDisabled sqlGenCtx maintenanceMode mempty
|
|
cacheBuildParams = CacheBuildParams httpManager (mkPgSourceResolver print) serverConfigCtx
|
|
pgLogger = print
|
|
|
|
run :: MetadataStorageT (PGMetadataStorageAppT CacheBuild) a -> IO a
|
|
run =
|
|
runMetadataStorageT
|
|
>>> flip runPGMetadataStorageAppT (pgPool, pgLogger)
|
|
>>> runCacheBuild cacheBuildParams
|
|
>>> runExceptT
|
|
>=> flip onLeft printErrJExit
|
|
>=> flip onLeft printErrJExit
|
|
|
|
(metadata, schemaCache) <- run do
|
|
metadata <- snd <$> (liftEitherM . runExceptT . runLazyTx pgContext Q.ReadWrite)
|
|
(migrateCatalog (Just sourceConfig) maintenanceMode =<< liftIO getCurrentTime)
|
|
schemaCache <- lift $ lift $ buildRebuildableSchemaCache envMap metadata
|
|
pure (metadata, schemaCache)
|
|
|
|
cacheRef <- newMVar schemaCache
|
|
pure $ NT (run . flip MigrateSpec.runCacheRefT cacheRef . fmap fst . runMetadataT metadata)
|
|
|
|
pure $ beforeAll setupCacheRef $
|
|
describe "Hasura.Server.Migrate" $ MigrateSpec.spec sourceConfig pgContext pgConnInfo
|
|
|
|
parseArgs :: IO TestSuites
|
|
parseArgs = execParser $ info (helper <*> (parseNoCommand <|> parseSubCommand)) $
|
|
fullDesc <> header "Hasura GraphQL Engine test suite"
|
|
where
|
|
parseDbUrlTemplate =
|
|
parseDatabaseUrl <|> (fmap rawConnDetailsToUrl <$> parseRawConnDetails)
|
|
parseNoCommand = AllSuites <$> parseDbUrlTemplate
|
|
parseSubCommand = SingleSuite <$> parseHspecPassThroughArgs <*> subCmd
|
|
where
|
|
subCmd = subparser $ mconcat
|
|
[ command "unit" $ info (pure UnitSuite) $
|
|
progDesc "Only run unit tests"
|
|
, command "postgres" $ info (helper <*> (PostgresSuite <$> parseDbUrlTemplate)) $
|
|
progDesc "Only run Postgres integration tests"
|
|
]
|
|
-- Add additional arguments and tweak as needed:
|
|
hspecArgs = ["match", "skip"]
|
|
-- parse to a list of arguments as they'd appear from 'getArgs':
|
|
parseHspecPassThroughArgs :: Parser [String]
|
|
parseHspecPassThroughArgs = fmap concat $ for hspecArgs $ \nm->
|
|
fmap (maybe [] (\a -> ["--"<>nm , a])) $ optional $
|
|
strOption ( long nm <>
|
|
metavar "<PATTERN>" <>
|
|
help "Flag passed through to hspec (see hspec docs)." )
|
|
|
|
|
|
runHspec :: [String] -> Spec -> IO ()
|
|
runHspec hspecArgs m = do
|
|
config <- Hspec.readConfig Hspec.defaultConfig hspecArgs
|
|
Hspec.evaluateSummary =<< Hspec.runSpec m config
|
|
|
|
printErrExit :: String -> IO a
|
|
printErrExit = (*> exitFailure) . putStrLn
|
|
|
|
printErrJExit :: (A.ToJSON a) => a -> IO b
|
|
printErrJExit = (*> exitFailure) . BL.putStrLn . A.encode
|