mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-16 09:51:59 +03:00
862ad8e0dc
This PR updated ndc-models to the latest version on main. This version is still a 0.1.x version, but it now includes all the [new newtypes](https://github.com/hasura/ndc-spec/pull/156) that wrap previously stringly-typed things. For example, `ArgumentName`, `FieldName`, etc. This pervades across the entire engine, but thankfully the changes are mostly mechanical repetitive changes. Usually you will see conversions from `String`-typed variables into the newtypes using this sort of form: `FieldName::from(string.as_str())`, which is the most efficient way copying the value (the str slice is copied). Or you will see usages of the newtype as a raw string by `.as_str()`-ing it. Converting the newtypes into a String can be done with `.into()` if owned, but if referenced `.as_str().to_owned()` performs the clone and type conversion. Other changes: * A few minor instances of `ok_or()` usages (or similar) have been converted into lazy error construction variants (eg `ok_or_else()`) V3_GIT_ORIGIN_REV_ID: 64a371ae6197ef3be98a6f7cdc4052d654a43da0 |
||
---|---|---|
.. | ||
failing | ||
passing | ||
metadata_golden_tests.rs |