graphql-engine/server/tests-py/test_inconsistent_meta.py
Samir Talwar 987b55f981 server/tests-py: Reduce the number of locations we check the status code.
We have a lot of `assert st_code == 200` scattered about. This is a
problem because (a) it makes the code harder to parse and (b) the error
message is lacking; I have seen a few flaky tests which were impossible
to diagnose because I didn't know what the response _should_ be.

This reduces the number of places in which we perform this assertion
(moving most of them to `HGECtx.execute_query`), so that we can have a
better chance of seeing a useful error message on test failure.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4957
GitOrigin-RevId: 3ff388bccf49f96569aa6b7db85266a0c5ee27ea
2022-07-05 18:01:07 +00:00

74 lines
2.0 KiB
Python

import pytest
import json
import jsondiff
from ruamel.yaml import YAML
yaml=YAML(typ='safe', pure=True)
class TestInconsistentObjects():
reload_metadata = {
"type": "reload_metadata",
"args": {}
}
drop_inconsistent_metadata = {
"type": "drop_inconsistent_metadata",
"args": {}
}
export_metadata = {
"type": "export_metadata",
"args": {}
}
def test_inconsistent_objects(self, hge_ctx):
with open(self.dir() + "/test.yaml") as c:
test = yaml.load(c)
# setup
resp = hge_ctx.v1q(json.loads(json.dumps(test['setup'])))
try:
# exec sql to cause inconsistentancy
hge_ctx.sql(test['sql'])
# reload metadata
resp = hge_ctx.v1q(q=self.reload_metadata)
# check inconsistent objects
incons_objs_test = test['inconsistent_objects']
incons_objs_resp = resp['inconsistent_objects']
assert resp['is_consistent'] == False, resp
assert incons_objs_resp == incons_objs_test, yaml.dump({
'response': incons_objs_resp,
'expected': incons_objs_test,
'diff': jsondiff.diff(incons_objs_test, incons_objs_resp)
})
# export metadata
export = hge_ctx.v1q(q=self.export_metadata)
# apply metadata
hge_ctx.v1q(
q={
"type": "replace_metadata",
"args": export
},
expected_status_code = 400
)
finally:
# drop inconsistent objects
hge_ctx.v1q(q=self.drop_inconsistent_metadata)
# reload metadata
resp = hge_ctx.v1q(q=self.reload_metadata)
# check inconsistent objects
assert resp['is_consistent'] == True, resp
# teardown
hge_ctx.v1q(json.loads(json.dumps(test['teardown'])))
@classmethod
def dir(cls):
return 'queries/inconsistent_objects'