mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-16 18:42:30 +03:00
b4f7e96665
### Motivation While we strive to write clear code, we have historically struggled at Hasura with having very different styles and standards across the codebase. There's been efforts to standardize our coding style, we have an official styleguide that isn't maintained as closely as it should... We still have some work in front of us. However, in the last ~year or so, there's been a huge push towards incrementally improving the situation. As part of this we've been blocking PRs that don't add enough comments, or don't improve the files that they touch. While looking at `Hasura.GraphQL.Analyse`, it became apparent that this file did not meet the engineering standards that I would expect to see addressed during a code review. Some ways in which I think it falls short: - lack of documentation - no clear distinction between public / internal components - "unidiomatic" Haskell code (such as using `Either Result Error`) While there's no problem with a file looking like this during development, those issues should have been caught at review time. The fact that they weren't indicates a problem in our process that we will need to address: code quality and maintainability is paramount, and we all need to do our part. ### Description This PR rewrites all of `Hasura.GraphQL.Analyze`, and adapts `Hasura.Server.OpenAPI` accordingly where needed. I've attempted to clarify names and add documentation based on my understanding of the code, and to clean what was unused (such as field variables). I don't think this PR is good enough as is, and I welcome criticism where I got my comments wrong / am happy to help y'all add more. This PR makes one small change in the way error messages are reported (and adjusts the corresponding test accordingly); each error message is now prefixed with the path within the selection set: ``` ⚠️ $.test.foo.bar.baz.mizpelled: field 'mizpelled' not found in object 'Baz' ``` ### Note This PR is currently **on top of #3962**. You can preview the changes in isolation by [diffing the branches](https://github.com/hasura/graphql-engine-mono/compare/nicuveo/clean-rest-endpoint-inconsistency-check..nicuveo/rewrite-analysis). PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3963 Co-authored-by: paritosh-08 <85472423+paritosh-08@users.noreply.github.com> GitOrigin-RevId: 5ec38e0e753f0c12096a350db0737658495e2f15 |
||
|---|---|---|
| .. | ||
| endpoint_as_user_err.yaml | ||
| endpoint_conflicting.yaml | ||
| endpoint_dropped.yaml | ||
| endpoint_duplicate_param.yaml | ||
| endpoint_empty_path_param.yaml | ||
| endpoint_empty_path_segment.yaml | ||
| endpoint_empty_path.yaml | ||
| endpoint_missing.yaml | ||
| endpoint_query_validation.yaml | ||
| endpoint_simple_cached.yaml | ||
| endpoint_simple_wrong_method.yaml | ||
| endpoint_simple.yaml | ||
| endpoint_subscription.yaml | ||
| endpoint_trailing_slash.yaml | ||
| endpoint_with_body_arg.yaml | ||
| endpoint_with_list_arg.yaml | ||
| endpoint_with_multiple_query_args.yaml | ||
| endpoint_with_query_arg_missing_arg.yaml | ||
| endpoint_with_query_arg_url_encoded_2.yaml | ||
| endpoint_with_query_arg_url_encoded.yaml | ||
| endpoint_with_query_arg.yaml | ||
| endpoint_with_template.yaml | ||
| endpoint_with_uuid_arg.yaml | ||
| setup.yaml | ||
| teardown.yaml | ||