mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-16 09:51:59 +03:00
9bb6575d60
There are three minor cleanups here: - The first argument to the `setMetadataInCatalog` method is always `Just`. It is thus important to avoid `Maybe`, because this means that a crucial piece of code (saving metadata) is completely untested. - Rather than spelling them out, we can derive the `Semigroup`/`Monoid` instances for `MetadataModifier` through the `Endo` type. - I've renamed the name of the getter of the `MetadataModifier` newtype to **r**unMetadataModifier. Using record puns, this allows us to write: ```diff - putMetadata $ unMetadataModifier metadataModifier metadata + putMetadata $ runMetadataModifier metadata ``` which is nicer to read. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3703 GitOrigin-RevId: fd36b3c5202017f5afc943c01dfdd7c82c099bdd |
||
---|---|---|
.. | ||
Control | ||
Data | ||
Database/MSSQL | ||
GHC | ||
Hasura | ||
Network |