graphql-engine/server/src-lib/Hasura/GraphQL/Parser/Monad.hs
Auke Booij 7bead93827 server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.

Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.

Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.

Implementation

The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.

There are a few places in which one can still find references to query plan caching:

- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.

https://github.com/hasura/graphql-engine-mono/pull/1815

GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 11:52:43 +00:00

203 lines
8.2 KiB
Haskell
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

{-# LANGUAGE StrictData #-}
-- | Monad transformers for GraphQL schema construction and query parsing.
module Hasura.GraphQL.Parser.Monad
( SchemaT
, runSchemaT
, ParseT
, runParseT
, ParseError(..)
, reportParseErrors
) where
import Hasura.Prelude
import qualified Data.Dependent.Map as DM
import qualified Data.Kind as K
import qualified Data.Sequence.NonEmpty as NE
import qualified Language.Haskell.TH as TH
import Control.Monad.Unique
import Control.Monad.Validate
import Data.Dependent.Map (DMap)
import Data.GADT.Compare.Extended
import Data.IORef
import Data.Parser.JSONPath
import Data.Proxy (Proxy (..))
import System.IO.Unsafe (unsafeInterleaveIO)
import Type.Reflection (Typeable, typeRep, (:~:) (..))
import Hasura.Base.Error
import Hasura.GraphQL.Parser.Class
import Hasura.GraphQL.Parser.Schema
-- -------------------------------------------------------------------------------------------------
-- schema construction
newtype SchemaT n m a = SchemaT
{ unSchemaT :: StateT (DMap ParserId (ParserById n)) m a
} deriving (Functor, Applicative, Monad, MonadError e)
runSchemaT :: forall m n a . Monad m => SchemaT n m a -> m a
runSchemaT = flip evalStateT mempty . unSchemaT
-- | see Note [SchemaT requires MonadIO]
instance (MonadIO m, MonadUnique m, MonadParse n)
=> MonadSchema n (SchemaT n m) where
memoizeOn name key buildParser = SchemaT do
let parserId = ParserId name key
parsersById <- get
case DM.lookup parserId parsersById of
Just (ParserById parser) -> pure parser
Nothing -> do
-- We manually do eager blackholing here using a MutVar rather than
-- relying on MonadFix and ordinary thunk blackholing. Why? A few
-- reasons:
--
-- 1. We have more control. We arent at the whims of whatever
-- MonadFix instance happens to get used.
--
-- 2. We can be more precise. GHCs lazy blackholing doesnt always
-- kick in when youd expect.
--
-- 3. We can provide more useful error reporting if things go wrong.
-- Most usefully, we can include a HasCallStack source location.
cell <- liftIO $ newIORef Nothing
-- We use unsafeInterleaveIO here, which sounds scary, but
-- unsafeInterleaveIO is actually far more safe than unsafePerformIO.
-- unsafeInterleaveIO just defers the execution of the action until its
-- result is needed, adding some laziness.
--
-- That laziness can be dangerous if the action has side-effects, since
-- the point at which the effect is performed can be unpredictable. But
-- this action just reads, never writes, so that isnt a concern.
parserById <- liftIO $ unsafeInterleaveIO $ readIORef cell >>= \case
Just parser -> pure $ ParserById parser
Nothing -> error $ unlines
[ "memoize: parser was forced before being fully constructed"
, " parser constructor: " ++ TH.pprint name ]
put $! DM.insert parserId parserById parsersById
unique <- newUnique
parser <- addDefinitionUnique unique <$> unSchemaT buildParser
liftIO $ writeIORef cell (Just parser)
pure parser
-- We can add a reader in two places. I'm not sure which one is the correct
-- one. But since we don't seem to change the values that are being read, I
-- don't think it matters.
deriving instance Monad m => MonadReader a (SchemaT n (ReaderT a m))
instance (MonadIO m, MonadUnique m, MonadParse n)
=> MonadSchema n (ReaderT a (SchemaT n m)) where
memoizeOn name key = mapReaderT (memoizeOn name key)
{- Note [SchemaT requires MonadIO]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The MonadSchema instance for SchemaT requires MonadIO, which is unsatisfying.
The only reason the constraint is needed is to implement knot-tying via IORefs
(see Note [Tying the knot] in Hasura.GraphQL.Parser.Class), which really only
requires the power of ST. Using ST would be much nicer, since we could discharge
the burden locally, but unfortunately we also want to use MonadUnique, which
is handled by IO in the end.
This means that we need IO at the base of our monad, so to use STRefs, wed need
a hypothetical STT transformer (i.e. a monad transformer version of ST). But
such a thing isnt safe in general, since reentrant monads like ListT or ContT
would incorrectly share state between the different threads of execution.
In theory, this can be resolved by using something like Vault (from the vault
package) to create “splittable” sets of variable references. That would allow
you to create a transformer with an STRef-like interface that works over any
arbitrary monad. However, while the interface would be safe, the implementation
of such an abstraction requires unsafe primitives, and to the best of my
knowledge no such transformer exists in any existing libraries.
So we decide it isnt worth the trouble and just use MonadIO. If `eff` ever pans
out, it should be able to support this more naturally, so we can fix it then. -}
-- | A key used to distinguish calls to 'memoize'd functions. The 'TH.Name'
-- distinguishes calls to completely different parsers, and the @a@ value
-- records the arguments.
data ParserId (t :: ((K.Type -> K.Type) -> K.Type -> K.Type, K.Type)) where
ParserId :: (Ord a, Typeable p, Typeable a, Typeable b) => TH.Name -> a -> ParserId '(p, b)
instance GEq ParserId where
geq (ParserId name1 (arg1 :: a1) :: ParserId t1)
(ParserId name2 (arg2 :: a2) :: ParserId t2)
| _ :: Proxy '(p1, b1) <- Proxy @t1
, _ :: Proxy '(p2, b2) <- Proxy @t2
, name1 == name2
, Just Refl <- typeRep @a1 `geq` typeRep @a2
, arg1 == arg2
, Just Refl <- typeRep @p1 `geq` typeRep @p2
, Just Refl <- typeRep @b1 `geq` typeRep @b2
= Just Refl
| otherwise = Nothing
instance GCompare ParserId where
gcompare (ParserId name1 (arg1 :: a1) :: ParserId t1)
(ParserId name2 (arg2 :: a2) :: ParserId t2)
| _ :: Proxy '(p1, b1) <- Proxy @t1
, _ :: Proxy '(p2, b2) <- Proxy @t2
= strengthenOrdering (compare name1 name2)
`extendGOrdering` gcompare (typeRep @a1) (typeRep @a2)
`extendGOrdering` strengthenOrdering (compare arg1 arg2)
`extendGOrdering` gcompare (typeRep @p1) (typeRep @p2)
`extendGOrdering` gcompare (typeRep @b1) (typeRep @b2)
`extendGOrdering` GEQ
-- | A newtype wrapper around a 'Parser' that rearranges the type parameters
-- so that it can be indexed by a 'ParserId' in a 'DMap'.
--
-- This is really just a single newtype, but its implemented as a data family
-- because GHC doesnt allow ordinary datatype declarations to pattern-match on
-- type parameters, and we want to match on the tuple.
data family ParserById (m :: K.Type -> K.Type) (a :: ((K.Type -> K.Type) -> K.Type -> K.Type, K.Type))
newtype instance ParserById m '(p, a) = ParserById (p m a)
-- -------------------------------------------------------------------------------------------------
-- query parsing
newtype ParseT m a = ParseT
{ unParseT :: ReaderT JSONPath (ValidateT (NESeq ParseError) m) a
} deriving (Functor, Applicative, Monad)
runParseT
:: Functor m
=> ParseT m a
-> m (Either (NESeq ParseError) a)
runParseT = unParseT
>>> flip runReaderT []
>>> runValidateT
instance MonadTrans ParseT where
lift = ParseT . lift . lift
instance Monad m => MonadParse (ParseT m) where
withPath f x = ParseT $ withReaderT f $ unParseT x
parseErrorWith code text = ParseT $ do
path <- ask
lift $ refute $ NE.singleton ParseError{ peCode = code, pePath = path, peMessage = text }
data ParseError = ParseError
{ pePath :: JSONPath
, peMessage :: Text
, peCode :: Code
}
reportParseErrors
:: MonadError QErr m
=> NESeq ParseError
-> m a
reportParseErrors errs = case NE.head errs of
-- TODO: Our error reporting machinery doesnt currently support reporting
-- multiple errors at once, so were throwing away all but the first one
-- here. It would be nice to report all of them!
ParseError{ pePath, peMessage, peCode } ->
throwError (err400 peCode peMessage){ qePath = pePath }