Antoine Leblanc a023a3259d Prevent uses of unsafeMkName whenever possible. ... ### Description This PR is the result of a discussion in #3363. Namely, we would like to remove all uses of `unsafeMkName`, or at the very least document every single one of them, to avoid similar issues. To do so, this PR does the following: - it adds a hlint suggestion not to use that function: - suggestions don't mark the PR as failed, but will be shown at review time - it is possible to disable that hint with `{- HLINT ignore myFunction "unsafe" -}` - wherever possible, it removes uses of `unsafeMkName` in favour of `mkName` - it adds a comment with a tracking issue for the two remaining uses: - #3478 - #3479 ### Remaining work - discuss whether this hint should make the linter step fail, since the linter step isn't required to merge anyway, and there is a way to disable the hint wherever we think the use of that function is acceptable - check that none of those uses were load-bearing and result in errors now PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3480 GitOrigin-RevId: 0a7e3e9d1a48185764c04ab61e34b58273af347c		2022-01-27 15:13:37 +00:00
..
Collect.hs	server: add support for nested object type in action	2021-12-15 23:52:43 +00:00
Join.hs	Prevent uses of unsafeMkName whenever possible.	2022-01-27 15:13:37 +00:00
RemoteSchema.hs	Prevent uses of unsafeMkName whenever possible.	2022-01-27 15:13:37 +00:00
Types.hs	simplification of generalized joins execution	2021-12-07 13:12:57 +00:00