mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-19 05:21:47 +03:00
eaba2e08d3
## Motivation This PR rewrites most of Relay to achieve the following: - ~~fix a bug in which the same node id could refer to two different tables in the schema~~ - remove one of the few remaining uses of the source cache in the schema building code In doing so, it also: - simplifies the `BackendSchema` class by removing `node` from it, - makes it much easier for other backends to support Relay, - documents, re-organizes, and clarifies the code. ## Description This PR introduces a new `NodeId` version ~~, and adapts the Postgres code to always generate this V2 version~~. This new id contains the source name, in addition to the table name, in order to disambiguate similar table names across different sources (which is now possible with source customization). In doing so, it now explicitly handles that case for V1 node ids, and returns an explicit error message instead of running the risk of _silently returning the wrong information_. Furthermore, it adapts `nodeField` to support multiple backends; most of the code was trivial to generalize, and as a result it lowers the cost of entry for other backends, that now only need to support `AFNodeId` in their translation layer. Finally, it removes one more cycle in the schema building code, by using the same trick we used for remote relationships instead of using the memoization trick of #4576. ## Remaining work - ~~[ ]write a Changelog entry~~ - ~~[x] adapt all tests that were asserting on an old node id~~ ## Future work This PR was adapted from its original form to avoid a breaking change: while it introduces a Node ID V2, we keep generating V1 IDs and the parser rejects V2 IDs. It will be easy to make the switch at a later data in a subsequent PR. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4593 GitOrigin-RevId: 88e5cb91e8b0646900547fa8c7c0e1463de267a1
155 lines
6.0 KiB
Haskell
155 lines
6.0 KiB
Haskell
{-# OPTIONS_GHC -Wno-redundant-constraints #-}
|
|
|
|
-- | This module defines the monads required to run parser tests.
|
|
--
|
|
-- Warning: a lot of the implementations are currently 'undefined'. As we write
|
|
-- more advanced tests, they might require implementations.
|
|
module Test.Parser.Monad
|
|
( ParserTestT (..),
|
|
SchemaEnvironment,
|
|
SchemaTestT (..),
|
|
)
|
|
where
|
|
|
|
import Data.Aeson.Internal (JSONPath)
|
|
import Data.Has (Has (..))
|
|
import Data.Text qualified as T
|
|
import Hasura.Base.Error (Code, QErr)
|
|
import Hasura.GraphQL.Parser.Class (MonadParse (..), MonadSchema (..))
|
|
import Hasura.GraphQL.Parser.Schema (MkTypename (..))
|
|
import Hasura.GraphQL.Schema.Common (SchemaContext (..), SchemaKind (..), SchemaOptions (..), ignoreRemoteRelationship)
|
|
import Hasura.Prelude
|
|
import Hasura.RQL.Types.Common (StringifyNumbers (LeaveNumbersAlone))
|
|
import Hasura.RQL.Types.Function (FunctionPermissionsCtx (..))
|
|
import Hasura.RQL.Types.RemoteSchema (RemoteSchemaPermsCtx (..))
|
|
import Hasura.RQL.Types.SourceCustomization (CustomizeRemoteFieldName, MkRootFieldName, NamingCase (..))
|
|
import Hasura.Session (RoleName, adminRoleName)
|
|
import Language.Haskell.TH.Syntax qualified as TH
|
|
import Test.Hspec
|
|
|
|
notImplemented :: String -> a
|
|
notImplemented location =
|
|
error $ "Not implemented: Test.Parser.Monad." <> location
|
|
|
|
-- | Monad builder environment.
|
|
--
|
|
-- Parser functions generally have a return type of @m (Parser n)@. The @m@
|
|
-- parameter is mocked through 'SchemaTestT', which requires a bunch of 'Has'
|
|
-- instances, as well as a 'ReaderT' instance for environment
|
|
-- settings/configurations. This type repesents these settings.
|
|
--
|
|
-- SchemaEnvironment: currently void. This is subject to change if we require
|
|
-- more complex setup.
|
|
data SchemaEnvironment
|
|
|
|
instance Has NamingCase SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> NamingCase
|
|
getter = const HasuraCase
|
|
|
|
modifier :: (NamingCase -> NamingCase) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has NamingCase SchemaEnvironment>"
|
|
|
|
instance Has RoleName SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> RoleName
|
|
getter = const adminRoleName
|
|
|
|
modifier :: (RoleName -> RoleName) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has RoleName SchemaEnvironment>"
|
|
|
|
instance Has SchemaOptions SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> SchemaOptions
|
|
getter =
|
|
const
|
|
SchemaOptions
|
|
{ soStringifyNum = LeaveNumbersAlone,
|
|
soDangerousBooleanCollapse = False,
|
|
soFunctionPermsContext = FunctionPermissionsInferred,
|
|
soRemoteSchemaPermsCtx = RemoteSchemaPermsDisabled,
|
|
soOptimizePermissionFilters = False
|
|
}
|
|
|
|
modifier :: (SchemaOptions -> SchemaOptions) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has SchemaOptions SchemaEnvironment>"
|
|
|
|
instance Has SchemaContext SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> SchemaContext
|
|
getter =
|
|
const
|
|
SchemaContext
|
|
{ scSchemaKind = HasuraSchema,
|
|
scSourceCache = mempty,
|
|
scRemoteRelationshipParserBuilder = ignoreRemoteRelationship
|
|
}
|
|
|
|
modifier :: (SchemaContext -> SchemaContext) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has SchemaContext SchemaEnvironment>"
|
|
|
|
instance Has MkTypename SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> MkTypename
|
|
getter = const (MkTypename id)
|
|
|
|
modifier :: (MkTypename -> MkTypename) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has MkTypeName SchemaEnvironment>"
|
|
|
|
instance Has MkRootFieldName SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> MkRootFieldName
|
|
getter = const mempty
|
|
|
|
modifier :: (MkRootFieldName -> MkRootFieldName) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has MkRootFieldName SchemaEnvironment>"
|
|
|
|
instance Has CustomizeRemoteFieldName SchemaEnvironment where
|
|
getter :: SchemaEnvironment -> CustomizeRemoteFieldName
|
|
getter = notImplemented "getter<Has CustomizeRemoteFieldName SchemaEnvironment>"
|
|
|
|
modifier :: (CustomizeRemoteFieldName -> CustomizeRemoteFieldName) -> SchemaEnvironment -> SchemaEnvironment
|
|
modifier = notImplemented "modifier<Has CustomizeRemoteFieldName SchemaEnvironment>"
|
|
|
|
-------------------------------------------------------------------------------
|
|
|
|
-- | SchemaTestT
|
|
newtype SchemaTestT a = SchemaTestT a
|
|
deriving stock (Functor)
|
|
deriving (Applicative, Monad) via Identity
|
|
|
|
instance MonadError QErr SchemaTestT where
|
|
throwError :: forall a. QErr -> SchemaTestT a
|
|
throwError = notImplemented "throwError<MonadError QErr SchemaTestT>"
|
|
|
|
catchError :: forall a. SchemaTestT a -> (QErr -> SchemaTestT a) -> SchemaTestT a
|
|
catchError = notImplemented "catchError<MonadError QErr SchemaTestT>"
|
|
|
|
-- | Note this is not used because all the actual getters/setters for
|
|
-- SchemaEnvironment are @const X@, so these bottoms never actually get
|
|
-- evaluated.
|
|
instance MonadReader SchemaEnvironment SchemaTestT where
|
|
ask :: SchemaTestT SchemaEnvironment
|
|
ask = notImplemented "ask<MonadReader SchemaEnvironment SchemaTestT>"
|
|
|
|
local :: (SchemaEnvironment -> SchemaEnvironment) -> SchemaTestT a -> SchemaTestT a
|
|
local = notImplemented "local<MonadReader SchemaEnvironment SchemaTestT>"
|
|
|
|
-------------------------------------------------------------------------------
|
|
|
|
-- | ParserTestT
|
|
--
|
|
-- Encodes an assertion error (as `Left`) or a value as `Right`.
|
|
newtype ParserTestT a = ParserTestT (Either (IO ()) a)
|
|
deriving stock (Functor)
|
|
deriving (Applicative, Monad) via (Either (IO ()))
|
|
|
|
instance MonadSchema ParserTestT SchemaTestT where
|
|
memoizeOn :: TH.Name -> a -> SchemaTestT (p ParserTestT b) -> SchemaTestT (p ParserTestT b)
|
|
memoizeOn _ _ = id
|
|
|
|
instance MonadParse ParserTestT where
|
|
withPath :: (JSONPath -> JSONPath) -> ParserTestT a -> ParserTestT a
|
|
withPath = const id
|
|
|
|
parseErrorWith :: Code -> Text -> ParserTestT a
|
|
parseErrorWith code text =
|
|
ParserTestT
|
|
. Left
|
|
. expectationFailure
|
|
$ show code <> ": " <> T.unpack text
|