mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-19 21:41:44 +03:00
eab4f75212
This introduces an `ErrorMessage` newtype which wraps `Text` in a manner which is designed to be easy to construct, and difficult to deconstruct. It provides functionality similar to `Data.Text.Extended`, but designed _only_ for error messages. Error messages are constructed through `fromString`, concatenation, or the `toErrorValue` function, which is designed to be overridden for all meaningful domain types that might show up in an error message. Notably, there are not and should never be instances of `ToErrorValue` for `String`, `Text`, `Int`, etc. This is so that we correctly represent the value in a way that is specific to its type. For example, all `Name` values (from the _graphql-parser-hs_ library) are single-quoted now; no exceptions. I have mostly had to add `instance ToErrorValue` for various backend types (and also add newtypes where necessary). Some of these are not strictly necessary for this changeset, as I had bigger aspirations when I started. These aspirations have been tempered by trying and failing twice. As such, in this changeset, I have started by introducing this type to the `parseError` and `parseErrorWith` functions. In the future, I would like to extend this to the `QErr` record and the various `throwError` functions, but this is a much larger task and should probably be done in stages. For now, `toErrorMessage` and `fromErrorMessage` are provided for conversion to and from `Text`, but the intent is to stop exporting these once all error messages are converted to the new type. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5018 GitOrigin-RevId: 84b37e238992e4312255a87ca44f41af65e2d89a
47 lines
1.5 KiB
Haskell
47 lines
1.5 KiB
Haskell
-- | Error messages
|
|
--
|
|
-- This module defines a type for user facing error messages.
|
|
--
|
|
-- To construct a value of this type, use `toErrorMessage` or the 'IsString' interface,
|
|
-- the type class 'ToErrorValue' defined in the "Hasura.Base.ToErrorValue" module,
|
|
-- or use the utility functions defined in the "Hasura.Base.ErrorValue" module.
|
|
--
|
|
-- 'ErrorMessage's can also be composed using the 'Semigroup' interface.
|
|
--
|
|
-- To fail with an error message in monadic code, use the 'failWithMessage' function.
|
|
module Hasura.Base.ErrorMessage
|
|
( ErrorMessage,
|
|
ErrorMessageOr,
|
|
toErrorMessage,
|
|
fromErrorMessage,
|
|
failWithMessage,
|
|
)
|
|
where
|
|
|
|
import Data.Aeson
|
|
import Data.String (IsString (..))
|
|
import Data.Text qualified as Text
|
|
import Hasura.Prelude
|
|
|
|
-- | 'ErrorMessage' wraps a 'Text' value such that it's easy to build up,
|
|
-- but difficult to break apart or extract the underlying text value.
|
|
newtype ErrorMessage = ErrorMessage
|
|
{ -- | A temporary extractor which will go away once 'ErrorMessage' is pervasive.
|
|
fromErrorMessage :: Text
|
|
}
|
|
deriving newtype (Eq, Semigroup, ToJSON)
|
|
|
|
-- | A smart constructor for 'ErrorMessage' so that it cannot be deconstructed.
|
|
toErrorMessage :: Text -> ErrorMessage
|
|
toErrorMessage = ErrorMessage
|
|
|
|
-- | Fails with the given message.
|
|
failWithMessage :: MonadFail m => ErrorMessage -> m ()
|
|
failWithMessage = fail . Text.unpack . fromErrorMessage
|
|
|
|
instance IsString ErrorMessage where
|
|
fromString = ErrorMessage . Text.pack
|
|
|
|
-- | A simple alias to prevent duplication.
|
|
type ErrorMessageOr = Either ErrorMessage
|