mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 04:24:35 +03:00
0c1016e065
Previously invalid REST endpoints would throw errors during schema cache build. This PR changes the validation to instead add to the inconsistent metadata objects in order to allow use of `allow_inconsistent_metadata` with inconsistent REST endpoints. All non-fatal endpoint definition errors are returned as inconsistent metadata warnings/errors depending on the use of `allow_inconsistent_metadata`. The endpoints with issues are then created and return informational runtime errors when they are called. Console impact when creating endpoints is that error messages now refer to metadata inconsistencies rather than REST feature at the top level:  <img width="969" alt="image" src="https://user-images.githubusercontent.com/92299/110258597-8336fa00-7ff7-11eb-872c-bfca945aa0e8.png"> Note: Conflicting endpoints generate one error per conflicting set of endpoints due to the implementation of `groupInconsistentMetadataById` and `imObjectIds`. This is done to ensure that error messages are terse, but may pose errors if there are some assumptions made surrounding `imObjectIds`. Related to https://github.com/hasura/graphql-engine-mono/pull/473 (Allow Inconsistent Metadata (v2) #473 (Merged)) --- ### Kodiak commit message Changes the validation to use inconsistent metadata objects for REST endpoint issues. #### Commit title Inconsistent metadata for REST endpoints GitOrigin-RevId: b9de971208e9bb0a319c57df8dace44cb115ff66
78 lines
3.5 KiB
Python
78 lines
3.5 KiB
Python
import pytest
|
|
import os
|
|
from validate import check_query_f, check_query, get_conf_f
|
|
from context import PytestConf
|
|
|
|
import redis
|
|
|
|
@pytest.mark.parametrize("transport", ['http'])
|
|
@pytest.mark.usefixtures('per_class_tests_db_state')
|
|
class TestCustomEndpoints:
|
|
def flushRedis(self):
|
|
# TODO: Move this into setup/teardown
|
|
r = redis.from_url(PytestConf.config.getoption('--redis-url'))
|
|
r.flushall()
|
|
|
|
@classmethod
|
|
def dir(cls):
|
|
return 'queries/endpoints'
|
|
|
|
def test_missing_endpoint(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_missing.yaml', transport)
|
|
|
|
def test_simple_endpoint(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_simple.yaml', transport)
|
|
|
|
def test_simple_endpoint_wrong_method(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_simple_wrong_method.yaml', transport)
|
|
|
|
@pytest.mark.skipif(not PytestConf.config.getoption('--redis-url'), reason="Must enable redis")
|
|
def test_simple_cached_endpoint(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_simple_cached.yaml', transport)
|
|
self.flushRedis()
|
|
|
|
def test_endpoint_with_query_arg(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_query_arg.yaml', transport)
|
|
|
|
def test_endpoint_with_body_arg(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_body_arg.yaml', transport)
|
|
|
|
def test_endpoint_with_query_arg_url_encoded(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_query_arg_url_encoded.yaml', transport)
|
|
|
|
def test_endpoint_with_query_arg_url_encoded_2(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_query_arg_url_encoded_2.yaml', transport)
|
|
|
|
def test_endpoint_with_query_args_missing_arg(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_query_arg_missing_arg.yaml', transport)
|
|
|
|
def test_endpoint_with_multiple_query_args(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_multiple_query_args.yaml', transport)
|
|
|
|
def test_endpoint_with_template(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_with_template.yaml', transport)
|
|
|
|
def test_endpoint_dropped(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_dropped.yaml', transport)
|
|
|
|
def test_endpoint_conflicting(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_conflicting.yaml', transport)
|
|
|
|
def test_endpoint_duplicate_param(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_duplicate_param.yaml', transport)
|
|
|
|
def test_endpoint_empty_path(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_empty_path.yaml', transport)
|
|
|
|
def test_endpoint_trailing_slash(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_trailing_slash.yaml', transport)
|
|
|
|
def test_endpoint_empty_path_segment(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_empty_path_segment.yaml', transport)
|
|
|
|
def test_endpoint_empty_path_param(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_empty_path_param.yaml', transport)
|
|
|
|
def test_endpoint_subscription(self, hge_ctx, transport):
|
|
check_query_f(hge_ctx, self.dir() + '/endpoint_subscription.yaml', transport)
|