mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-16 01:44:03 +03:00
eab4f75212
This introduces an `ErrorMessage` newtype which wraps `Text` in a manner which is designed to be easy to construct, and difficult to deconstruct. It provides functionality similar to `Data.Text.Extended`, but designed _only_ for error messages. Error messages are constructed through `fromString`, concatenation, or the `toErrorValue` function, which is designed to be overridden for all meaningful domain types that might show up in an error message. Notably, there are not and should never be instances of `ToErrorValue` for `String`, `Text`, `Int`, etc. This is so that we correctly represent the value in a way that is specific to its type. For example, all `Name` values (from the _graphql-parser-hs_ library) are single-quoted now; no exceptions. I have mostly had to add `instance ToErrorValue` for various backend types (and also add newtypes where necessary). Some of these are not strictly necessary for this changeset, as I had bigger aspirations when I started. These aspirations have been tempered by trying and failing twice. As such, in this changeset, I have started by introducing this type to the `parseError` and `parseErrorWith` functions. In the future, I would like to extend this to the `QErr` record and the various `throwError` functions, but this is a much larger task and should probably be done in stages. For now, `toErrorMessage` and `fromErrorMessage` are provided for conversion to and from `Text`, but the intent is to stop exporting these once all error messages are converted to the new type. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5018 GitOrigin-RevId: 84b37e238992e4312255a87ca44f41af65e2d89a
56 lines
1.1 KiB
YAML
56 lines
1.1 KiB
YAML
- description: Passing null value for nullable type
|
|
url: /v1/graphql
|
|
status: 200
|
|
response:
|
|
data:
|
|
author: []
|
|
query:
|
|
variables:
|
|
limit: null
|
|
query: |
|
|
query author($limit: Int) {
|
|
author(limit: $limit) {
|
|
id
|
|
name
|
|
}
|
|
}
|
|
|
|
- description: Passing null value for non-nullable type with default value
|
|
url: /v1/graphql
|
|
status: 200
|
|
response:
|
|
data:
|
|
author: []
|
|
query:
|
|
variables:
|
|
limit: null
|
|
query: |
|
|
query author($limit: Int! = 1) {
|
|
author(limit: $limit) {
|
|
id
|
|
name
|
|
}
|
|
}
|
|
|
|
- description: Passing null value for non nullable type
|
|
url: /v1/graphql
|
|
status: 200
|
|
response:
|
|
errors:
|
|
- extensions:
|
|
path: $.selectionSet.update_author.args.where.id._eq
|
|
code: validation-failed
|
|
message: unexpected null value for type 'Int'
|
|
query:
|
|
variables:
|
|
author_id: null
|
|
query: |
|
|
mutation update_author($author_id: Int!) {
|
|
update_author(where: {id: {_eq: $author_id}}, _set: {name: ""}) {
|
|
returning {
|
|
id
|
|
name
|
|
}
|
|
}
|
|
}
|