mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-15 17:31:56 +03:00
08da0c63b6
Resolves Issues: * https://github.com/hasura/graphql-engine-mono/issues/658 - Invalid Slashes * https://github.com/hasura/graphql-engine-mono/issues/628 - Subscriptions Implementation: * Moved some logic from Endpoint.hs to allow reuse of splitting url into PathSegments. * Additional validation steps alongside checking for overlapping routes * Logging potential misuse of GET for mutations Future Work: * [ ] GET is allowed for mutations (Ignore/Log warning for Now) * [ ] Add to scInconsistentObjs rather than throwing error * Add information to scInconsistentObjs instead of raising errors directly. TODO: * [x] Duplicate variable segments with the same name in the location should not be allowed * [x] We should throw an error on trailing and leading slashes and URLs which contain empty segments * [x] Endpoints can be created using subscriptions. But the error only shows at the time of the query * [x] Tests --- ### Kodiak commit message Prohibit Invalid slashes, duplicate variables, subscriptions for REST endpoints. GitOrigin-RevId: 86c0d4af97984c8afd02699e6071e9c1658710b8 |
||
|---|---|---|
| .. | ||
| endpoint_conflicting.yaml | ||
| endpoint_dropped.yaml | ||
| endpoint_duplicate_param.yaml | ||
| endpoint_empty_path_param.yaml | ||
| endpoint_empty_path_segment.yaml | ||
| endpoint_empty_path.yaml | ||
| endpoint_missing.yaml | ||
| endpoint_simple_cached.yaml | ||
| endpoint_simple_wrong_method.yaml | ||
| endpoint_simple.yaml | ||
| endpoint_subscription.yaml | ||
| endpoint_trailing_slash.yaml | ||
| endpoint_with_body_arg.yaml | ||
| endpoint_with_multiple_query_args.yaml | ||
| endpoint_with_query_arg_missing_arg.yaml | ||
| endpoint_with_query_arg_url_encoded_2.yaml | ||
| endpoint_with_query_arg_url_encoded.yaml | ||
| endpoint_with_query_arg.yaml | ||
| endpoint_with_template.yaml | ||
| setup.yaml | ||
| teardown.yaml | ||