mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 12:31:52 +03:00
d6d5c55c13
In hasura/graphql-engine@7547786b2b, we made the logic that does a specific correctness check on the GraphQL schema runnable _post_-startup. However, in order to error out as early as possible, we explicitly do it on startup anyway. Unfortunately a few instances of that logic were forgotten: until now we only executed it for non-relay authenticated GraphQL schemas. This re-implements the "conflicting types" check for both the Relay schema, and for the unauthenticated schemas. One key point where it does _not_ re-implement it is in `buildFullestDBSchema`, which is a very sketchy method that builds a GraphQL schema that is _only_ used internally in order to mark parts of the schema as inconsistent. There are two reasons I do not add the check here: - This logic should get replaced entirely - see hasura/graphql-engine-mono#3882. - Having conflicting types in `buildFullestDBSchema` does not imply there is actually a user-facing issue. The only "conflicting types" which are problematic are the ones which result in illegal _user-facing_ GraphQL schemas. `buildFullestDBSchema` is _never_ user-facing. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3885 GitOrigin-RevId: 49517dcbf51bcd97a3890514ec5e47499f770f32 |
||
|---|---|---|
| .. | ||
| Execute | ||
| Parser | ||
| Schema | ||
| Transport | ||
| Analyse.hs | ||
| Context.hs | ||
| Execute.hs | ||
| Explain.hs | ||
| Logging.hs | ||
| Namespace.hs | ||
| ParameterizedQueryHash.hs | ||
| Parser.hs | ||
| RemoteServer.hs | ||
| Schema.hs | ||