mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-18 13:02:11 +03:00
81d9071948
## Description When setting up a remote relationship to a remote schema, values coming from the left-hand side are given as _arguments_ to the targeted field of the remote schema. In turn, that means we need to adjust the arguments to that remote field; in the case of input objects, it means creating a brand new input object in which the relevant fields have been removed. To both avoid conflicts, and be explicit, we give a pretty verbose name to such an input object: its original name, followed by "remote_rel", followed by the full name of the field (table name + relationship name). The bug there was introduced when working on extending remote relationships to other backends: we changed the code that translates the table name to a graphql identifier to be generic, and use the table's `ToTxt` instance instead. However, when a table is not in the default schema, the character used by that instance is `.`, which is not a valid GraphQL name. This PR fixes it, by doing two things: - it defines a safe function to translate LHS identifiers to graphql names (by replacing all invalid characters by `_`) - it doesn't use `unsafeMkName` anymore, and checks at validation time that the type name is correct ## Further work On this PR: - [x] add a test - [x] write a Changelog entry Beyond this PR, we might want to: - prioritize #1747 - analyze all calls to `unsafeMkName` and remove as many as possible PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3363 GitOrigin-RevId: fe98eb1d34157b2c8323af453f5c369de616af38 |
||
|---|---|---|
| .. | ||
| argument_presets | ||
| inheritance | ||
| remote_relationships | ||
| schema_customization | ||
| update_remote_schema | ||
| add_permission_with_dangling_fields.yaml | ||
| add_permission_with_valid_subset_of_arguments.yaml | ||
| add_permission_with_valid_subset_of_fields.yaml | ||
| argument_preset_validation.yaml | ||
| execution_with_partial_args_exposed_to_role.yaml | ||
| execution_with_partial_fields_exposed_to_role_cached.yaml | ||
| execution_with_partial_fields_exposed_to_role.yaml | ||
| role_based_schema_enum_validations.yaml | ||
| role_based_schema_input_object_validation.yaml | ||
| role_based_schema_interface_validation.yaml | ||
| role_based_schema_object_validation.yaml | ||
| role_based_schema_scalar_validation.yaml | ||
| role_based_schema_union_validation.yaml | ||
| setup.yaml | ||
| teardown.yaml | ||
| unknown_role_execution.yaml | ||