mirror of
https://github.com/hasura/graphql-engine.git
synced 2024-12-17 20:41:49 +03:00
eaba2e08d3
## Motivation This PR rewrites most of Relay to achieve the following: - ~~fix a bug in which the same node id could refer to two different tables in the schema~~ - remove one of the few remaining uses of the source cache in the schema building code In doing so, it also: - simplifies the `BackendSchema` class by removing `node` from it, - makes it much easier for other backends to support Relay, - documents, re-organizes, and clarifies the code. ## Description This PR introduces a new `NodeId` version ~~, and adapts the Postgres code to always generate this V2 version~~. This new id contains the source name, in addition to the table name, in order to disambiguate similar table names across different sources (which is now possible with source customization). In doing so, it now explicitly handles that case for V1 node ids, and returns an explicit error message instead of running the risk of _silently returning the wrong information_. Furthermore, it adapts `nodeField` to support multiple backends; most of the code was trivial to generalize, and as a result it lowers the cost of entry for other backends, that now only need to support `AFNodeId` in their translation layer. Finally, it removes one more cycle in the schema building code, by using the same trick we used for remote relationships instead of using the memoization trick of #4576. ## Remaining work - ~~[ ]write a Changelog entry~~ - ~~[x] adapt all tests that were asserting on an old node id~~ ## Future work This PR was adapted from its original form to avoid a breaking change: while it introduces a Node ID V2, we keep generating V1 IDs and the parser rejects V2 IDs. It will be easy to make the switch at a later data in a subsequent PR. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4593 GitOrigin-RevId: 88e5cb91e8b0646900547fa8c7c0e1463de267a1 |
||
|---|---|---|
| .. | ||
| actions | ||
| compression | ||
| endpoints | ||
| event_triggers | ||
| explain | ||
| graphql_introspection | ||
| graphql_mutation | ||
| graphql_query | ||
| graphql_validation | ||
| heterogeneous | ||
| horizontal_scale/basic | ||
| inconsistent_objects | ||
| logging | ||
| naming_conventions | ||
| openapi | ||
| query_cache | ||
| remote_schemas | ||
| scheduled_triggers | ||
| schema/duplication | ||
| subscriptions | ||
| unauthorized_role | ||
| v1 | ||
| v2 | ||
| webhooks/request_context | ||
| clear_db_bigquery.yaml | ||
| clear_db_citus.yaml | ||
| clear_db_mssql.yaml | ||
| clear_db.yaml | ||