TSK-1148: Mixin button for Vacancy and NPE fixes (#2965)

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>

packages/core/src/client.ts

@@ -164,6 +164,9 @@ export async function createClient (
   let lastTx: number
 
   function txHandler (tx: Tx): void {
+    if (tx === null) {
+      return
+    }
     if (client === null) {
       txBuffer?.push(tx)
     } else {

packages/ui/src/components/EditBox.svelte

@@ -65,6 +65,9 @@
   })
 
   function computeSize (t: HTMLInputElement | EventTarget | null) {
+    if (t == null) {
+      return
+    }
     const target = t as HTMLInputElement
     const value = target.value
     text.innerHTML = (value === '' ? phTraslate : value)

plugins/recruit-resources/src/components/EditVacancy.svelte

@@ -21,7 +21,7 @@
   import { Vacancy } from '@hcengineering/recruit'
   import { FullDescriptionBox } from '@hcengineering/text-editor'
   import tracker from '@hcengineering/tracker'
-  import { Button, Component, EditBox, Grid, IconMoreH, showPopup } from '@hcengineering/ui'
+  import { Button, Component, EditBox, Grid, IconMixin, IconMoreH, showPopup } from '@hcengineering/ui'
   import { ContextMenu, DocAttributeBar } from '@hcengineering/view-resources'
   import { createEventDispatcher } from 'svelte'
   import recruit from '../plugin'
@@ -34,6 +34,8 @@
   let rawName: string = ''
   let rawDesc: string = ''
 
+  let showAllMixins = false
+
   const dispatch = createEventDispatcher()
 
   const client = getClient()
@@ -65,16 +67,20 @@
   const hierarchy = client.getHierarchy()
   let mixins: Mixin<Doc>[] = []
 
-  function getMixins (object: Doc): void {
+  function getMixins (object: Doc, showAllMixins: boolean): void {
     if (object === undefined) return
     const descendants = hierarchy.getDescendants(core.class.Doc).map((p) => hierarchy.getClass(p))
 
     mixins = descendants.filter(
-      (m) => m.kind === ClassifierKind.MIXIN && !ignoreMixins.has(m._id) && hierarchy.hasMixin(object, m._id)
+      (m) =>
+        m.kind === ClassifierKind.MIXIN &&
+        !ignoreMixins.has(m._id) &&
+        (hierarchy.hasMixin(object, m._id) ||
+          (showAllMixins && hierarchy.isDerived(object._class, hierarchy.getBaseClass(m._id))))
     )
   }
 
-  $: getMixins(object)
+  $: getMixins(object, showAllMixins)
 </script>
 
 {#if object}
@@ -101,6 +107,20 @@
       {/if}
     </svelte:fragment>
     <svelte:fragment slot="attributes" let:direction={dir}>
+      <div class="flex flex-reverse flex-no-shrink clear-mins">
+        <Button
+          kind={'transparent'}
+          shape={'round'}
+          selected={showAllMixins}
+          on:click={() => {
+            showAllMixins = !showAllMixins
+          }}
+        >
+          <svelte:fragment slot="content">
+            <IconMixin size={'small'} />
+          </svelte:fragment>
+        </Button>
+      </div>
       {#if dir === 'column'}
         <DocAttributeBar
           {object}

plugins/tracker-resources/src/components/issues/IssuesView.svelte

@@ -62,8 +62,10 @@
 
   async function update (viewlets: WithLookup<Viewlet>[], active: Ref<Viewlet> | null): Promise<void> {
     viewlet = viewlets.find((viewlet) => viewlet._id === active) ?? viewlets[0]
+    if (viewlet !== undefined) {
       setActiveViewletId(viewlet._id)
     }
+  }
 
   $: if (!label && title) {
     translate(title, {}).then((res) => {

plugins/view-resources/src/components/list/ListView.svelte

@@ -25,7 +25,7 @@
   const listProvider = new ListSelectionProvider((offset: 1 | -1 | 0, of?: Doc, dir?: SelectDirection) => {
     if (dir === 'vertical') {
       // Select next
-      list.select(offset, of)
+      list?.select(offset, of)
     }
   })