Description field fixes (#2263)

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>

dev/tool/package.json

@@ -40,8 +40,7 @@
     "@types/ws": "^8.2.1",
     "@types/xml2js": "~0.4.9",
     "@types/mime-types": "~2.1.1",
-    "@types/request": "~2.48.8",
-    "@types/email-addresses": "^3.0.0"
+    "@types/request": "~2.48.8"
   },
   "dependencies": {
     "mongodb": "^4.9.0",

models/lead/src/index.ts

@@ -68,7 +68,7 @@ export class TCustomer extends TContact implements Customer {
   @Prop(Collection(lead.class.Lead), lead.string.Leads)
   leads?: number
 
-  @Prop(TypeString(), core.string.Description)
+  @Prop(TypeMarkup(), core.string.Description)
   @Index(IndexKind.FullText)
   description!: string
 

models/view/src/index.ts

@@ -34,6 +34,7 @@ import type {
   FilterMode,
   HTMLPresenter,
   IgnoreActions,
+  InlineAttributEditor,
   KeyBinding,
   KeyFilter,
   LinkPresenter,
@@ -118,6 +119,11 @@ export class TCollectionEditor extends TClass implements CollectionEditor {
   inlineEditor?: AnyComponent
 }
 
+@Mixin(view.mixin.InlineAttributEditor, core.class.Class)
+export class TInlineAttributEditor extends TClass implements InlineAttributEditor {
+  editor!: AnyComponent
+}
+
 @Mixin(view.mixin.ArrayEditor, core.class.Class)
 export class TArrayEditor extends TClass implements ArrayEditor {
   inlineEditor?: AnyComponent
@@ -292,7 +298,8 @@ export function createModel (builder: Builder): void {
     TIgnoreActions,
     TPreviewPresenter,
     TLinkPresenter,
-    TArrayEditor
+    TArrayEditor,
+    TInlineAttributEditor
   )
 
   classPresenter(
@@ -311,6 +318,9 @@ export function createModel (builder: Builder): void {
     view.component.StringEditor,
     view.component.StringEditorPopup
   )
+  builder.mixin(core.class.TypeMarkup, core.class.Class, view.mixin.InlineAttributEditor, {
+    editor: view.component.HTMLEditor
+  })
   classPresenter(builder, core.class.TypeBoolean, view.component.BooleanPresenter, view.component.BooleanEditor)
   classPresenter(builder, core.class.TypeTimestamp, view.component.TimestampPresenter)
   classPresenter(builder, core.class.TypeDate, view.component.DatePresenter, view.component.DateEditor)

models/view/src/plugin.ts

@@ -57,7 +57,8 @@ export default mergeIds(viewId, view, {
     YoutubePresenter: '' as AnyComponent,
     GithubPresenter: '' as AnyComponent,
     ClassPresenter: '' as AnyComponent,
-    EnumEditor: '' as AnyComponent
+    EnumEditor: '' as AnyComponent,
+    HTMLEditor: '' as AnyComponent
   },
   string: {
     Table: '' as IntlString,

packages/presentation/src/components/SpaceSelector.svelte

@@ -28,14 +28,15 @@
   export let justify: 'left' | 'center' = 'center'
   export let width: string | undefined = undefined
   export let allowDeselect = false
+  export let focus = true
 
   export let create: ObjectCreate | undefined = undefined
 </script>
 
 <SpaceSelect
   {create}
-  focus
   focusIndex={-10}
+  {focus}
   {_class}
   spaceQuery={query}
   {allowDeselect}

packages/presentation/src/utils.ts

@@ -148,7 +148,9 @@ export async function getBlobURL (blob: Blob): Promise<string> {
   })
 }
 
-export type AttributeCategory = 'attribute' | 'collection' | 'array'
+export type AttributeCategory = 'attribute' | 'inplace' | 'collection' | 'array'
+
+export const AttributeCategoryOrder = { attribute: 0, inplace: 1, collection: 2, array: 2 }
 /**
  * @public
  */
@@ -162,6 +164,9 @@ export function getAttributePresenterClass (
     attrClass = (attribute.type as RefTo<Doc>).to
     category = 'attribute'
   }
+  if (hierarchy.isDerived(attrClass, core.class.TypeMarkup)) {
+    category = 'inplace'
+  }
   if (hierarchy.isDerived(attrClass, core.class.Collection)) {
     attrClass = (attribute.type as Collection<AttachedDoc>).of
     category = 'collection'

packages/text-editor/src/components/StyleButton.svelte

@@ -0,0 +1,88 @@
+<!--
+// Copyright © 2022 Hardcore Engineering Inc.
+// 
+// Licensed under the Eclipse Public License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License. You may
+// obtain a copy of the License at https://www.eclipse.org/legal/epl-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// 
+// See the License for the specific language governing permissions and
+// limitations under the License.
+-->
+<script lang="ts">
+  import type { Asset } from '@anticrm/platform'
+  import { AnySvelteComponent, Icon, LabelAndProps, tooltip } from '@anticrm/ui'
+  import { createEventDispatcher } from 'svelte'
+
+  export let icon: Asset | AnySvelteComponent
+  export let size: 'small' | 'medium' | 'large'
+  export let selected: boolean = false
+  export let showTooltip: LabelAndProps | undefined = undefined
+  export let disabled: boolean = false
+
+  const dispatch = createEventDispatcher()
+</script>
+
+<button
+  class="button {size}"
+  class:selected
+  {disabled}
+  use:tooltip={showTooltip}
+  tabindex="0"
+  on:mousedown|preventDefault|stopPropagation={() => {
+    dispatch('click')
+  }}
+>
+  <div class="icon {size}">
+    <Icon {icon} {size} />
+  </div>
+</button>
+
+<style lang="scss">
+  .button {
+    color: inherit;
+    border-radius: 0.125rem;
+    cursor: pointer;
+    padding: 0.75rem;
+
+    .icon {
+      color: var(--dark-color);
+    }
+    &:hover .icon {
+      color: var(--accent-color);
+      opacity: 1;
+    }
+    &:focus {
+      border: 1px solid var(--primary-button-focused-border);
+      box-shadow: 0 0 0 3px var(--primary-button-outline);
+      .icon {
+        color: var(--theme-caption-color);
+        opacity: 1;
+      }
+    }
+    &.selected {
+      background-color: var(--button-bg-hover);
+      border-color: var(--button-border-hover);
+      color: var(--caption-color);
+
+      .btn-icon {
+        color: var(--accent-color);
+      }
+    }
+  }
+  .small {
+    width: 1.143em;
+    height: 1.143em;
+  }
+  .medium {
+    width: 1.429em;
+    height: 1.429em;
+  }
+  .large {
+    width: 1.715em;
+    height: 1.715em;
+  }
+</style>

packages/text-editor/src/components/StyledTextEditor.svelte

@@ -17,12 +17,26 @@
 
   import { Scroller, showPopup } from '@anticrm/ui'
   import { createEventDispatcher } from 'svelte'
-  import Emoji from './icons/Emoji.svelte'
-  import GIF from './icons/GIF.svelte'
-  import TextStyle from './icons/TextStyle.svelte'
-  import EmojiPopup from './EmojiPopup.svelte'
-  import TextEditor from './TextEditor.svelte'
   import textEditorPlugin from '../plugin'
+  import EmojiPopup from './EmojiPopup.svelte'
+  import Emoji from './icons/Emoji.svelte'
+  import TextStyle from './icons/TextStyle.svelte'
+  import TextEditor from './TextEditor.svelte'
+
+  import { Asset } from '@anticrm/platform'
+  import { AnySvelteComponent } from '@anticrm/ui'
+  import { FormatMode, FORMAT_MODES, RefInputAction, TextEditorHandler } from '../types'
+  import Bold from './icons/Bold.svelte'
+  import Code from './icons/Code.svelte'
+  import CodeBlock from './icons/CodeBlock.svelte'
+  import Italic from './icons/Italic.svelte'
+  import Link from './icons/Link.svelte'
+  import ListBullet from './icons/ListBullet.svelte'
+  import ListNumber from './icons/ListNumber.svelte'
+  import Quote from './icons/Quote.svelte'
+  import Strikethrough from './icons/Strikethrough.svelte'
+  import LinkPopup from './LinkPopup.svelte'
+  import StyleButton from './StyleButton.svelte'
 
   const dispatch = createEventDispatcher()
 
@@ -32,6 +46,7 @@
   export let isScrollable: boolean = true
   export let focusable: boolean = false
   export let maxHeight: 'max' | 'card' | string = 'max'
+  export let withoutTopBorder = false
 
   let textEditor: TextEditor
 
@@ -42,16 +57,160 @@
     textEditor.focus()
   }
 
-  function openEmojiPopup (ev: MouseEvent & { currentTarget: EventTarget & HTMLDivElement }) {
-    showPopup(EmojiPopup, {}, ev.target as HTMLElement, (emoji) => {
-      if (!emoji) return
-      textEditor.insertText(emoji)
+  $: varsStyle = maxHeight === 'card' ? 'calc(70vh - 12.5rem)' : maxHeight === 'max' ? 'max-content' : maxHeight
+
+  let isFormatting = false
+  let activeModes = new Set<FormatMode>()
+  let isSelectionEmpty = true
+
+  interface RefAction {
+    label: IntlString
+    icon: Asset | AnySvelteComponent
+    action: RefInputAction
+    order: number
+  }
+  const defActions: RefAction[] = [
+    {
+      label: textEditorPlugin.string.TextStyle,
+      icon: TextStyle,
+      action: () => {
+        isFormatting = !isFormatting
+        textEditor.focus()
+      },
+      order: 2000
+    },
+    {
+      label: textEditorPlugin.string.Emoji,
+      icon: Emoji,
+      action: (element) => {
+        showPopup(
+          EmojiPopup,
+          {},
+          element,
+          (emoji) => {
+            if (!emoji) return
+            textEditor.insertText(emoji)
+            textEditor.focus()
+          },
+          () => {}
+        )
+      },
+      order: 3000
+    }
+    // {
+    //   label: textEditorPlugin.string.GIF,
+    //   icon: GIF,
+    //   action: () => {},
+    //   order: 4000
+    // }
+  ]
+
+  function updateFormattingState () {
+    activeModes = new Set(FORMAT_MODES.filter(textEditor.checkIsActive))
+    isSelectionEmpty = textEditor.checkIsSelectionEmpty()
+  }
+
+  function getToggler (toggle: () => void) {
+    return () => {
+      toggle()
+      textEditor.focus()
+      updateFormattingState()
+    }
+  }
+
+  async function formatLink (): Promise<void> {
+    const link = textEditor.getLink()
+
+    showPopup(LinkPopup, { link }, undefined, undefined, (newLink) => {
+      if (newLink === '') {
+        textEditor.unsetLink()
+      } else {
+        textEditor.setLink(newLink)
+      }
     })
   }
-  $: varsStyle = maxHeight === 'card' ? 'calc(70vh - 12.5rem)' : maxHeight === 'max' ? 'max-content' : maxHeight
+  const editorHandler: TextEditorHandler = {
+    insertText: (text) => {
+      textEditor.insertText(text)
+    }
+  }
+  function handleAction (a: RefAction, evt?: Event): void {
+    a.action(evt?.target as HTMLElement, editorHandler)
+  }
 </script>
 
 <div class="ref-container">
+  {#if isFormatting}
+    <div class="formatPanel buttons-group xsmall-gap mb-4" class:withoutTopBorder>
+      <StyleButton
+        icon={Bold}
+        size={'small'}
+        selected={activeModes.has('bold')}
+        showTooltip={{ label: textEditorPlugin.string.Bold }}
+        on:click={getToggler(textEditor.toggleBold)}
+      />
+      <StyleButton
+        icon={Italic}
+        size={'small'}
+        selected={activeModes.has('italic')}
+        showTooltip={{ label: textEditorPlugin.string.Italic }}
+        on:click={getToggler(textEditor.toggleItalic)}
+      />
+      <StyleButton
+        icon={Strikethrough}
+        size={'small'}
+        selected={activeModes.has('strike')}
+        showTooltip={{ label: textEditorPlugin.string.Strikethrough }}
+        on:click={getToggler(textEditor.toggleStrike)}
+      />
+      <StyleButton
+        icon={Link}
+        size={'small'}
+        selected={activeModes.has('link')}
+        disabled={isSelectionEmpty && !activeModes.has('link')}
+        showTooltip={{ label: textEditorPlugin.string.Link }}
+        on:click={formatLink}
+      />
+      <div class="buttons-divider" />
+      <StyleButton
+        icon={ListNumber}
+        size={'small'}
+        selected={activeModes.has('orderedList')}
+        showTooltip={{ label: textEditorPlugin.string.OrderedList }}
+        on:click={getToggler(textEditor.toggleOrderedList)}
+      />
+      <StyleButton
+        icon={ListBullet}
+        size={'small'}
+        selected={activeModes.has('bulletList')}
+        showTooltip={{ label: textEditorPlugin.string.BulletedList }}
+        on:click={getToggler(textEditor.toggleBulletList)}
+      />
+      <div class="buttons-divider" />
+      <StyleButton
+        icon={Quote}
+        size={'small'}
+        selected={activeModes.has('blockquote')}
+        showTooltip={{ label: textEditorPlugin.string.Blockquote }}
+        on:click={getToggler(textEditor.toggleBlockquote)}
+      />
+      <div class="buttons-divider" />
+      <StyleButton
+        icon={Code}
+        size={'small'}
+        selected={activeModes.has('code')}
+        showTooltip={{ label: textEditorPlugin.string.Code }}
+        on:click={getToggler(textEditor.toggleCode)}
+      />
+      <StyleButton
+        icon={CodeBlock}
+        size={'small'}
+        selected={activeModes.has('codeBlock')}
+        showTooltip={{ label: textEditorPlugin.string.CodeBlock }}
+        on:click={getToggler(textEditor.toggleCodeBlock)}
+      />
+    </div>
+  {/if}
   <div class="textInput" class:focusable>
     <div class="inputMsg" class:scrollable={isScrollable} style="--texteditor-maxheight: {varsStyle};">
       {#if isScrollable}
@@ -69,6 +228,7 @@
             on:blur
             on:focus
             supportSubmit={false}
+            on:selection-update={updateFormattingState}
           />
         </Scroller>
       {:else}
@@ -85,15 +245,18 @@
           on:blur
           on:focus
           supportSubmit={false}
+          on:selection-update={updateFormattingState}
         />
       {/if}
     </div>
   </div>
   {#if showButtons}
     <div class="buttons">
-      <div class="tool"><TextStyle size={'large'} /></div>
-      <div class="tool" on:click={openEmojiPopup}><Emoji size={'large'} /></div>
-      <div class="tool"><GIF size={'large'} /></div>
+      {#each defActions as a}
+        <div class="p-1">
+          <StyleButton icon={a.icon} size={'large'} on:click={(evt) => handleAction(a, evt)} />
+        </div>
+      {/each}
       <div class="flex-grow">
         <slot />
       </div>
@@ -146,25 +309,8 @@
       }
     }
     .buttons {
-      margin: 10px 0 0 8px;
       display: flex;
       align-items: center;
-
-      .tool {
-        display: flex;
-        justify-content: center;
-        align-items: center;
-        width: 20px;
-        height: 20px;
-        opacity: 0.3;
-        cursor: pointer;
-        &:hover {
-          opacity: 1;
-        }
-      }
-      .tool + .tool {
-        margin-left: 16px;
-      }
     }
   }
 </style>

packages/text-editor/src/components/TextEditor.svelte

@@ -96,12 +96,16 @@
     editor.commands.toggleCodeBlock()
   }
   let needFocus = false
+
+  let focused = false
   export function focus (): void {
     needFocus = true
   }
 
   $: if (editor && needFocus) {
-    editor.commands.focus()
+    if (!focused) {
+      editor.commands.focus()
+    }
     needFocus = false
   }
 
@@ -159,10 +163,12 @@
           // force re-render so `editor.isActive` works as expected
           editor = editor
         },
-        onBlur: () => {
-          dispatch('blur', editor.getHTML())
+        onBlur: ({ event }) => {
+          focused = false
+          dispatch('blur', event)
         },
         onFocus: () => {
+          focused = true
           dispatch('focus', editor.getHTML())
         },
         onUpdate: () => {

plugins/hr-resources/src/components/DepartmentEditor.svelte

@@ -37,6 +37,7 @@
   {justify}
   allowDeselect
   {width}
+  focus={false}
   bind:space={value}
   on:change={(e) => onChange(e.detail)}
 />

plugins/view-resources/package.json

@@ -43,6 +43,7 @@
     "@anticrm/notification": "~0.6.0",
     "@anticrm/presentation": "~0.6.2",
     "@anticrm/setting": "~0.6.1",
-    "fast-equals": "^2.0.3"
+    "fast-equals": "^2.0.3",
+    "@anticrm/text-editor": "~0.6.0"
   }
 }

plugins/view-resources/src/components/EditDoc.svelte

@@ -20,6 +20,8 @@
   import { Panel } from '@anticrm/panel'
   import { Asset, getResource, translate } from '@anticrm/platform'
   import {
+    AttributeCategory,
+    AttributeCategoryOrder,
     AttributesBar,
     createQuery,
     getAttributePresenterClass,
@@ -29,7 +31,7 @@
   import { AnyComponent, Button, Component } from '@anticrm/ui'
   import view from '@anticrm/view'
   import { createEventDispatcher, onDestroy } from 'svelte'
-  import { collectionsFilter, getCollectionCounter, getFiltredKeys } from '../utils'
+  import { fieldsFilter, getCollectionCounter, getFiltredKeys } from '../utils'
   import ActionContext from './ActionContext.svelte'
   import DocAttributeBar from './DocAttributeBar.svelte'
   import UpDownNavigator from './UpDownNavigator.svelte'
@@ -73,7 +75,7 @@
   }
 
   let keys: KeyedAttribute[] = []
-  let collectionEditors: { key: KeyedAttribute; editor: AnyComponent }[] = []
+  let fieldEditors: { key: KeyedAttribute; editor: AnyComponent; category: AttributeCategory }[] = []
 
   let mixins: Mixin<Doc>[] = []
 
@@ -97,9 +99,10 @@
   let ignoreKeys: string[] = []
   let allowedCollections: string[] = []
   let collectionArrays: string[] = []
+  let inplaceAttributes: string[] = []
   let ignoreMixins: Set<Ref<Mixin<Doc>>> = new Set<Ref<Mixin<Doc>>>()
 
-  async function updateKeys (): Promise<void> {
+  async function updateKeys (showAllMixins: boolean): Promise<void> {
     const keysMap = new Map(getFiltredKeys(hierarchy, realObjectClass, ignoreKeys).map((p) => [p.attr._id, p]))
     for (const m of mixins) {
       const mkeys = getFiltredKeys(hierarchy, m._id, ignoreKeys)
@@ -108,17 +111,22 @@
       }
     }
     const filtredKeys = Array.from(keysMap.values())
-    keys = collectionsFilter(hierarchy, filtredKeys, false, allowedCollections)
+    keys = fieldsFilter(hierarchy, filtredKeys, false, allowedCollections).map((it) => it.key)
 
-    const collectionKeys = collectionsFilter(hierarchy, filtredKeys, true, collectionArrays)
-    const editors: { key: KeyedAttribute; editor: AnyComponent }[] = []
-    for (const k of collectionKeys) {
-      if (allowedCollections.includes(k.key)) continue
-      const editor = await getCollectionEditor(k)
+    const fieldKeys = fieldsFilter(hierarchy, filtredKeys, true, collectionArrays)
+    const editors: { key: KeyedAttribute; editor: AnyComponent; category: AttributeCategory }[] = []
+    const newInplaceAttributes = []
+    for (const k of fieldKeys) {
+      if (allowedCollections.includes(k.key.key)) continue
+      const editor = await getFieldEditor(k.key)
       if (editor === undefined) continue
-      editors.push({ key: k, editor })
+      if (k.category === 'inplace') {
+        newInplaceAttributes.push(k.key.key)
+      }
+      editors.push({ key: k.key, editor, category: k.category })
     }
-    collectionEditors = editors
+    inplaceAttributes = newInplaceAttributes
+    fieldEditors = editors.sort((a, b) => AttributeCategoryOrder[a.category] - AttributeCategoryOrder[b.category])
   }
 
   async function getEditor (_class: Ref<Class<Doc>>): Promise<AnyComponent> {
@@ -129,18 +137,24 @@
   }
 
   let mainEditor: AnyComponent | undefined
-  $: getEditorOrDefault(realObjectClass)
+  $: getEditorOrDefault(realObjectClass, showAllMixins)
 
-  async function getEditorOrDefault (_class: Ref<Class<Doc>>): Promise<void> {
+  async function getEditorOrDefault (_class: Ref<Class<Doc>>, showAllMixins: boolean): Promise<void> {
     parentClass = getParentClass(_class)
     mainEditor = await getEditor(_class)
-    updateKeys()
+    updateKeys(showAllMixins)
   }
 
-  async function getCollectionEditor (key: KeyedAttribute): Promise<AnyComponent | undefined> {
+  async function getFieldEditor (key: KeyedAttribute): Promise<AnyComponent | undefined> {
     const attrClass = getAttributePresenterClass(hierarchy, key.attr)
     const clazz = hierarchy.getClass(attrClass.attrClass)
-    const mixinRef = attrClass.category === 'array' ? view.mixin.ArrayEditor : view.mixin.CollectionEditor
+    const mix = {
+      array: view.mixin.ArrayEditor,
+      collection: view.mixin.CollectionEditor,
+      inplace: view.mixin.InlineAttributEditor,
+      attribute: view.mixin.AttributeEditor
+    }
+    const mixinRef = mix[attrClass.category]
     const editorMixin = hierarchy.as(clazz, mixinRef)
     return editorMixin.editor
   }
@@ -273,15 +287,15 @@
           <Component
             is={headerEditor}
             props={{ object, keys, mixins, ignoreKeys, vertical: dir === 'column', allowedCollections }}
-            on:update={updateKeys}
+            on:update={() => updateKeys(showAllMixins)}
           />
         {:else if dir === 'column'}
           <DocAttributeBar
             {object}
             {mixins}
-            ignoreKeys={[...ignoreKeys, ...collectionArrays]}
+            ignoreKeys={[...ignoreKeys, ...collectionArrays, ...inplaceAttributes]}
             {allowedCollections}
-            on:update={updateKeys}
+            on:update={() => updateKeys(showAllMixins)}
           />
         {:else}
           <AttributesBar {object} _class={realObjectClass} {keys} />
@@ -303,7 +317,7 @@
         }}
       />
     {/if}
-    {#each collectionEditors as collection}
+    {#each fieldEditors as collection}
       {#if collection.editor}
         <div class="mt-6">
           <Component

plugins/view-resources/src/components/HTMLEditor.svelte

@@ -0,0 +1,41 @@
+<!--
+// Copyright © 2020, 2021 Anticrm Platform Contributors.
+// Copyright © 2021 Hardcore Engineering Inc.
+// 
+// Licensed under the Eclipse Public License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License. You may
+// obtain a copy of the License at https://www.eclipse.org/legal/epl-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// 
+// See the License for the specific language governing permissions and
+// limitations under the License.
+-->
+<script lang="ts">
+  import { Doc } from '@anticrm/core'
+
+  import { getAttribute, getClient, KeyedAttribute, updateAttribute } from '@anticrm/presentation'
+  import { FullDescriptionBox } from '@anticrm/text-editor'
+
+  // export let objectId: Ref<Doc>
+  // export let _class: Ref<Class<Doc>>
+  export let object: Doc
+  // export let space: Ref<Space>
+  export let key: KeyedAttribute
+
+  $: description = getAttribute(getClient(), object, key)
+</script>
+
+{#key description}
+  <FullDescriptionBox
+    label={key.attr.label}
+    content={description}
+    on:save={(res) => {
+      if (res.detail != null) {
+        updateAttribute(getClient(), object, object._class, key, res.detail)
+      }
+    }}
+  />
+{/key}

plugins/view-resources/src/index.ts

@@ -52,6 +52,7 @@ import TimestampPresenter from './components/TimestampPresenter.svelte'
 import UpDownNavigator from './components/UpDownNavigator.svelte'
 import ViewletSettingButton from './components/ViewletSettingButton.svelte'
 import ValueSelector from './components/ValueSelector.svelte'
+import HTMLEditor from './components/HTMLEditor.svelte'
 import {
   afterResult,
   beforeResult,
@@ -139,7 +140,8 @@ export default async (): Promise<Resources> => ({
     BooleanTruePresenter,
     EnumEditor,
     FilterTypePopup,
-    ValueSelector
+    ValueSelector,
+    HTMLEditor
   },
   popup: {
     PositionElementAlignment

plugins/view-resources/src/utils.ts

@@ -29,7 +29,7 @@ import core, {
 } from '@anticrm/core'
 import type { IntlString } from '@anticrm/platform'
 import { getResource } from '@anticrm/platform'
-import { getAttributePresenterClass, KeyedAttribute } from '@anticrm/presentation'
+import { AttributeCategory, getAttributePresenterClass, KeyedAttribute } from '@anticrm/presentation'
 import { AnyComponent, ErrorPresenter, getCurrentLocation, getPlatformColorForText, locationToUrl } from '@anticrm/ui'
 import type { BuildModelOptions, Viewlet } from '@anticrm/view'
 import view, { AttributeModel, BuildModelKey } from '@anticrm/view'
@@ -406,18 +406,20 @@ export function getFiltredKeys (
   return filterKeys(hierarchy, keys, ignoreKeys)
 }
 
-export function collectionsFilter (
+export function fieldsFilter (
   hierarchy: Hierarchy,
   keys: KeyedAttribute[],
   get: boolean,
   include: string[]
-): KeyedAttribute[] {
-  const result: KeyedAttribute[] = []
+): Array<{ key: KeyedAttribute, category: AttributeCategory }> {
+  const result: Array<{ key: KeyedAttribute, category: AttributeCategory }> = []
+
   for (const key of keys) {
+    const cl = getAttributePresenterClass(hierarchy, key.attr)
     if (include.includes(key.key)) {
-      result.push(key)
-    } else if (isCollectionAttr(hierarchy, key) === get) {
-      result.push(key)
+      result.push({ key: key, category: cl.category })
+    } else if ((cl.category === 'collection') === get || (cl.category === 'inplace') === get) {
+      result.push({ key, category: cl.category })
     }
   }
   return result

plugins/view/src/index.ts

@@ -98,6 +98,13 @@ export interface CollectionEditor extends Class<Doc> {
   inlineEditor?: AnyComponent
 }
 
+/**
+ * @public
+ */
+export interface InlineAttributEditor extends Class<Doc> {
+  editor: AnyComponent
+}
+
 /**
  * @public
  */
@@ -400,6 +407,7 @@ const view = plugin(viewId, {
     AttributeEditor: '' as Ref<Mixin<AttributeEditor>>,
     CollectionPresenter: '' as Ref<Mixin<CollectionPresenter>>,
     CollectionEditor: '' as Ref<Mixin<CollectionEditor>>,
+    InlineAttributEditor: '' as Ref<Mixin<InlineAttributEditor>>,
     ArrayEditor: '' as Ref<Mixin<ArrayEditor>>,
     AttributePresenter: '' as Ref<Mixin<AttributePresenter>>,
     ObjectEditor: '' as Ref<Mixin<ObjectEditor>>,