indent snippets to line indent instead of completion start (#6263)

This commit is contained in:
Pascal Kuthe 2023-03-11 03:34:43 +01:00 committed by GitHub
parent bdcd4d9411
commit 171d28d2bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 10 deletions

View File

@ -345,6 +345,7 @@ pub mod util {
line_ending: &str, line_ending: &str,
include_placeholder: bool, include_placeholder: bool,
tab_width: usize, tab_width: usize,
indent_width: usize,
) -> Transaction { ) -> Transaction {
let text = doc.slice(..); let text = doc.slice(..);
@ -374,19 +375,14 @@ pub mod util {
let mapped_replacement_end = (replacement_end as i128 + off) as usize; let mapped_replacement_end = (replacement_end as i128 + off) as usize;
let line_idx = mapped_doc.char_to_line(mapped_replacement_start); let line_idx = mapped_doc.char_to_line(mapped_replacement_start);
let pos_on_line = mapped_replacement_start - mapped_doc.line_to_char(line_idx); let indent_level = helix_core::indent::indent_level_for_line(
// we only care about the actual offset here (not virtual text/softwrap)
// so it's ok to use the deprecated function here
#[allow(deprecated)]
let width = helix_core::visual_coords_at_pos(
mapped_doc.line(line_idx), mapped_doc.line(line_idx),
pos_on_line,
tab_width, tab_width,
) indent_width,
.col; ) * indent_width;
let newline_with_offset = format!( let newline_with_offset = format!(
"{line_ending}{blank:width$}", "{line_ending}{blank:indent_level$}",
line_ending = line_ending, line_ending = line_ending,
blank = "" blank = ""
); );

View File

@ -182,6 +182,7 @@ impl Completion {
doc.line_ending.as_str(), doc.line_ending.as_str(),
include_placeholder, include_placeholder,
doc.tab_width(), doc.tab_width(),
doc.indent_width(),
), ),
Err(err) => { Err(err) => {
log::error!( log::error!(