09a7db6 · helix · git.iko.soy

on master help sign in

Avoid theoretical underflow.

09a7db6Jakub Bartodziej5 years ago

helix-term/src/commands.rs+2−3

@@ -759,9 +759,8 @@ fn _delete_selection(doc: &mut Document, view_id: ViewId) {

759 // then delete

760 let transaction =

761 Transaction::change_by_selection(doc.text(), doc.selection(view_id), |range| {

762− use std::cmp::{max, min};

763− let max_to = max(0, doc.text().len_chars() - 1);

762+ let max_to = doc.text().len_chars().saturating_sub(1);

764− let to = min(max_to, range.to() + 1);

763+ let to = std::cmp::min(max_to, range.to() + 1);

765 (range.from(), to, None)

764 (range.from(), to, None)

766 });

765 });

767 doc.apply(&transaction, view_id);

766 doc.apply(&transaction, view_id);