1befbd0 · helix · git.iko.soy

git.iko.soy/helix

Add command for editing breakpoint condition

commit1befbd076c0d182d7b6d9a6198054551d5ba34da authorDmitry Sharshakov <d3dx12.xx@gmail.com> dateSat 4 Sep 2021, 22:57 (5 years ago) parente36fc57

7 files changed+88−11

compare with master

unifiedsplit

helix-term/src/commands.rs+10−9 helix-term/src/commands/dap.rs+72−1 helix-term/src/keymap.rs+1 helix-term/src/ui/editor.rs+1 helix-term/src/ui/mod.rs+1 helix-term/src/ui/picker.rs+1 helix-term/src/ui/prompt.rs+2−1

helix-term/src/commands.rs+10−9

@@ -317,6 +317,7 @@ impl Command {

317317 dap_next, "Step to next",

318318 dap_variables, "List variables",

319319 dap_terminate, "End debug session",

320+ dap_edit_condition, "Edit condition of the breakpoint on the current line",

320321 dap_switch_thread, "Switch current thread",

321322 dap_switch_stack_frame, "Switch stack frame",

322323 shell_pipe, "Pipe selections through shell command",

@@ -1979,10 +1980,10 @@ mod cmd {

19791980 Ok(())

19801981 }

19811982

1982− fn get_breakpoint_at_current_line(

1983− cx: &mut compositor::Context,

1983+ pub fn get_breakpoint_at_current_line(

1984+ editor: &mut Editor,

19841985 ) -> Option<(usize, SourceBreakpoint)> {

1985− let (view, doc) = current!(cx.editor);

1986+ let (view, doc) = current!(editor);

19861987 let text = doc.text().slice(..);

19871988

19881989 let pos = doc.selection(view.id).primary().cursor(text);

@@ -1992,12 +1993,9 @@ mod cmd {

19921993 None => return None,

19931994 };

19941995 let vec = vec![];

1995− let breakpoints = cx.editor.breakpoints.get(&path.clone()).unwrap_or(&vec);

1996+ let breakpoints = editor.breakpoints.get(&path).unwrap_or(&vec);

19961997 let i = breakpoints.iter().position(|b| b.line == line);

1997− match i {

1998− Some(i) => Some((i, breakpoints.get(i).unwrap().clone())),

1999− None => None,

2000− }

1998+ i.map(|i| (i, breakpoints.get(i).unwrap().clone()))

20011999 }

20022000

20032001 fn edit_breakpoint_impl(

@@ -2015,7 +2013,7 @@ mod cmd {

20152013 }

20162014 };

20172015

2018− if let Some((pos, mut bp)) = get_breakpoint_at_current_line(cx) {

2016+ if let Some((pos, mut bp)) = get_breakpoint_at_current_line(cx.editor) {

20192017 let breakpoints = cx.editor.breakpoints.entry(path.clone()).or_default();

20202018 breakpoints.remove(pos);

20212019

@@ -2481,6 +2479,7 @@ fn command_mode(cx: &mut Context) {

24812479 .set_error(format!("no such command: '{}'", parts[0]));

24822480 };

24832481 },

2482+ None,

24842483 );

24852484 prompt.doc_fn = Box::new(|input: &str| {

24862485 let part = input.split(' ').next().unwrap_or_default();

@@ -4584,6 +4583,7 @@ fn shell_keep_pipe(cx: &mut Context) {

45844583 let index = index.unwrap_or_else(|| ranges.len() - 1);

45854584 doc.set_selection(view.id, Selection::new(ranges, index));

45864585 },

4586+ None,

45874587 );

45884588

45894589 cx.push_layer(Box::new(prompt));

@@ -4683,6 +4683,7 @@ fn shell(cx: &mut Context, prompt: Cow<'static, str>, behavior: ShellBehavior) {

46834683 doc.append_changes_to_history(view.id);

46844684 }

46854685 },

4686+ None,

46864687 );

46874688

46884689 cx.push_layer(Box::new(prompt));

helix-term/src/commands/dap.rs+72−1

@@ -1,5 +1,8 @@

11use super::{align_view, Align, Context, Editor};

2−use crate::ui::{FilePicker, Picker};

2+use crate::{

3+ commands,

4+ ui::{FilePicker, Picker, Prompt, PromptEvent},

5+};

36use helix_core::Selection;

47use helix_dap::{self as dap, Client};

58use helix_lsp::block_on;

@@ -474,6 +477,74 @@ pub fn dap_terminate(cx: &mut Context) {

474477 cx.editor.debugger = None;

475478}

476479

480+pub fn dap_edit_condition(cx: &mut Context) {

481+ if let Some((pos, mut bp)) = commands::cmd::get_breakpoint_at_current_line(cx.editor) {

482+ let condition = bp.condition.clone();

483+ let prompt = Prompt::new(

484+ "condition: ".into(),

485+ None,

486+ |_input: &str| Vec::new(),

487+ move |cx: &mut crate::compositor::Context, input: &str, event: PromptEvent| {

488+ if event != PromptEvent::Validate {

489+ return;

490+ }

491+

492+ let (_, doc) = current!(cx.editor);

493+ let path = match doc.path() {

494+ Some(path) => path.to_path_buf(),

495+ None => {

496+ cx.editor

497+ .set_status("Can't edit breakpoint: document has no path".to_owned());

498+ return;

499+ }

500+ };

501+

502+ let breakpoints = cx.editor.breakpoints.entry(path.clone()).or_default();

503+ breakpoints.remove(pos);

504+ bp.condition = match input {

505+ "" => None,

506+ input => Some(input.to_owned()),

507+ };

508+ breakpoints.push(bp.clone());

509+

510+ if let Some(debugger) = &mut cx.editor.debugger {

511+ // TODO: handle capabilities correctly again, by filterin breakpoints when emitting

512+ // if breakpoint.condition.is_some()

513+ // && !debugger

514+ // .caps

515+ // .as_ref()

516+ // .unwrap()

517+ // .supports_conditional_breakpoints

518+ // .unwrap_or_default()

519+ // {

520+ // bail!(

521+ // "Can't edit breakpoint: debugger does not support conditional breakpoints"

522+ // )

523+ // }

524+ // if breakpoint.log_message.is_some()

525+ // && !debugger

526+ // .caps

527+ // .as_ref()

528+ // .unwrap()

529+ // .supports_log_points

530+ // .unwrap_or_default()

531+ // {

532+ // bail!("Can't edit breakpoint: debugger does not support logpoints")

533+ // }

534+ let request = debugger.set_breakpoints(path, breakpoints.clone());

535+ if let Err(e) = block_on(request) {

536+ cx.editor

537+ .set_status(format!("Failed to set breakpoints: {:?}", e))

538+ }

539+ }

540+ },

541+ condition,

542+ );

543+

544+ cx.push_layer(Box::new(prompt));

545+ }

546+}

547+

477548pub fn dap_switch_thread(cx: &mut Context) {

478549 thread_picker(cx, |editor, thread| {

479550 block_on(select_thread_id(editor, thread.id, true));

helix-term/src/keymap.rs+1

@@ -497,6 +497,7 @@ impl Default for Keymaps {

497497 "n" => dap_next,

498498 "v" => dap_variables,

499499 "t" => dap_terminate,

500+ "C-c" => dap_edit_condition,

500501 "s" => { "Switch"

501502 "t" => dap_switch_thread,

502503 "f" => dap_switch_stack_frame,

helix-term/src/ui/editor.rs+1

@@ -795,6 +795,7 @@ impl EditorView {

795795 );

796796 }

797797 },

798+ None,

798799 )

799800 }

800801

helix-term/src/ui/mod.rs+1

@@ -70,6 +70,7 @@ pub fn regex_prompt(

7070 }

7171 }

7272 },

73+ None,

7374 )

7475}

7576

helix-term/src/ui/picker.rs+1

@@ -208,6 +208,7 @@ impl<T> Picker<T> {

208208 |_editor: &mut Context, _pattern: &str, _event: PromptEvent| {

209209 //

210210 },

211+ None,

211212 );

212213

213214 let mut picker = Self {

helix-term/src/ui/prompt.rs+2−1

@@ -59,10 +59,11 @@ impl Prompt {

5959 history_register: Option<char>,

6060 mut completion_fn: impl FnMut(&str) -> Vec<Completion> + 'static,

6161 callback_fn: impl FnMut(&mut Context, &str, PromptEvent) + 'static,

62+ line: Option<String>,

6263 ) -> Self {

6364 Self {

6465 prompt,

65− line: String::new(),

66+ line: line.unwrap_or_default(),

6667 cursor: 0,

6768 completion: completion_fn(""),

6869 selection: None,