git.iko.soy/helix
on master help sign in
Use deserialization fix instead
3b0c5e9Nehliin
helix-term/src/keymap.rs+17−18
compare with master
unifiedsplit
@@ -78,19 +78,30 @@ macro_rules! keymap {
78 };
78 };
79}
79}
80
80
81−#[derive(Debug, Clone, Deserialize)]
81+#[derive(Debug, Clone)]
82pub struct KeyTrieNode {
82pub struct KeyTrieNode {
83 /// A label for keys coming under this node, like "Goto mode"
83 /// A label for keys coming under this node, like "Goto mode"
84− #[serde(skip)]
85 name: String,
84 name: String,
86− #[serde(flatten)]
87 map: HashMap<KeyEvent, KeyTrie>,
85 map: HashMap<KeyEvent, KeyTrie>,
88− #[serde(skip)]
89 order: Vec<KeyEvent>,
86 order: Vec<KeyEvent>,
90− #[serde(skip)]
91 pub is_sticky: bool,
87 pub is_sticky: bool,
92}
88}
93
89
90+impl<'de> Deserialize<'de> for KeyTrieNode {
91+ fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
92+ where
93+ D: serde::Deserializer<'de>,
94+ {
95+ let map = HashMap::<KeyEvent, KeyTrie>::deserialize(deserializer)?;
96+ let order = map.keys().copied().collect::<Vec<_>>(); // NOTE: map.keys() has arbitrary order
97+ Ok(Self {
98+ map,
99+ order,
100+ ..Default::default()
101+ })
102+ }
103+}
104+
94impl KeyTrieNode {
105impl KeyTrieNode {
95 pub fn new(name: &str, map: HashMap<KeyEvent, KeyTrie>, order: Vec<KeyEvent>) -> Self {
106 pub fn new(name: &str, map: HashMap<KeyEvent, KeyTrie>, order: Vec<KeyEvent>) -> Self {
96 Self {
107 Self {
@@ -118,22 +129,10 @@ impl KeyTrieNode {
118 }
129 }
119 self.map.insert(key, trie);
130 self.map.insert(key, trie);
120 }
131 }
121− self.set_order();
122− }
123−
124− /// Sets the order of the mapping recursively since the
125− /// the trie can contain child nodes without order.
126− /// The order is missing from child nodes since it's not
127− /// parsed from the config.toml
128− fn set_order(&mut self) {
129− for (&key, trie) in self.map.iter_mut() {
132+ for &key in self.map.keys() {
130 if !self.order.contains(&key) {
133 if !self.order.contains(&key) {
131 self.order.push(key);
134 self.order.push(key);
132 }
135 }
133− // Order must be recursively set
134− if let KeyTrie::Node(node) = trie {
135− node.set_order();
136− }
137 }
136 }
138 }
137 }
139
138