on master help sign in
ui: buffer picker on ctrl-b
commit3d3295bb759994d4fbf328c126678f63e0c38d4f authorBlaž Hrastnik <blaz@mxxn.io> dateMon 21 Dec 2020, 16:23 (6 years ago) parentea502c8
6 files changed+91−47
helix-term/src/commands.rs+50−35 helix-term/src/compositor.rs+2−2 helix-term/src/keymap.rs+1 helix-term/src/ui/mod.rs+26−2 helix-term/src/ui/picker.rs+6−4 helix-term/src/ui/prompt.rs+6−4
helix-term/src/commands.rs+50−35
@@ -297,9 +297,11 @@ pub fn split_selection(cx: &mut Context) {
297297 },
298298 );
299299
300− cx.callback = Some(Box::new(move |compositor: &mut Compositor| {
301− compositor.push(Box::new(prompt));
302− }));
300+ cx.callback = Some(Box::new(
301+ move |compositor: &mut Compositor, editor: &mut Editor| {
302+ compositor.push(Box::new(prompt));
303+ },
304+ ));
303305}
304306
305307pub fn split_selection_on_newline(cx: &mut Context) {
@@ -399,12 +401,13 @@ pub fn append_mode(cx: &mut Context) {
399401
400402// TODO: I, A, o and O can share a lot of the primitives.
401403pub fn command_mode(cx: &mut Context) {
402− cx.callback = Some(Box::new(|compositor: &mut Compositor| {
403− let prompt = Prompt::new(
404− ":".to_owned(),
405− |_input: &str| {
406− // TODO: i need this duplicate list right now to avoid borrow checker issues
407− let command_list = vec![
404+ cx.callback = Some(Box::new(
405+ |compositor: &mut Compositor, editor: &mut Editor| {
406+ let prompt = Prompt::new(
407+ ":".to_owned(),
408+ |_input: &str| {
409+ // TODO: i need this duplicate list right now to avoid borrow checker issues
410+ let command_list = vec![
408411 String::from("q"),
409412 String::from("aaa"),
410413 String::from("bbb"),
@@ -437,37 +440,49 @@ pub fn command_mode(cx: &mut Context) {
437440 String::from("ddd"),
438441 String::from("eee"),
439442 ];
440− command_list
441− .into_iter()
442− .filter(|command| command.contains(_input))
443− .collect()
444− }, // completion
445− |editor: &mut Editor, input: &str, event: PromptEvent| {
446− if event != PromptEvent::Validate {
447− return;
448− }
443+ command_list
444+ .into_iter()
445+ .filter(|command| command.contains(_input))
446+ .collect()
447+ }, // completion
448+ |editor: &mut Editor, input: &str, event: PromptEvent| {
449+ if event != PromptEvent::Validate {
450+ return;
451+ }
449452
450− let parts = input.split_ascii_whitespace().collect::<Vec<&str>>();
453+ let parts = input.split_ascii_whitespace().collect::<Vec<&str>>();
451454
452− match parts.as_slice() {
453− &["q"] => editor.should_close = true,
454− &["o", path] => {
455− // TODO: make view()/view_mut() always contain a view.
456− let size = editor.view().unwrap().size;
457− editor.open(path.into(), size);
455+ match parts.as_slice() {
456+ &["q"] => editor.should_close = true,
457+ &["o", path] => {
458+ // TODO: make view()/view_mut() always contain a view.
459+ let size = editor.view().unwrap().size;
460+ editor.open(path.into(), size);
461+ }
462+ _ => (),
458463 }
459− _ => (),
460− }
461− },
462− );
463− compositor.push(Box::new(prompt));
464− }));
464+ },
465+ );
466+ compositor.push(Box::new(prompt));
467+ },
468+ ));
465469}
466470pub fn file_picker(cx: &mut Context) {
467− cx.callback = Some(Box::new(|compositor: &mut Compositor| {
468− let picker = ui::file_picker("./");
469− compositor.push(Box::new(picker));
470− }));
471+ cx.callback = Some(Box::new(
472+ |compositor: &mut Compositor, editor: &mut Editor| {
473+ let picker = ui::file_picker("./");
474+ compositor.push(Box::new(picker));
475+ },
476+ ));
477+}
478+
479+pub fn buffer_picker(cx: &mut Context) {
480+ cx.callback = Some(Box::new(
481+ |compositor: &mut Compositor, editor: &mut Editor| {
482+ let picker = ui::buffer_picker(&editor.views, editor.focus);
483+ compositor.push(Box::new(picker));
484+ },
485+ ));
471486}
472487
473488// calculate line numbers for each selection range
helix-term/src/compositor.rs+2−2
@@ -19,7 +19,7 @@ use smol::Executor;
1919use tui::buffer::Buffer as Surface;
2020use tui::layout::Rect;
2121
22−pub type Callback = Box<dyn FnOnce(&mut Compositor)>;
22+pub type Callback = Box<dyn FnOnce(&mut Compositor, &mut Editor)>;
2323
2424// --> EventResult should have a callback that takes a context with methods like .popup(),
2525// .prompt() etc. That way we can abstract it from the renderer.
@@ -128,7 +128,7 @@ impl Compositor {
128128 if let Some(layer) = self.layers.last_mut() {
129129 return match layer.handle_event(event, cx) {
130130 EventResult::Consumed(Some(callback)) => {
131− callback(self);
131+ callback(self, cx.editor);
132132 true
133133 }
134134 EventResult::Consumed(None) => true,
helix-term/src/keymap.rs+1
@@ -185,6 +185,7 @@ pub fn default() -> Keymaps {
185185 vec![ctrl!('d')] => commands::half_page_down,
186186
187187 vec![ctrl!('p')] => commands::file_picker,
188+ vec![ctrl!('b')] => commands::buffer_picker,
188189 ),
189190 Mode::Insert => hashmap!(
190191 vec![Key {
helix-term/src/ui/mod.rs+26−2
@@ -15,7 +15,7 @@ pub fn text_color() -> Style {
1515 Style::default().fg(Color::Rgb(219, 191, 239)) // lilac
1616}
1717
18−use std::path::PathBuf;
18+use std::path::{Path, PathBuf};
1919pub fn file_picker(root: &str) -> Picker<PathBuf> {
2020 use ignore::Walk;
2121 // TODO: determine root based on git root
@@ -38,7 +38,7 @@ pub fn file_picker(root: &str) -> Picker<PathBuf> {
3838 files.take(MAX).collect(),
3939 |path: &PathBuf| {
4040 // format_fn
41− path.strip_prefix("./").unwrap().to_str().unwrap() // TODO: render paths without ./
41+ path.strip_prefix("./").unwrap().to_str().unwrap()
4242 },
4343 |editor: &mut Editor, path: &PathBuf| {
4444 let size = editor.view().unwrap().size;
@@ -46,3 +46,27 @@ pub fn file_picker(root: &str) -> Picker<PathBuf> {
4646 },
4747 )
4848}
49+
50+use helix_view::View;
51+pub fn buffer_picker(views: &[View], current: usize) -> Picker<(Option<PathBuf>, usize)> {
52+ use helix_view::Editor;
53+ Picker::new(
54+ views
55+ .iter()
56+ .enumerate()
57+ .map(|(i, view)| (view.doc.relative_path().map(Path::to_path_buf), i))
58+ .collect(),
59+ |(path, index): &(Option<PathBuf>, usize)| {
60+ // format_fn
61+ match path {
62+ Some(path) => path.to_str().unwrap(),
63+ None => "[NEW]",
64+ }
65+ },
66+ |editor: &mut Editor, &(_, index): &(Option<PathBuf>, usize)| {
67+ if index < editor.views.len() {
68+ editor.focus = index;
69+ }
70+ },
71+ )
72+}
helix-term/src/ui/picker.rs+6−4
@@ -123,10 +123,12 @@ impl<T> Component for Picker<T> {
123123 _ => return EventResult::Ignored,
124124 };
125125
126− let close_fn = EventResult::Consumed(Some(Box::new(|compositor: &mut Compositor| {
127− // remove the layer
128− compositor.pop();
129− })));
126+ let close_fn = EventResult::Consumed(Some(Box::new(
127+ |compositor: &mut Compositor, editor: &mut Editor| {
128+ // remove the layer
129+ compositor.pop();
130+ },
131+ )));
130132
131133 match key_event {
132134 // KeyEvent {
helix-term/src/ui/prompt.rs+6−4
@@ -167,10 +167,12 @@ impl Component for Prompt {
167167 _ => return EventResult::Ignored,
168168 };
169169
170− let close_fn = EventResult::Consumed(Some(Box::new(|compositor: &mut Compositor| {
171− // remove the layer
172− compositor.pop();
173− })));
170+ let close_fn = EventResult::Consumed(Some(Box::new(
171+ |compositor: &mut Compositor, editor: &mut Editor| {
172+ // remove the layer
173+ compositor.pop();
174+ },
175+ )));
174176
175177 match event {
176178 KeyEvent {