on master help sign in
Removing C-j and C-k from completion menu navigation (#5070)
61e1e61Dylan Bulfin
helix-term/src/ui/menu.rs+2−2
@@ -252,12 +252,12 @@ impl<T: Item + 'static> Component for Menu<T> {
252 return EventResult::Consumed(close_fn);
252 return EventResult::Consumed(close_fn);
253 }
253 }
254 // arrow up/ctrl-p/shift-tab prev completion choice (including updating the doc)
254 // arrow up/ctrl-p/shift-tab prev completion choice (including updating the doc)
255− shift!(Tab) | key!(Up) | ctrl!('p') | ctrl!('k') => {
255+ shift!(Tab) | key!(Up) | ctrl!('p') => {
256 self.move_up();
256 self.move_up();
257 (self.callback_fn)(cx.editor, self.selection(), MenuEvent::Update);
257 (self.callback_fn)(cx.editor, self.selection(), MenuEvent::Update);
258 return EventResult::Consumed(None);
258 return EventResult::Consumed(None);
259 }
259 }
260− key!(Tab) | key!(Down) | ctrl!('n') | ctrl!('j') => {
260+ key!(Tab) | key!(Down) | ctrl!('n') => {
261 // arrow down/ctrl-n/tab advances completion choice (including updating the doc)
261 // arrow down/ctrl-n/tab advances completion choice (including updating the doc)
262 self.move_down();
262 self.move_down();
263 (self.callback_fn)(cx.editor, self.selection(), MenuEvent::Update);
263 (self.callback_fn)(cx.editor, self.selection(), MenuEvent::Update);