62eb8c6 · helix · git.iko.soy

git.iko.soy/helix

mouse: Remove verify_screen_coords, refactor primary selection modification

commit62eb8c6b407c61d21dbee83c4b4e78c4e6cb87c3 authorBlaž Hrastnik <blaz@mxxn.io> dateFri 30 Jul 2021, 16:50 (5 years ago) parent6bb744a

3 files changed+37−56

compare with master

unifiedsplit

helix-core/src/selection.rs+7 helix-term/src/ui/editor.rs+16−27 helix-view/src/view.rs+14−29

helix-core/src/selection.rs+7

@@ -329,11 +329,18 @@ pub struct Selection {

329329impl Selection {

330330 // eq

331331

332+ #[inline]

332333 #[must_use]

333334 pub fn primary(&self) -> Range {

334335 self.ranges[self.primary_index]

335336 }

336337

338+ #[inline]

339+ #[must_use]

340+ pub fn primary_mut(&mut self) -> &mut Range {

341+ &mut self.ranges[self.primary_index]

342+ }

343+

337344 /// Ensure selection containing only the primary selection.

338345 pub fn into_single(self) -> Self {

339346 if self.ranges.len() == 1 {

helix-term/src/ui/editor.rs+16−27

@@ -815,25 +815,21 @@ impl Component for EditorView {

815815 let editor = &mut cx.editor;

816816

817817 let result = editor.tree.views().find_map(|(view, _focus)| {

818− view.pos_at_screen_coords(

819− &editor.documents[view.doc],

820− row as usize,

821− column as usize,

822− )

823− .map(|pos| (pos, view.id))

818+ view.pos_at_screen_coords(&editor.documents[view.doc], row, column)

819+ .map(|pos| (pos, view.id))

824820 });

825821

826− if let Some((pos, id)) = result {

827− let doc = &mut editor.documents[editor.tree.get(id).doc];

822+ if let Some((pos, view_id)) = result {

823+ let doc = &mut editor.documents[editor.tree.get(view_id).doc];

828824

829825 if modifiers == crossterm::event::KeyModifiers::ALT {

830− let selection = doc.selection(id).clone();

831− doc.set_selection(id, selection.push(Range::point(pos)));

826+ let selection = doc.selection(view_id).clone();

827+ doc.set_selection(view_id, selection.push(Range::point(pos)));

832828 } else {

833− doc.set_selection(id, Selection::point(pos));

829+ doc.set_selection(view_id, Selection::point(pos));

834830 }

835831

836− editor.tree.focus = id;

832+ editor.tree.focus = view_id;

837833

838834 return EventResult::Consumed(None);

839835 }

@@ -849,22 +845,15 @@ impl Component for EditorView {

849845 }) => {

850846 let (view, doc) = current!(cx.editor);

851847

852− let pos = view.pos_at_screen_coords(doc, row as usize, column as usize);

853−

854− if pos == None {

855− return EventResult::Ignored;

856− }

857−

858− let selection = doc.selection(view.id).clone();

859− let primary_anchor = selection.primary().anchor;

860− let new_selection = selection.transform(|range| -> Range {

861− if range.anchor == primary_anchor {

862− return Range::new(primary_anchor, pos.unwrap());

863− }

864− range

865− });

848+ let pos = match view.pos_at_screen_coords(doc, row, column) {

849+ Some(pos) => pos,

850+ None => return EventResult::Ignored,

851+ };

866852

867− doc.set_selection(view.id, new_selection);

853+ let mut selection = doc.selection(view.id).clone();

854+ let primary = selection.primary_mut();

855+ *primary = Range::new(primary.anchor, pos);

856+ doc.set_selection(view.id, selection);

868857 EventResult::Consumed(None)

869858 }

870859 Event::Mouse(_) => EventResult::Ignored,

helix-view/src/view.rs+14−29

@@ -166,38 +166,26 @@ impl View {

166166 Some(Position::new(row, col))

167167 }

168168

169− /// Verifies whether a screen position is inside the view

170− /// Returns true when position is inside the view

171− pub fn verify_screen_coords(&self, row: usize, column: usize) -> bool {

172− // 2 for status

173− if row < self.area.y as usize || row > self.area.y as usize + self.area.height as usize - 2

174− {

175− return false;

176− }

177−

178− // TODO: not ideal

179− const OFFSET: usize = 7; // 1 diagnostic + 5 linenr + 1 gutter

180−

181− if column < self.area.x as usize + OFFSET

182− || column > self.area.x as usize + self.area.width as usize

183− {

184− return false;

185− }

186− true

187− }

188−

189169 pub fn text_pos_at_screen_coords(

190170 &self,

191171 text: &RopeSlice,

192− row: usize,

193− column: usize,

172+ row: u16,

173+ column: u16,

194174 tab_width: usize,

195175 ) -> Option<usize> {

196− if !self.verify_screen_coords(row, column) {

176+ // TODO: not ideal

177+ const OFFSET: u16 = 7; // 1 diagnostic + 5 linenr + 1 gutter

178+

179+ // 2 for status

180+ if row < self.area.top() || row > self.area.bottom().saturating_sub(2) {

197181 return None;

198182 }

199183

200− let line_number = row - self.area.y as usize + self.first_line;

184+ if column < self.area.left() + OFFSET || column > self.area.right() {

185+ return None;

186+ }

187+

188+ let line_number = (row - self.area.y) as usize + self.first_line;

201189

202190 if line_number > text.len_lines() - 1 {

203191 return Some(text.len_chars());

@@ -207,10 +195,7 @@ impl View {

207195

208196 let current_line = text.line(line_number);

209197

210− // TODO: not ideal

211− const OFFSET: usize = 7; // 1 diagnostic + 5 linenr + 1 gutter

212−

213− let target = column - OFFSET - self.area.x as usize + self.first_col;

198+ let target = (column - OFFSET - self.area.x) as usize + self.first_col;

214199 let mut selected = 0;

215200

216201 for grapheme in RopeGraphemes::new(current_line) {

@@ -231,7 +216,7 @@ impl View {

231216

232217 /// Translates a screen position to position in the text document.

233218 /// Returns a usize typed position in bounds of the text if found in this view, None if out of view.

234− pub fn pos_at_screen_coords(&self, doc: &Document, row: usize, column: usize) -> Option<usize> {

219+ pub fn pos_at_screen_coords(&self, doc: &Document, row: u16, column: u16) -> Option<usize> {

235220 self.text_pos_at_screen_coords(&doc.text().slice(..), row, column, doc.tab_width())

236221 }

237222 // pub fn traverse<F>(&self, text: RopeSlice, start: usize, end: usize, fun: F)