63e54e3 · helix · git.iko.soy

git.iko.soy/helix

Implement in-memory prompt history

Implementation is similar to kakoune: we store the entries into a register.

commit63e54e30a74bb0d1d782877ddbbcf95f2817d061 authorBlaž Hrastnik <blaz@mxxn.io> dateSat 24 Jul 2021, 17:48 (5 years ago) parent29cefa1

5 files changed+70−9

compare with master

unifiedsplit

helix-core/src/register.rs+7−7 helix-term/src/commands.rs+3−2 helix-term/src/ui/mod.rs+1 helix-term/src/ui/picker.rs+1 helix-term/src/ui/prompt.rs+58

helix-core/src/register.rs+7−7

@@ -22,13 +22,17 @@ impl Register {

2222 self.name

2323 }

2424

25− pub fn read(&self) -> &Vec<String> {

25+ pub fn read(&self) -> &[String] {

2626 &self.values

2727 }

2828

2929 pub fn write(&mut self, values: Vec<String>) {

3030 self.values = values;

3131 }

32+

33+ pub fn push(&mut self, value: String) {

34+ self.values.push(value);

35+ }

3236}

3337

3438/// Currently just wraps a `HashMap` of `Register`s

@@ -42,11 +46,7 @@ impl Registers {

4246 self.inner.get(&name)

4347 }

4448

45− pub fn get_mut(&mut self, name: char) -> Option<&mut Register> {

46− self.inner.get_mut(&name)

47− }

48−

49− pub fn get_or_insert(&mut self, name: char) -> &mut Register {

49+ pub fn get_mut(&mut self, name: char) -> &mut Register {

5050 self.inner

5151 .entry(name)

5252 .or_insert_with(|| Register::new(name))

@@ -57,7 +57,7 @@ impl Registers {

5757 .insert(name, Register::new_with_values(name, values));

5858 }

5959

60− pub fn read(&self, name: char) -> Option<&Vec<String>> {

60+ pub fn read(&self, name: char) -> Option<&[String]> {

6161 self.get(name).map(|reg| reg.read())

6262 }

6363}

helix-term/src/commands.rs+3−2

@@ -1126,7 +1126,7 @@ fn delete_selection(cx: &mut Context) {

11261126 let reg_name = cx.selected_register.name();

11271127 let (view, doc) = current!(cx.editor);

11281128 let registers = &mut cx.editor.registers;

1129− let reg = registers.get_or_insert(reg_name);

1129+ let reg = registers.get_mut(reg_name);

11301130 delete_selection_impl(reg, doc, view.id);

11311131

11321132 doc.append_changes_to_history(view.id);

@@ -1139,7 +1139,7 @@ fn change_selection(cx: &mut Context) {

11391139 let reg_name = cx.selected_register.name();

11401140 let (view, doc) = current!(cx.editor);

11411141 let registers = &mut cx.editor.registers;

1142− let reg = registers.get_or_insert(reg_name);

1142+ let reg = registers.get_mut(reg_name);

11431143 delete_selection_impl(reg, doc, view.id);

11441144 enter_insert_mode(doc);

11451145}

@@ -1920,6 +1920,7 @@ mod cmd {

19201920fn command_mode(cx: &mut Context) {

19211921 let mut prompt = Prompt::new(

19221922 ":".to_owned(),

1923+ Some(':'),

19231924 |input: &str| {

19241925 // we use .this over split_whitespace() because we care about empty segments

19251926 let parts = input.split(' ').collect::<Vec<&str>>();

helix-term/src/ui/mod.rs+1

@@ -36,6 +36,7 @@ pub fn regex_prompt(

3636

3737 Prompt::new(

3838 prompt,

39+ None,

3940 |_input: &str| Vec::new(), // this is fine because Vec::new() doesn't allocate

4041 move |cx: &mut crate::compositor::Context, input: &str, event: PromptEvent| {

4142 match event {

helix-term/src/ui/picker.rs+1

@@ -43,6 +43,7 @@ impl<T> Picker<T> {

4343 ) -> Self {

4444 let prompt = Prompt::new(

4545 "".to_string(),

46+ None,

4647 |_pattern: &str| Vec::new(),

4748 |_editor: &mut Context, _pattern: &str, _event: PromptEvent| {

4849 //

helix-term/src/ui/prompt.rs+58

@@ -20,6 +20,8 @@ pub struct Prompt {

2020 cursor: usize,

2121 completion: Vec<Completion>,

2222 selection: Option<usize>,

23+ history_register: Option<char>,

24+ history_pos: Option<usize>,

2325 completion_fn: Box<dyn FnMut(&str) -> Vec<Completion>>,

2426 callback_fn: Box<dyn FnMut(&mut Context, &str, PromptEvent)>,

2527 pub doc_fn: Box<dyn Fn(&str) -> Option<&'static str>>,

@@ -54,6 +56,7 @@ pub enum Movement {

5456impl Prompt {

5557 pub fn new(

5658 prompt: String,

59+ history_register: Option<char>,

5760 mut completion_fn: impl FnMut(&str) -> Vec<Completion> + 'static,

5861 callback_fn: impl FnMut(&mut Context, &str, PromptEvent) + 'static,

5962 ) -> Self {

@@ -63,6 +66,8 @@ impl Prompt {

6366 cursor: 0,

6467 completion: completion_fn(""),

6568 selection: None,

69+ history_register,

70+ history_pos: None,

6671 completion_fn: Box::new(completion_fn),

6772 callback_fn: Box::new(callback_fn),

6873 doc_fn: Box::new(|_| None),

@@ -226,6 +231,28 @@ impl Prompt {

226231 self.exit_selection();

227232 }

228233

234+ pub fn change_history(&mut self, register: &[String], direction: CompletionDirection) {

235+ if register.is_empty() {

236+ return;

237+ }

238+

239+ let end = register.len().saturating_sub(1);

240+

241+ let index = match direction {

242+ CompletionDirection::Forward => self.history_pos.map_or(0, |i| i + 1),

243+ CompletionDirection::Backward => {

244+ self.history_pos.unwrap_or(register.len()).saturating_sub(1)

245+ }

246+ }

247+ .min(end);

248+

249+ self.line = register[index].clone();

250+

251+ self.history_pos = Some(index);

252+

253+ self.move_end();

254+ }

255+

229256 pub fn change_completion_selection(&mut self, direction: CompletionDirection) {

230257 if self.completion.is_empty() {

231258 return;

@@ -468,9 +495,40 @@ impl Component for Prompt {

468495 self.exit_selection();

469496 } else {

470497 (self.callback_fn)(cx, &self.line, PromptEvent::Validate);

498+

499+ if let Some(register) = self.history_register {

500+ // store in history

501+ let register = cx.editor.registers.get_mut(register);

502+ register.push(self.line.clone());

503+ }

471504 return close_fn;

472505 }

473506 }

507+ KeyEvent {

508+ code: KeyCode::Char('p'),

509+ modifiers: KeyModifiers::CONTROL,

510+ }

511+ | KeyEvent {

512+ code: KeyCode::Up, ..

513+ } => {

514+ if let Some(register) = self.history_register {

515+ let register = cx.editor.registers.get_mut(register);

516+ self.change_history(register.read(), CompletionDirection::Backward);

517+ }

518+ }

519+ KeyEvent {

520+ code: KeyCode::Char('n'),

521+ modifiers: KeyModifiers::CONTROL,

522+ }

523+ | KeyEvent {

524+ code: KeyCode::Down,

525+ ..

526+ } => {

527+ if let Some(register) = self.history_register {

528+ let register = cx.editor.registers.get_mut(register);

529+ self.change_history(register.read(), CompletionDirection::Forward);

530+ }

531+ }

474532 KeyEvent {

475533 code: KeyCode::Tab, ..

476534 } => self.change_completion_selection(CompletionDirection::Forward),