723a132 · helix · git.iko.soy

git.iko.soy/helix

Simplify implementation of `add_indent_level`.

Increase hybrid indent heuristic attempt limit to 4. Clarify the fallback logic in indent heuristic docs.

commit723a132bdfdacaabc888e48b1c378cd76e7ba84d authorDaniel Ebert <daniel.ebert@protonmail.com> dateSun 15 Oct 2023, 11:43 (3 years ago) parent3e79a35

2 files changed+20−23

compare with master

unifiedsplit

book/src/configuration.md+1−1 helix-core/src/indent.rs+19−22

book/src/configuration.md+1−1

@@ -65,7 +65,7 @@ Its settings will be merged with the configuration directory `config.toml` and t

6565| `workspace-lsp-roots` | Directories relative to the workspace root that are treated as LSP roots. Should only be set in `.helix/config.toml` | `[]` |

6666| `default-line-ending` | The line ending to use for new documents. Can be `native`, `lf`, `crlf`, `ff`, `cr` or `nel`. `native` uses the platform's native line ending (`crlf` on Windows, otherwise `lf`). | `native` |

6767| `insert-final-newline` | Whether to automatically insert a trailing line-ending on write if missing | `true` |

68−| `indent-heuristic` | How the indentation for a newly inserted line is computed: `simple` just copies the indentation level from the previous line, `tree-sitter` computes the indentation based on the syntax tree and `hybrid` combines both approaches | `hybrid`

68+| `indent-heuristic` | How the indentation for a newly inserted line is computed: `simple` just copies the indentation level from the previous line, `tree-sitter` computes the indentation based on the syntax tree and `hybrid` combines both approaches. If the chosen heuristic is not available, a different one will be used as a fallback (the fallback order being `hybrid` -> `tree-sitter` -> `simple`). | `hybrid`

6969

7070### `[editor.statusline]` Section

7171

helix-core/src/indent.rs+19−22

@@ -8,7 +8,7 @@ use crate::{

88 graphemes::{grapheme_width, tab_width_at},

99 syntax::{IndentationHeuristic, LanguageConfiguration, RopeProvider, Syntax},

1010 tree_sitter::Node,

11− Rope, RopeGraphemes, RopeSlice,

11+ Position, Rope, RopeGraphemes, RopeSlice,

1212};

1313

1414/// Enum representing indentation style.

@@ -225,27 +225,24 @@ fn add_indent_level(

225225 // Since the width of a tab depends on its offset, we cannot simply iterate over

226226 // the chars of `base_indent` in reverse until we have the desired indent reduction,

227227 // instead we iterate over them twice in forward direction.

228− let mut base_indent_width: usize = 0;

229− for c in base_indent.chars() {

230− base_indent_width += match c {

231− '\t' => tab_width_at(base_indent_width, tab_width as u16),

232− // This is only true since `base_indent` consists only of tabs and spaces

233− _ => 1,

234− };

235− }

228+ let base_indent_rope = RopeSlice::from(base_indent.as_str());

229+ #[allow(deprecated)]

230+ let base_indent_width =

231+ crate::visual_coords_at_pos(base_indent_rope, base_indent_rope.len_chars(), tab_width)

232+ .col;

236233 let target_indent_width = base_indent_width

237234 .saturating_sub((-added_indent_level) as usize * indent_style.indent_width(tab_width));

238− let mut reduced_indent_width = 0;

239− for (i, c) in base_indent.char_indices() {

240− if reduced_indent_width >= target_indent_width {

241− base_indent.truncate(i);

242− return base_indent;

243− }

244− reduced_indent_width += match c {

245− '\t' => tab_width_at(base_indent_width, tab_width as u16),

246− _ => 1,

247− };

248− }

235+ #[allow(deprecated)]

236+ let char_end_idx = crate::pos_at_visual_coords(

237+ base_indent_rope,

238+ Position {

239+ row: 0,

240+ col: target_indent_width,

241+ },

242+ tab_width,

243+ );

244+ let byte_end_idx = base_indent_rope.char_to_byte(char_end_idx);

245+ base_indent.truncate(byte_end_idx);

249246 base_indent

250247 }

251248}

@@ -959,7 +956,7 @@ pub fn indent_for_newline(

959956 line_before_end_pos,

960957 true,

961958 ) {

962− if let IndentationHeuristic::Hybrid = indent_heuristic {

959+ if *indent_heuristic == IndentationHeuristic::Hybrid {

963960 // We want to compute the indentation not only based on the

964961 // syntax tree but also on the actual indentation of a previous

965962 // line. This makes indentation computation more resilient to

@@ -969,7 +966,7 @@ pub fn indent_for_newline(

969966 // make sense, e.g. if it has a different alignment than the new line.

970967 // In order to prevent edge cases with long running times, we only try

971968 // a constant number of (non-empty) lines.

972− const MAX_ATTEMPTS: usize = 2;

969+ const MAX_ATTEMPTS: usize = 4;

973970 let mut num_attempts = 0;

974971 for line_idx in (0..=line_before).rev() {

975972 let line = text.line(line_idx);