7b61c63 · helix · git.iko.soy

git.iko.soy/helix

Handle stderr

commit7b61c63ece4384f75fa41f6c052b3d9e506ff3aa authorBlaž Hrastnik <blaz@mxxn.io> dateFri 3 Sep 2021, 13:26 (5 years ago) parentb997d2c

2 files changed+34−2

compare with master

unifiedsplit

helix-dap/src/client.rs+6−2 helix-dap/src/transport.rs+28

helix-dap/src/client.rs+6−2

@@ -62,10 +62,11 @@ impl Client {

6262 pub fn streams(

6363 rx: Box<dyn AsyncBufRead + Unpin + Send>,

6464 tx: Box<dyn AsyncWrite + Unpin + Send>,

65+ err: Option<Box<dyn AsyncBufRead + Unpin + Send>>,

6566 id: usize,

6667 process: Option<Child>,

6768 ) -> Result<(Self, UnboundedReceiver<Payload>)> {

68− let (server_rx, server_tx) = Transport::start(rx, tx, id);

69+ let (server_rx, server_tx) = Transport::start(rx, tx, err, id);

6970 let (client_rx, client_tx) = unbounded_channel();

7071

7172 let client = Self {

@@ -92,7 +93,7 @@ impl Client {

9293 ) -> Result<(Self, UnboundedReceiver<Payload>)> {

9394 let stream = TcpStream::connect(addr).await?;

9495 let (rx, tx) = stream.into_split();

95− Self::streams(Box::new(BufReader::new(rx)), Box::new(tx), id, None)

96+ Self::streams(Box::new(BufReader::new(rx)), Box::new(tx), None, id, None)

9697 }

9798

9899 pub fn stdio(

@@ -113,10 +114,12 @@ impl Client {

113114 // TODO: do we need bufreader/writer here? or do we use async wrappers on unblock?

114115 let writer = BufWriter::new(process.stdin.take().expect("Failed to open stdin"));

115116 let reader = BufReader::new(process.stdout.take().expect("Failed to open stdout"));

117+ let errors = BufReader::new(process.stderr.take().expect("Failed to open stderr"));

116118

117119 Self::streams(

118120 Box::new(BufReader::new(reader)),

119121 Box::new(writer),

122+ Some(Box::new(BufReader::new(errors))),

120123 id,

121124 Some(process),

122125 )

@@ -167,6 +170,7 @@ impl Client {

167170 Self::streams(

168171 Box::new(BufReader::new(rx)),

169172 Box::new(tx),

173+ None,

170174 id,

171175 Some(process),

172176 )

helix-dap/src/transport.rs+28

@@ -53,6 +53,7 @@ impl Transport {

5353 pub fn start(

5454 server_stdout: Box<dyn AsyncBufRead + Unpin + Send>,

5555 server_stdin: Box<dyn AsyncWrite + Unpin + Send>,

56+ server_stderr: Option<Box<dyn AsyncBufRead + Unpin + Send>>,

5657 id: usize,

5758 ) -> (UnboundedReceiver<Payload>, UnboundedSender<Request>) {

5859 let (client_tx, rx) = unbounded_channel();

@@ -67,6 +68,9 @@ impl Transport {

6768

6869 tokio::spawn(Self::recv(transport.clone(), server_stdout, client_tx));

6970 tokio::spawn(Self::send(transport, server_stdin, client_rx));

71+ if let Some(stderr) = server_stderr {

72+ tokio::spawn(Self::err(stderr));

73+ }

7074

7175 (rx, tx)

7276 }

@@ -117,6 +121,17 @@ impl Transport {

117121 Ok(output?)

118122 }

119123

124+ async fn recv_server_error(

125+ err: &mut (impl AsyncBufRead + Unpin + Send),

126+ buffer: &mut String,

127+ ) -> Result<()> {

128+ buffer.truncate(0);

129+ err.read_line(buffer).await?;

130+ error!("err <- {}", buffer);

131+

132+ Ok(())

133+ }

134+

120135 async fn send_payload_to_server(

121136 &self,

122137 server_stdin: &mut Box<dyn AsyncWrite + Unpin + Send>,

@@ -243,4 +258,17 @@ impl Transport {

243258 .unwrap()

244259 }

245260 }

261+

262+ async fn err(mut server_stderr: Box<dyn AsyncBufRead + Unpin + Send>) {

263+ let mut recv_buffer = String::new();

264+ loop {

265+ match Self::recv_server_error(&mut server_stderr, &mut recv_buffer).await {

266+ Ok(_) => {}

267+ Err(err) => {

268+ error!("err: <- {:?}", err);

269+ break;

270+ }

271+ }

272+ }

273+ }

246274}