8a4fbf6 · helix · git.iko.soy

completion: remove_follow links on filename_impl

We don't need to follow links since we're only scanning the current directory level (non-recursive).

commit8a4fbf6daf980b08de83e936c4a2b4bf8beaa2d4 authorBlaž Hrastnik <blaz@mxxn.io> dateTue 30 Aug 2022, 12:23 (4 years ago) parentd2cec25

1 file changed+2−2

unifiedsplit

helix-term/src/ui/mod.rs+2−2

@@ -381,7 +381,7 @@ pub mod completers {

381381 }

382382

383383 // TODO: we could return an iter/lazy thing so it can fetch as many as it needs.

384− fn filename_impl<F>(editor: &Editor, input: &str, filter_fn: F) -> Vec<Completion>

384+ fn filename_impl<F>(_editor: &Editor, input: &str, filter_fn: F) -> Vec<Completion>

385385 where

386386 F: Fn(&ignore::DirEntry) -> FileMatch,

387387 {

@@ -413,7 +413,7 @@ pub mod completers {

413413

414414 let mut files: Vec<_> = WalkBuilder::new(&dir)

415415 .hidden(false)

416− .follow_links(editor.config().file_picker.follow_symlinks)

416+ .follow_links(false) // We're scanning over depth 1

417417 .max_depth(Some(1))

418418 .build()

419419 .filter_map(|file| {