git.iko.soy/helix
on master help sign in
Fix signature help panic when too large (#4030)

When signature help is too large it may cause a panic when it is too large, now I just make the hover do an intersection with surface to make sure it never overflow.

commit93f26a3048606704c6c16c80a0090fbae64eaf80 authorIvan Tham <pickfire@riseup.net> dateMon 3 Oct 2022, 22:56 (4 years ago) parent63ff930
1 file changed+2−1
compare with master
unifiedsplit
helix-term/src/ui/lsp.rs+2−1
helix-term/src/ui/lsp.rs+2−1
@@ -68,8 +68,9 @@ impl Component for SignatureHelp {
6868
6969 let (_, sig_text_height) = crate::ui::text::required_size(&sig_text, area.width);
7070 let sig_text_area = area.clip_top(1).with_height(sig_text_height);
71+ let sig_text_area = sig_text_area.inner(&margin).intersection(surface.area);
7172 let sig_text_para = Paragraph::new(sig_text).wrap(Wrap { trim: false });
72− sig_text_para.render(sig_text_area.inner(&margin), surface);
73+ sig_text_para.render(sig_text_area, surface);
7374
7475 if self.signature_doc.is_none() {
7576 return;