git.iko.soy/helix
on master help sign in
Remove redundant fetching of stack traces
9b8c5bdDmitry Sharshakov
helix-term/src/commands/dap.rs+2−11
compare with master
unifiedsplit
@@ -112,16 +112,7 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
112 }
112 }
113
113
114 let thread_states = debugger.thread_states.clone();
114 let thread_states = debugger.thread_states.clone();
115− let mut top_frames: HashMap<isize, StackFrame> = HashMap::new();
115+ let frames = debugger.stack_frames.clone();
116− for thread in threads.clone() {
117− if let Some(frame) = block_on(debugger.stack_trace(thread.id))
118− .ok()
119− .and_then(|(bt, _)| bt.get(0).cloned())
120− {
121− top_frames.insert(thread.id, frame);
122− }
123− }
124−
125 let picker = FilePicker::new(
116 let picker = FilePicker::new(
126 threads,
117 threads,
127 move |thread| {
118 move |thread| {
@@ -136,7 +127,7 @@ fn thread_picker(cx: &mut Context, callback_fn: impl Fn(&mut Editor, &dap::Threa
136 },
127 },
137 move |editor, thread, _action| callback_fn(editor, thread),
128 move |editor, thread, _action| callback_fn(editor, thread),
138 move |_editor, thread| {
129 move |_editor, thread| {
139− if let Some(frame) = top_frames.get(&thread.id) {
130+ if let Some(frame) = frames.get(&thread.id).and_then(|bt| bt.get(0)) {
140 frame
131 frame
141 .source
132 .source
142 .as_ref()
133 .as_ref()