a7daa02 · helix · git.iko.soy

git.iko.soy/helix

DynamicPicker: Use idle-timeout as debounce

This change uses the idle-timeout event to trigger fetching new results in the DynamicPicker, so idle-timeout becomes a sort of debounce. This prevents querying the language server overly aggressively.

commita7daa02346789e43af51db2b944b0dc516354a29 authorMichael Davis <mcarsondavis@gmail.com> dateWed 7 Dec 2022, 16:27 (4 years ago) parentd1f717e

1 file changed+5−2

compare with master

unifiedsplit

helix-term/src/ui/picker.rs+5−2

helix-term/src/ui/picker.rs+5−2

@@ -763,6 +763,7 @@ pub type DynQueryCallback<T> =

763763pub struct DynamicPicker<T: ui::menu::Item + Send> {

764764 file_picker: FilePicker<T>,

765765 query_callback: DynQueryCallback<T>,

766+ query: String,

766767}

767768

768769impl<T: ui::menu::Item + Send> DynamicPicker<T> {

@@ -772,6 +773,7 @@ impl<T: ui::menu::Item + Send> DynamicPicker<T> {

772773 Self {

773774 file_picker,

774775 query_callback,

776+ query: String::new(),

775777 }

776778 }

777779}

@@ -782,14 +784,15 @@ impl<T: Item + Send + 'static> Component for DynamicPicker<T> {

782784 }

783785

784786 fn handle_event(&mut self, event: &Event, cx: &mut Context) -> EventResult {

785− let prev_query = self.file_picker.picker.prompt.line().to_owned();

786787 let event_result = self.file_picker.handle_event(event, cx);

787788 let current_query = self.file_picker.picker.prompt.line();

788789

789− if *current_query == prev_query || matches!(event_result, EventResult::Ignored(_)) {

790+ if !matches!(event, Event::IdleTimeout) || self.query == *current_query {

790791 return event_result;

791792 }

792793

794+ self.query.clone_from(current_query);

795+

793796 let new_options = (self.query_callback)(current_query.to_owned(), cx.editor);

794797

795798 cx.jobs.callback(async move {