on master help sign in
Run clippy on workspace in CI (#4614)
eddf9f0Jonathan LEI
.github/workflows/build.yml+1−1
@@ -101,7 +101,7 @@ jobs:
101 uses: actions-rs/cargo@v1
101 uses: actions-rs/cargo@v1
102 with:
102 with:
103 command: clippy
103 command: clippy
104− args: --all-targets -- -D warnings
104+ args: --workspace --all-targets -- -D warnings
105
105
106 - name: Run cargo doc
106 - name: Run cargo doc
107 uses: actions-rs/cargo@v1
107 uses: actions-rs/cargo@v1
helix-core/src/test.rs+1
@@ -148,6 +148,7 @@ pub fn plain(s: &str, selection: Selection) -> String {
148}
148}
149
149
150#[cfg(test)]
150#[cfg(test)]
151+#[allow(clippy::module_inception)]
151mod test {
152mod test {
152 use super::*;
153 use super::*;
153
154
xtask/src/querycheck.rs+2−2
@@ -17,8 +17,8 @@ pub fn query_check() -> Result<(), DynError> {
17 let language_name = &language.language_id;
17 let language_name = &language.language_id;
18 let grammar_name = language.grammar.as_ref().unwrap_or(language_name);
18 let grammar_name = language.grammar.as_ref().unwrap_or(language_name);
19 for query_file in query_files {
19 for query_file in query_files {
20− let language = get_language(&grammar_name);
20+ let language = get_language(grammar_name);
21− let query_text = read_query(&language_name, query_file);
21+ let query_text = read_query(language_name, query_file);
22 if let Ok(lang) = language {
22 if let Ok(lang) = language {
23 if !query_text.is_empty() {
23 if !query_text.is_empty() {
24 if let Err(reason) = Query::new(lang, &query_text) {
24 if let Err(reason) = Query::new(lang, &query_text) {