@@ -29,11 +29,12 @@ use helix_core::{
2929 tree_sitter::Node,
3030 unicode::width::UnicodeWidthChar,
3131 visual_offset_from_block, Deletion, LineEnding, Position, Range, Rope, RopeGraphemes,
32− RopeReader, RopeSlice, Selection, SmallVec, Tendril, Transaction,
32+ RopeSlice, Selection, SmallVec, Tendril, Transaction,
3333};
3434use helix_view::{
35+ clipboard::ClipboardType,
3536 document::{FormatterError, Mode, SCRATCH_BUFFER_NAME},
36− editor::{Action, CompleteAction},
37+ editor::{Action, CompleteAction, Motion},
3738 info::Info,
3839 input::KeyEvent,
3940 keyboard::KeyCode,
@@ -43,6 +44,7 @@ use helix_view::{
4344};
4445
4546use anyhow::{anyhow, bail, ensure, Context as _};
47+use fuzzy_matcher::FuzzyMatcher;
4648use insert::*;
4749use movement::Movement;
4850
@@ -53,20 +55,15 @@ use crate::{
5355 job::Callback,
5456 keymap::ReverseKeymap,
5557 ui::{
56− self, editor::InsertEvent, lsp::SignatureHelp, overlay::overlaid, CompletionItem, Picker,
57− Popup, Prompt, PromptEvent,
58+ self, editor::InsertEvent, lsp::SignatureHelp, overlay::overlaid, CompletionItem,
59+ FilePicker, Picker, Popup, Prompt, PromptEvent,
5860 },
5961};
6062
6163use crate::job::{self, Jobs};
62−use futures_util::{stream::FuturesUnordered, TryStreamExt};
63−use std::{
64− collections::{HashMap, HashSet},
65− fmt,
66− future::Future,
67− io::Read,
68− num::NonZeroUsize,
69−};
64+use futures_util::{stream::FuturesUnordered, StreamExt, TryStreamExt};
65+use std::{collections::HashMap, fmt, future::Future};
66+use std::{collections::HashSet, num::NonZeroUsize};
7067
7168use std::{
7269 borrow::Cow,
@@ -75,11 +72,11 @@ use std::{
7572
7673use once_cell::sync::Lazy;
7774use serde::de::{self, Deserialize, Deserializer};
78−use url::Url;
7975
8076use grep_regex::RegexMatcherBuilder;
8177use grep_searcher::{sinks, BinaryDetection, SearcherBuilder};
8278use ignore::{DirEntry, WalkBuilder, WalkState};
79+use tokio_stream::wrappers::UnboundedReceiverStream;
8380
8481pub type OnKeyCallback = Box<dyn FnOnce(&mut Context, KeyEvent)>;
8582
@@ -250,9 +247,6 @@ impl MappableCommand {
250247 move_next_long_word_start, "Move to start of next long word",
251248 move_prev_long_word_start, "Move to start of previous long word",
252249 move_next_long_word_end, "Move to end of next long word",
253− move_prev_long_word_end, "Move to end of previous long word",
254− move_parent_node_end, "Move to end of the parent node",
255− move_parent_node_start, "Move to beginning of the parent node",
256250 extend_next_word_start, "Extend to start of next word",
257251 extend_prev_word_start, "Extend to start of previous word",
258252 extend_next_word_end, "Extend to end of next word",
@@ -260,9 +254,6 @@ impl MappableCommand {
260254 extend_next_long_word_start, "Extend to start of next long word",
261255 extend_prev_long_word_start, "Extend to start of previous long word",
262256 extend_next_long_word_end, "Extend to end of next long word",
263− extend_prev_long_word_end, "Extend to end of prev long word",
264− extend_parent_node_end, "Extend to end of the parent node",
265− extend_parent_node_start, "Extend to beginning of the parent node",
266257 find_till_char, "Move till next occurrence of char",
267258 find_next_char, "Move to next occurrence of char",
268259 extend_till_char, "Extend till next occurrence of char",
@@ -337,7 +328,7 @@ impl MappableCommand {
337328 goto_implementation, "Goto implementation",
338329 goto_file_start, "Goto line number <n> else file start",
339330 goto_file_end, "Goto file end",
340− goto_file, "Goto files/URLs in selection",
331+ goto_file, "Goto files in selection",
341332 goto_file_hsplit, "Goto files in selection (hsplit)",
342333 goto_file_vsplit, "Goto files in selection (vsplit)",
343334 goto_reference, "Goto references",
@@ -369,7 +360,6 @@ impl MappableCommand {
369360 extend_to_line_end, "Extend to line end",
370361 extend_to_line_end_newline, "Extend to line end",
371362 signature_help, "Show signature help",
372− smart_tab, "Insert tab if all cursors have all whitespace to their left; otherwise, run a separate command.",
373363 insert_tab, "Insert tab char",
374364 insert_newline, "Insert newline char",
375365 delete_char_backward, "Delete previous char",
@@ -384,9 +374,6 @@ impl MappableCommand {
384374 later, "Move forward in history",
385375 commit_undo_checkpoint, "Commit changes to new checkpoint",
386376 yank, "Yank selection",
387− yank_to_clipboard, "Yank selections to clipboard",
388− yank_to_primary_clipboard, "Yank selections to primary clipboard",
389− yank_joined, "Join and yank selections",
390377 yank_joined_to_clipboard, "Join and yank selections to clipboard",
391378 yank_main_selection_to_clipboard, "Yank main selection to clipboard",
392379 yank_joined_to_primary_clipboard, "Join and yank selections to primary clipboard",
@@ -417,7 +404,6 @@ impl MappableCommand {
417404 rotate_selections_backward, "Rotate selections backward",
418405 rotate_selection_contents_forward, "Rotate selection contents forward",
419406 rotate_selection_contents_backward, "Rotate selections contents backward",
420− reverse_selection_contents, "Reverse selections contents",
421407 expand_selection, "Expand selection to parent syntax node",
422408 shrink_selection, "Shrink selection to previously expanded syntax node",
423409 select_next_sibling, "Select next sibling in syntax tree",
@@ -990,7 +976,6 @@ fn align_selections(cx: &mut Context) {
990976
991977 let transaction = Transaction::change(doc.text(), changes.into_iter());
992978 doc.apply(&transaction, view.id);
993− exit_select_mode(cx);
994979}
995980
996981fn goto_window(cx: &mut Context, align: Align) {
@@ -1082,10 +1067,6 @@ fn move_prev_long_word_start(cx: &mut Context) {
10821067 move_word_impl(cx, movement::move_prev_long_word_start)
10831068}
10841069
1085−fn move_prev_long_word_end(cx: &mut Context) {
1086− move_word_impl(cx, movement::move_prev_long_word_end)
1087−}
1088−
10891070fn move_next_long_word_end(cx: &mut Context) {
10901071 move_word_impl(cx, movement::move_next_long_word_end)
10911072}
@@ -1110,7 +1091,8 @@ where
11101091 .transform(|range| move_fn(text, range, count, behavior));
11111092 doc.set_selection(view.id, selection);
11121093 };
1113− cx.editor.apply_motion(motion)
1094+ motion(cx.editor);
1095+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
11141096}
11151097
11161098fn goto_prev_paragraph(cx: &mut Context) {
@@ -1165,10 +1147,6 @@ fn goto_file_impl(cx: &mut Context, action: Action) {
11651147 let (view, doc) = current_ref!(cx.editor);
11661148 let text = doc.text();
11671149 let selections = doc.selection(view.id);
1168− let rel_path = doc
1169− .relative_path()
1170− .map(|path| path.parent().unwrap().to_path_buf())
1171− .unwrap_or_default();
11721150 let mut paths: Vec<_> = selections
11731151 .iter()
11741152 .map(|r| text.slice(r.from()..r.to()).to_string())
@@ -1196,80 +1174,16 @@ fn goto_file_impl(cx: &mut Context, action: Action) {
11961174 .to_string(),
11971175 );
11981176 }
1199−
12001177 for sel in paths {
12011178 let p = sel.trim();
1202− if p.is_empty() {
1203− continue;
1204− }
1205−
1206− if let Ok(url) = Url::parse(p) {
1207− return open_url(cx, url, action);
1208− }
1209−
1210− let path = &rel_path.join(p);
1211− if path.is_dir() {
1212− let picker = ui::file_picker(path.into(), &cx.editor.config());
1213− cx.push_layer(Box::new(overlaid(picker)));
1214− } else if let Err(e) = cx.editor.open(path, action) {
1215− cx.editor.set_error(format!("Open file failed: {:?}", e));
1216− }
1217− }
1218−}
1219−
1220−/// Opens the given url. If the URL points to a valid textual file it is open in helix.
1221−// Otherwise, the file is open using external program.
1222−fn open_url(cx: &mut Context, url: Url, action: Action) {
1223− let doc = doc!(cx.editor);
1224− let rel_path = doc
1225− .relative_path()
1226− .map(|path| path.parent().unwrap().to_path_buf())
1227− .unwrap_or_default();
1228−
1229− if url.scheme() != "file" {
1230− return open_external_url(cx, url);
1231− }
1232−
1233− let content_type = std::fs::File::open(url.path()).and_then(|file| {
1234− // Read up to 1kb to detect the content type
1235− let mut read_buffer = Vec::new();
1236− let n = file.take(1024).read_to_end(&mut read_buffer)?;
1237− Ok(content_inspector::inspect(&read_buffer[..n]))
1238− });
1239−
1240− // we attempt to open binary files - files that can't be open in helix - using external
1241− // program as well, e.g. pdf files or images
1242− match content_type {
1243− Ok(content_inspector::ContentType::BINARY) => open_external_url(cx, url),
1244− Ok(_) | Err(_) => {
1245− let path = &rel_path.join(url.path());
1246− if path.is_dir() {
1247− let picker = ui::file_picker(path.into(), &cx.editor.config());
1248− cx.push_layer(Box::new(overlaid(picker)));
1249− } else if let Err(e) = cx.editor.open(path, action) {
1179+ if !p.is_empty() {
1180+ if let Err(e) = cx.editor.open(&PathBuf::from(p), action) {
12501181 cx.editor.set_error(format!("Open file failed: {:?}", e));
12511182 }
12521183 }
12531184 }
12541185}
12551186
1256−/// Opens URL in external program.
1257−fn open_external_url(cx: &mut Context, url: Url) {
1258− let commands = open::commands(url.as_str());
1259− cx.jobs.callback(async {
1260− for cmd in commands {
1261− let mut command = tokio::process::Command::new(cmd.get_program());
1262− command.args(cmd.get_args());
1263− if command.output().await.is_ok() {
1264− return Ok(job::Callback::Editor(Box::new(|_| {})));
1265− }
1266− }
1267− Ok(job::Callback::Editor(Box::new(move |editor| {
1268− editor.set_error("Opening URL in external program failed")
1269− })))
1270− });
1271−}
1272−
12731187fn extend_word_impl<F>(cx: &mut Context, extend_fn: F)
12741188where
12751189 F: Fn(RopeSlice, Range, usize) -> Range,
@@ -1310,74 +1224,14 @@ fn extend_prev_long_word_start(cx: &mut Context) {
13101224 extend_word_impl(cx, movement::move_prev_long_word_start)
13111225}
13121226
1313−fn extend_prev_long_word_end(cx: &mut Context) {
1314− extend_word_impl(cx, movement::move_prev_long_word_end)
1315−}
1316−
13171227fn extend_next_long_word_end(cx: &mut Context) {
13181228 extend_word_impl(cx, movement::move_next_long_word_end)
13191229}
13201230
1321−/// Separate branch to find_char designed only for `<ret>` char.
1322−//
1323−// This is necessary because the one document can have different line endings inside. And we
1324−// cannot predict what character to find when <ret> is pressed. On the current line it can be `lf`
1325−// but on the next line it can be `crlf`. That's why [`find_char_impl`] cannot be applied here.
1326−fn find_char_line_ending(
1327− cx: &mut Context,
1328− count: usize,
1329− direction: Direction,
1330− inclusive: bool,
1331− extend: bool,
1332−) {
1333− let (view, doc) = current!(cx.editor);
1334− let text = doc.text().slice(..);
1335−
1336− let selection = doc.selection(view.id).clone().transform(|range| {
1337− let cursor = range.cursor(text);
1338− let cursor_line = range.cursor_line(text);
1339−
1340− // Finding the line where we're going to find <ret>. Depends mostly on
1341− // `count`, but also takes into account edge cases where we're already at the end
1342− // of a line or the beginning of a line
1343− let find_on_line = match direction {
1344− Direction::Forward => {
1345− let on_edge = line_end_char_index(&text, cursor_line) == cursor;
1346− let line = cursor_line + count - 1 + (on_edge as usize);
1347− if line >= text.len_lines() - 1 {
1348− return range;
1349− } else {
1350− line
1351− }
1352− }
1353− Direction::Backward => {
1354− let on_edge = text.line_to_char(cursor_line) == cursor && !inclusive;
1355− let line = cursor_line as isize - (count as isize - 1 + on_edge as isize);
1356− if line <= 0 {
1357− return range;
1358− } else {
1359− line as usize
1360− }
1361− }
1362− };
1363−
1364− let pos = match (direction, inclusive) {
1365− (Direction::Forward, true) => line_end_char_index(&text, find_on_line),
1366− (Direction::Forward, false) => line_end_char_index(&text, find_on_line) - 1,
1367− (Direction::Backward, true) => line_end_char_index(&text, find_on_line - 1),
1368− (Direction::Backward, false) => text.line_to_char(find_on_line),
1369− };
1370−
1371− if extend {
1372− range.put_cursor(text, pos, true)
1373− } else {
1374− Range::point(range.cursor(text)).put_cursor(text, pos, true)
1375− }
1376− });
1377− doc.set_selection(view.id, selection);
1378−}
1379−
1380−fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bool) {
1231+fn will_find_char<F>(cx: &mut Context, search_fn: F, inclusive: bool, extend: bool)
1232+where
1233+ F: Fn(RopeSlice, char, usize, usize, bool) -> Option<usize> + 'static,
1234+{
13811235 // TODO: count is reset to 1 before next key so we move it into the closure here.
13821236 // Would be nice to carry over.
13831237 let count = cx.count();
@@ -1390,9 +1244,13 @@ fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bo
13901244 KeyEvent {
13911245 code: KeyCode::Enter,
13921246 ..
1393− } => {
1394− find_char_line_ending(cx, count, direction, inclusive, extend);
1395− return;
1247+ } =>
1248+ // TODO: this isn't quite correct when CRLF is involved.
1249+ // This hack will work in most cases, since documents don't
1250+ // usually mix line endings. But we should fix it eventually
1251+ // anyway.
1252+ {
1253+ doc!(cx.editor).line_ending.as_str().chars().next().unwrap()
13961254 }
13971255
13981256 KeyEvent {
@@ -1405,18 +1263,11 @@ fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bo
14051263 } => ch,
14061264 _ => return,
14071265 };
1408− let motion = move |editor: &mut Editor| {
1409− match direction {
1410− Direction::Forward => {
1411− find_char_impl(editor, &find_next_char_impl, inclusive, extend, ch, count)
1412− }
1413− Direction::Backward => {
1414− find_char_impl(editor, &find_prev_char_impl, inclusive, extend, ch, count)
1415− }
1416− };
1417− };
14181266
1419− cx.editor.apply_motion(motion);
1267+ find_char_impl(cx.editor, &search_fn, inclusive, extend, ch, count);
1268+ cx.editor.last_motion = Some(Motion(Box::new(move |editor: &mut Editor| {
1269+ find_char_impl(editor, &search_fn, inclusive, extend, ch, 1);
1270+ })));
14201271 })
14211272}
14221273
@@ -1495,39 +1346,46 @@ fn find_prev_char_impl(
14951346}
14961347
14971348fn find_till_char(cx: &mut Context) {
1498− find_char(cx, Direction::Forward, false, false);
1349+ will_find_char(cx, find_next_char_impl, false, false)
14991350}
15001351
15011352fn find_next_char(cx: &mut Context) {
1502− find_char(cx, Direction::Forward, true, false)
1353+ will_find_char(cx, find_next_char_impl, true, false)
15031354}
15041355
15051356fn extend_till_char(cx: &mut Context) {
1506− find_char(cx, Direction::Forward, false, true)
1357+ will_find_char(cx, find_next_char_impl, false, true)
15071358}
15081359
15091360fn extend_next_char(cx: &mut Context) {
1510− find_char(cx, Direction::Forward, true, true)
1361+ will_find_char(cx, find_next_char_impl, true, true)
15111362}
15121363
15131364fn till_prev_char(cx: &mut Context) {
1514− find_char(cx, Direction::Backward, false, false)
1365+ will_find_char(cx, find_prev_char_impl, false, false)
15151366}
15161367
15171368fn find_prev_char(cx: &mut Context) {
1518− find_char(cx, Direction::Backward, true, false)
1369+ will_find_char(cx, find_prev_char_impl, true, false)
15191370}
15201371
15211372fn extend_till_prev_char(cx: &mut Context) {
1522− find_char(cx, Direction::Backward, false, true)
1373+ will_find_char(cx, find_prev_char_impl, false, true)
15231374}
15241375
15251376fn extend_prev_char(cx: &mut Context) {
1526− find_char(cx, Direction::Backward, true, true)
1377+ will_find_char(cx, find_prev_char_impl, true, true)
15271378}
15281379
15291380fn repeat_last_motion(cx: &mut Context) {
1530− cx.editor.repeat_last_motion(cx.count())
1381+ let count = cx.count();
1382+ let last_motion = cx.editor.last_motion.take();
1383+ if let Some(m) = &last_motion {
1384+ for _ in 0..count {
1385+ m.run(cx.editor);
1386+ }
1387+ cx.editor.last_motion = last_motion;
1388+ }
15311389}
15321390
15331391fn replace(cx: &mut Context) {
@@ -1594,7 +1452,6 @@ where
15941452 });
15951453
15961454 doc.apply(&transaction, view.id);
1597− exit_select_mode(cx);
15981455}
15991456
16001457fn switch_case(cx: &mut Context) {
@@ -1836,8 +1693,8 @@ fn select_regex(cx: &mut Context) {
18361693 "select:".into(),
18371694 Some(reg),
18381695 ui::completers::none,
1839− move |cx, regex, event| {
1840− let (view, doc) = current!(cx.editor);
1696+ move |editor, regex, event| {
1697+ let (view, doc) = current!(editor);
18411698 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
18421699 return;
18431700 }
@@ -1858,8 +1715,8 @@ fn split_selection(cx: &mut Context) {
18581715 "split:".into(),
18591716 Some(reg),
18601717 ui::completers::none,
1861− move |cx, regex, event| {
1862− let (view, doc) = current!(cx.editor);
1718+ move |editor, regex, event| {
1719+ let (view, doc) = current!(editor);
18631720 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
18641721 return;
18651722 }
@@ -1982,11 +1839,11 @@ fn search_impl(
19821839
19831840fn search_completions(cx: &mut Context, reg: Option<char>) -> Vec<String> {
19841841 let mut items = reg
1985− .and_then(|reg| cx.editor.registers.read(reg, cx.editor))
1986− .map_or(Vec::new(), |reg| reg.take(200).collect());
1842+ .and_then(|reg| cx.editor.registers.get(reg))
1843+ .map_or(Vec::new(), |reg| reg.read().iter().take(200).collect());
19871844 items.sort_unstable();
19881845 items.dedup();
1989− items.into_iter().map(|value| value.to_string()).collect()
1846+ items.into_iter().cloned().collect()
19901847}
19911848
19921849fn search(cx: &mut Context) {
@@ -2023,14 +1880,12 @@ fn searcher(cx: &mut Context, direction: Direction) {
20231880 .map(|comp| (0.., std::borrow::Cow::Owned(comp.clone())))
20241881 .collect()
20251882 },
2026− move |cx, regex, event| {
2027− if event == PromptEvent::Validate {
2028− cx.editor.registers.last_search_register = reg;
2029− } else if event != PromptEvent::Update {
1883+ move |editor, regex, event| {
1884+ if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
20301885 return;
20311886 }
20321887 search_impl(
2033− cx.editor,
1888+ editor,
20341889 &contents,
20351890 ®ex,
20361891 Movement::Move,
@@ -2045,13 +1900,11 @@ fn searcher(cx: &mut Context, direction: Direction) {
20451900
20461901fn search_next_or_prev_impl(cx: &mut Context, movement: Movement, direction: Direction) {
20471902 let count = cx.count();
2048− let register = cx
2049− .register
2050− .unwrap_or(cx.editor.registers.last_search_register);
20511903 let config = cx.editor.config();
20521904 let scrolloff = config.scrolloff;
2053− if let Some(query) = cx.editor.registers.first(register, cx.editor) {
2054− let doc = doc!(cx.editor);
1905+ let (_, doc) = current!(cx.editor);
1906+ let registers = &cx.editor.registers;
1907+ if let Some(query) = registers.read('/').and_then(|query| query.last()) {
20551908 let contents = doc.text().slice(..).to_string();
20561909 let search_config = &config.search;
20571910 let case_insensitive = if search_config.smart_case {
@@ -2060,7 +1913,7 @@ fn search_next_or_prev_impl(cx: &mut Context, movement: Movement, direction: Dir
20601913 false
20611914 };
20621915 let wrap_around = search_config.wrap_around;
2063− if let Ok(regex) = RegexBuilder::new(&query)
1916+ if let Ok(regex) = RegexBuilder::new(query)
20641917 .case_insensitive(case_insensitive)
20651918 .multi_line(true)
20661919 .build()
@@ -2100,7 +1953,6 @@ fn extend_search_prev(cx: &mut Context) {
21001953}
21011954
21021955fn search_selection(cx: &mut Context) {
2103− let register = cx.register.unwrap_or('/');
21041956 let (view, doc) = current!(cx.editor);
21051957 let contents = doc.text().slice(..);
21061958
@@ -2113,24 +1965,13 @@ fn search_selection(cx: &mut Context) {
21131965 .collect::<Vec<_>>()
21141966 .join("|");
21151967
2116− let msg = format!("register '{}' set to '{}'", register, ®ex);
2117− match cx.editor.registers.push(register, regex) {
2118− Ok(_) => {
2119− cx.editor.registers.last_search_register = register;
2120− cx.editor.set_status(msg)
2121− }
2122− Err(err) => cx.editor.set_error(err.to_string()),
2123− }
1968+ let msg = format!("register '{}' set to '{}'", '/', ®ex);
1969+ cx.editor.registers.push('/', regex);
1970+ cx.editor.set_status(msg);
21241971}
21251972
21261973fn make_search_word_bounded(cx: &mut Context) {
2127− // Defaults to the active search register instead `/` to be more ergonomic assuming most people
2128− // would use this command following `search_selection`. This avoids selecting the register
2129− // twice.
2130− let register = cx
2131− .register
2132− .unwrap_or(cx.editor.registers.last_search_register);
2133− let regex = match cx.editor.registers.first(register, cx.editor) {
1974+ let regex = match cx.editor.registers.last('/') {
21341975 Some(regex) => regex,
21351976 None => return,
21361977 };
@@ -2148,19 +1989,14 @@ fn make_search_word_bounded(cx: &mut Context) {
21481989 if !start_anchored {
21491990 new_regex.push_str("\\b");
21501991 }
2151− new_regex.push_str(®ex);
1992+ new_regex.push_str(regex);
21521993 if !end_anchored {
21531994 new_regex.push_str("\\b");
21541995 }
21551996
2156− let msg = format!("register '{}' set to '{}'", register, &new_regex);
2157− match cx.editor.registers.push(register, new_regex) {
2158− Ok(_) => {
2159− cx.editor.registers.last_search_register = register;
2160− cx.editor.set_status(msg)
2161− }
2162− Err(err) => cx.editor.set_error(err.to_string()),
2163− }
1997+ let msg = format!("register '{}' set to '{}'", '/', &new_regex);
1998+ cx.editor.registers.push('/', new_regex);
1999+ cx.editor.set_status(msg);
21642000}
21652001
21662002fn global_search(cx: &mut Context) {
@@ -2199,11 +2035,13 @@ fn global_search(cx: &mut Context) {
21992035 }
22002036 }
22012037
2038+ let (all_matches_sx, all_matches_rx) = tokio::sync::mpsc::unbounded_channel::<FileResult>();
22022039 let config = cx.editor.config();
22032040 let smart_case = config.search.smart_case;
22042041 let file_picker_config = config.file_picker.clone();
22052042
22062043 let reg = cx.register.unwrap_or('/');
2044+
22072045 let completions = search_completions(cx, Some(reg));
22082046 ui::regex_prompt(
22092047 cx,
@@ -2216,67 +2054,43 @@ fn global_search(cx: &mut Context) {
22162054 .map(|comp| (0.., std::borrow::Cow::Owned(comp.clone())))
22172055 .collect()
22182056 },
2219− move |cx, regex, event| {
2057+ move |_editor, regex, event| {
22202058 if event != PromptEvent::Validate {
22212059 return;
22222060 }
2223− cx.editor.registers.last_search_register = reg;
2224−
2225− let current_path = doc_mut!(cx.editor).path().cloned();
2226− let documents: Vec<_> = cx
2227− .editor
2228− .documents()
2229− .map(|doc| (doc.path().cloned(), doc.text().to_owned()))
2230− .collect();
22312061
22322062 if let Ok(matcher) = RegexMatcherBuilder::new()
22332063 .case_smart(smart_case)
22342064 .build(regex.as_str())
22352065 {
2236− let search_root = helix_loader::current_working_dir();
2237− if !search_root.exists() {
2238− cx.editor
2239− .set_error("Current working directory does not exist");
2240− return;
2241− }
2242−
2243− let (picker, injector) = Picker::stream(current_path);
2066+ let searcher = SearcherBuilder::new()
2067+ .binary_detection(BinaryDetection::quit(b'\x00'))
2068+ .build();
22442069
2070+ let search_root = std::env::current_dir()
2071+ .expect("Global search error: Failed to get current dir");
22452072 let dedup_symlinks = file_picker_config.deduplicate_links;
22462073 let absolute_root = search_root
22472074 .canonicalize()
22482075 .unwrap_or_else(|_| search_root.clone());
2249− let injector_ = injector.clone();
2250−
2251− std::thread::spawn(move || {
2252− let searcher = SearcherBuilder::new()
2253− .binary_detection(BinaryDetection::quit(b'\x00'))
2254− .build();
2255−
2256− let mut walk_builder = WalkBuilder::new(search_root);
2257−
2258− walk_builder
2259− .hidden(file_picker_config.hidden)
2260− .parents(file_picker_config.parents)
2261− .ignore(file_picker_config.ignore)
2262− .follow_links(file_picker_config.follow_symlinks)
2263− .git_ignore(file_picker_config.git_ignore)
2264− .git_global(file_picker_config.git_global)
2265− .git_exclude(file_picker_config.git_exclude)
2266− .max_depth(file_picker_config.max_depth)
2267− .filter_entry(move |entry| {
2268− filter_picker_entry(entry, &absolute_root, dedup_symlinks)
2269− });
2270−
2271− walk_builder
2272− .add_custom_ignore_filename(helix_loader::config_dir().join("ignore"));
2273− walk_builder.add_custom_ignore_filename(".helix/ignore");
2274−
2275− walk_builder.build_parallel().run(|| {
2076+
2077+ WalkBuilder::new(search_root)
2078+ .hidden(file_picker_config.hidden)
2079+ .parents(file_picker_config.parents)
2080+ .ignore(file_picker_config.ignore)
2081+ .follow_links(file_picker_config.follow_symlinks)
2082+ .git_ignore(file_picker_config.git_ignore)
2083+ .git_global(file_picker_config.git_global)
2084+ .git_exclude(file_picker_config.git_exclude)
2085+ .max_depth(file_picker_config.max_depth)
2086+ .filter_entry(move |entry| {
2087+ filter_picker_entry(entry, &absolute_root, dedup_symlinks)
2088+ })
2089+ .build_parallel()
2090+ .run(|| {
22762091 let mut searcher = searcher.clone();
22772092 let matcher = matcher.clone();
2278− let injector = injector_.clone();
2279− let documents = &documents;
2093+ let all_matches_sx = all_matches_sx.clone();
22802094 Box::new(move |entry: Result<DirEntry, ignore::Error>| -> WalkState {
22812095 let entry = match entry {
22822096 Ok(entry) => entry,
@@ -2289,39 +2103,17 @@ fn global_search(cx: &mut Context) {
22892103 _ => return WalkState::Continue,
22902104 };
22912105
2292− let mut stop = false;
2293− let sink = sinks::UTF8(|line_num, _| {
2294− stop = injector
2295− .push(FileResult::new(entry.path(), line_num as usize - 1))
2296− .is_err();
2297−
2298− Ok(!stop)
2299− });
2300− let doc = documents.iter().find(|&(doc_path, _)| {
2301− doc_path
2302− .as_ref()
2303− .map_or(false, |doc_path| doc_path == entry.path())
2304− });
2305−
2306− let result = if let Some((_, doc)) = doc {
2307− // there is already a buffer for this file
2308− // search the buffer instead of the file because it's faster
2309− // and captures new edits without requiring a save
2310− if searcher.multi_line_with_matcher(&matcher) {
2311− // in this case a continous buffer is required
2312− // convert the rope to a string
2313− let text = doc.to_string();
2314− searcher.search_slice(&matcher, text.as_bytes(), sink)
2315− } else {
2316− searcher.search_reader(
2317− &matcher,
2318− RopeReader::new(doc.slice(..)),
2319− sink,
2320− )
2321− }
2322− } else {
2323− searcher.search_path(&matcher, entry.path(), sink)
2324− };
2106+ let result = searcher.search_path(
2107+ &matcher,
2108+ entry.path(),
2109+ sinks::UTF8(|line_num, _| {
2110+ all_matches_sx
2111+ .send(FileResult::new(entry.path(), line_num as usize - 1))
2112+ .unwrap();
2113+
2114+ Ok(true)
2115+ }),
2116+ );
23252117
23262118 if let Err(err) = result {
23272119 log::error!(
@@ -2330,66 +2122,67 @@ fn global_search(cx: &mut Context) {
23302122 err
23312123 );
23322124 }
2333− if stop {
2334− WalkState::Quit
2335− } else {
2336− WalkState::Continue
2337− }
2125+ WalkState::Continue
23382126 })
23392127 });
2340− });
2341−
2342− cx.jobs.callback(async move {
2343− let call = move |_: &mut Editor, compositor: &mut Compositor| {
2344− let picker = Picker::with_stream(
2345− picker,
2346− injector,
2347− move |cx, FileResult { path, line_num }, action| {
2348− let doc = match cx.editor.open(path, action) {
2349− Ok(id) => doc_mut!(cx.editor, &id),
2350− Err(e) => {
2351− cx.editor.set_error(format!(
2352− "Failed to open file '{}': {}",
2353− path.display(),
2354− e
2355− ));
2356− return;
2357− }
2358− };
2359−
2360− let line_num = *line_num;
2361− let view = view_mut!(cx.editor);
2362− let text = doc.text();
2363− if line_num >= text.len_lines() {
2364− cx.editor.set_error(
2365− "The line you jumped to does not exist anymore because the file has changed.",
2366− );
2367− return;
2368− }
2369− let start = text.line_to_char(line_num);
2370− let end = text.line_to_char((line_num + 1).min(text.len_lines()));
2371−
2372− doc.set_selection(view.id, Selection::single(start, end));
2373− if action.align_view(view, doc.id()) {
2374− align_view(doc, view, Align::Center);
2375− }
2376− },
2377− )
2378− .with_preview(
2379− |_editor, FileResult { path, line_num }| {
2380− Some((path.clone().into(), Some((*line_num, *line_num))))
2381− },
2382− );
2383− compositor.push(Box::new(overlaid(picker)))
2384− };
2385− Ok(Callback::EditorCompositor(Box::new(call)))
2386− })
23872128 } else {
23882129 // Otherwise do nothing
23892130 // log::warn!("Global Search Invalid Pattern")
23902131 }
23912132 },
23922133 );
2134+
2135+ let current_path = doc_mut!(cx.editor).path().cloned();
2136+
2137+ let show_picker = async move {
2138+ let all_matches: Vec<FileResult> =
2139+ UnboundedReceiverStream::new(all_matches_rx).collect().await;
2140+ let call: job::Callback = Callback::EditorCompositor(Box::new(
2141+ move |editor: &mut Editor, compositor: &mut Compositor| {
2142+ if all_matches.is_empty() {
2143+ editor.set_status("No matches found");
2144+ return;
2145+ }
2146+
2147+ let picker = FilePicker::new(
2148+ all_matches,
2149+ current_path,
2150+ move |cx, FileResult { path, line_num }, action| {
2151+ match cx.editor.open(path, action) {
2152+ Ok(_) => {}
2153+ Err(e) => {
2154+ cx.editor.set_error(format!(
2155+ "Failed to open file '{}': {}",
2156+ path.display(),
2157+ e
2158+ ));
2159+ return;
2160+ }
2161+ }
2162+
2163+ let line_num = *line_num;
2164+ let (view, doc) = current!(cx.editor);
2165+ let text = doc.text();
2166+ if line_num >= text.len_lines() {
2167+ cx.editor.set_error("The line you jumped to does not exist anymore because the file has changed.");
2168+ return;
2169+ }
2170+ let start = text.line_to_char(line_num);
2171+ let end = text.line_to_char((line_num + 1).min(text.len_lines()));
2172+
2173+ doc.set_selection(view.id, Selection::single(start, end));
2174+ align_view(doc, view, Align::Center);
2175+ },
2176+ |_editor, FileResult { path, line_num }| {
2177+ Some((path.clone().into(), Some((*line_num, *line_num))))
2178+ },
2179+ );
2180+ compositor.push(Box::new(overlaid(picker)));
2181+ },
2182+ ));
2183+ Ok(call)
2184+ };
2185+ cx.jobs.callback(show_picker);
23932186}
23942187
23952188enum Extend {
@@ -2512,35 +2305,17 @@ enum Operation {
25122305 Change,
25132306}
25142307
2515−fn selection_is_linewise(selection: &Selection, text: &Rope) -> bool {
2516− selection.ranges().iter().all(|range| {
2517− let text = text.slice(..);
2518− if range.slice(text).len_lines() < 2 {
2519− return false;
2520− }
2521− // If the start of the selection is at the start of a line and the end at the end of a line.
2522− let (start_line, end_line) = range.line_range(text);
2523− let start = text.line_to_char(start_line);
2524− let end = text.line_to_char((end_line + 1).min(text.len_lines()));
2525− start == range.from() && end == range.to()
2526− })
2527−}
2528−
25292308fn delete_selection_impl(cx: &mut Context, op: Operation) {
25302309 let (view, doc) = current!(cx.editor);
25312310
25322311 let selection = doc.selection(view.id);
2533− let only_whole_lines = selection_is_linewise(selection, doc.text());
25342312
25352313 if cx.register != Some('_') {
25362314 // first yank the selection
25372315 let text = doc.text().slice(..);
25382316 let values: Vec<String> = selection.fragments(text).map(Cow::into_owned).collect();
25392317 let reg_name = cx.register.unwrap_or('"');
2540− if let Err(err) = cx.editor.registers.write(reg_name, values) {
2541− cx.editor.set_error(err.to_string());
2542− return;
2543− }
2318+ cx.editor.registers.write(reg_name, values);
25442319 };
25452320
25462321 // then delete
@@ -2554,11 +2329,7 @@ fn delete_selection_impl(cx: &mut Context, op: Operation) {
25542329 exit_select_mode(cx);
25552330 }
25562331 Operation::Change => {
2557− if only_whole_lines {
2558− open_above(cx);
2559− } else {
2560− enter_insert_mode(cx);
2561− }
2332+ enter_insert_mode(cx);
25622333 }
25632334 }
25642335}
@@ -2680,10 +2451,6 @@ fn insert_mode(cx: &mut Context) {
26802451 .transform(|range| Range::new(range.to(), range.from()));
26812452
26822453 doc.set_selection(view.id, selection);
2683−
2684− // [TODO] temporary workaround until we're not using the idle timer to
2685− // trigger auto completions any more
2686− cx.editor.clear_idle_timer();
26872454}
26882455
26892456// inserts at the end of each selection
@@ -2720,10 +2487,6 @@ fn append_mode(cx: &mut Context) {
27202487
27212488fn file_picker(cx: &mut Context) {
27222489 let root = find_workspace().0;
2723− if !root.exists() {
2724− cx.editor.set_error("Workspace directory does not exist");
2725− return;
2726− }
27272490 let picker = ui::file_picker(root, &cx.editor.config());
27282491 cx.push_layer(Box::new(overlaid(picker)));
27292492}
@@ -2744,14 +2507,8 @@ fn file_picker_in_current_buffer_directory(cx: &mut Context) {
27442507 let picker = ui::file_picker(path, &cx.editor.config());
27452508 cx.push_layer(Box::new(overlaid(picker)));
27462509}
2747−
27482510fn file_picker_in_current_directory(cx: &mut Context) {
2749− let cwd = helix_loader::current_working_dir();
2750− if !cwd.exists() {
2751− cx.editor
2752− .set_error("Current working directory does not exist");
2753− return;
2754− }
2511+ let cwd = std::env::current_dir().unwrap_or_else(|_| PathBuf::from("./"));
27552512 let picker = ui::file_picker(cwd, &cx.editor.config());
27562513 cx.push_layer(Box::new(overlaid(picker)));
27572514}
@@ -2810,18 +2567,22 @@ fn buffer_picker(cx: &mut Context) {
28102567 // mru
28112568 items.sort_unstable_by_key(|item| std::cmp::Reverse(item.focused_at));
28122569
2813− let picker = Picker::new(items, (), |cx, meta, action| {
2814− cx.editor.switch(meta.id, action);
2815− })
2816− .with_preview(|editor, meta| {
2817− let doc = &editor.documents.get(&meta.id)?;
2818− let &view_id = doc.selections().keys().next()?;
2819− let line = doc
2820− .selection(view_id)
2821− .primary()
2822− .cursor_line(doc.text().slice(..));
2823− Some((meta.id.into(), Some((line, line))))
2824− });
2570+ let picker = FilePicker::new(
2571+ items,
2572+ (),
2573+ |cx, meta, action| {
2574+ cx.editor.switch(meta.id, action);
2575+ },
2576+ |editor, meta| {
2577+ let doc = &editor.documents.get(&meta.id)?;
2578+ let &view_id = doc.selections().keys().next()?;
2579+ let line = doc
2580+ .selection(view_id)
2581+ .primary()
2582+ .cursor_line(doc.text().slice(..));
2583+ Some((meta.id.into(), Some((line, line))))
2584+ },
2585+ );
28252586 cx.push_layer(Box::new(overlaid(picker)));
28262587}
28272588
@@ -2887,7 +2648,7 @@ fn jumplist_picker(cx: &mut Context) {
28872648 }
28882649 };
28892650
2890− let picker = Picker::new(
2651+ let picker = FilePicker::new(
28912652 cx.editor
28922653 .tree
28932654 .views()
@@ -2901,18 +2662,16 @@ fn jumplist_picker(cx: &mut Context) {
29012662 |cx, meta, action| {
29022663 cx.editor.switch(meta.id, action);
29032664 let config = cx.editor.config();
2904− let (view, doc) = (view_mut!(cx.editor), doc_mut!(cx.editor, &meta.id));
2665+ let (view, doc) = current!(cx.editor);
29052666 doc.set_selection(view.id, meta.selection.clone());
2906− if action.align_view(view, doc.id()) {
2907− view.ensure_cursor_in_view_center(doc, config.scrolloff);
2908− }
2667+ view.ensure_cursor_in_view_center(doc, config.scrolloff);
29092668 },
2910− )
2911− .with_preview(|editor, meta| {
2912− let doc = &editor.documents.get(&meta.id)?;
2913− let line = meta.selection.primary().cursor_line(doc.text().slice(..));
2914− Some((meta.id.into(), Some((line, line))))
2915− });
2669+ |editor, meta| {
2670+ let doc = &editor.documents.get(&meta.id)?;
2671+ let line = meta.selection.primary().cursor_line(doc.text().slice(..));
2672+ Some((meta.path.clone()?.into(), Some((line, line))))
2673+ },
2674+ );
29162675 cx.push_layer(Box::new(overlaid(picker)));
29172676}
29182677
@@ -2946,9 +2705,6 @@ impl ui::menu::Item for MappableCommand {
29462705}
29472706
29482707pub fn command_palette(cx: &mut Context) {
2949− let register = cx.register;
2950− let count = cx.count;
2951−
29522708 cx.callback = Some(Box::new(
29532709 move |compositor: &mut Compositor, cx: &mut compositor::Context| {
29542710 let keymap = compositor.find::<ui::EditorView>().unwrap().keymaps.map()
@@ -2966,8 +2722,8 @@ pub fn command_palette(cx: &mut Context) {
29662722
29672723 let picker = Picker::new(commands, keymap, move |cx, command, _action| {
29682724 let mut ctx = Context {
2969− register,
2970− count,
2725+ register: None,
2726+ count: std::num::NonZeroUsize::new(1),
29712727 editor: cx.editor,
29722728 callback: None,
29732729 on_next_key_callback: None,
@@ -3006,88 +2762,24 @@ fn last_picker(cx: &mut Context) {
30062762 }));
30072763}
30082764
3009−/// Fallback position to use for [`insert_with_indent`].
3010−enum IndentFallbackPos {
3011− LineStart,
3012− LineEnd,
3013−}
3014−
3015−// `I` inserts at the first nonwhitespace character of each line with a selection.
3016−// If the line is empty, automatically indent.
2765+// I inserts at the first nonwhitespace character of each line with a selection
30172766fn insert_at_line_start(cx: &mut Context) {
3018− insert_with_indent(cx, IndentFallbackPos::LineStart);
2767+ goto_first_nonwhitespace(cx);
2768+ enter_insert_mode(cx);
30192769}
30202770
3021−// `A` inserts at the end of each line with a selection.
3022−// If the line is empty, automatically indent.
2771+// A inserts at the end of each line with a selection
30232772fn insert_at_line_end(cx: &mut Context) {
3024− insert_with_indent(cx, IndentFallbackPos::LineEnd);
3025−}
3026−
3027−// Enter insert mode and auto-indent the current line if it is empty.
3028−// If the line is not empty, move the cursor to the specified fallback position.
3029−fn insert_with_indent(cx: &mut Context, cursor_fallback: IndentFallbackPos) {
30302773 enter_insert_mode(cx);
3031−
30322774 let (view, doc) = current!(cx.editor);
30332775
3034− let text = doc.text().slice(..);
3035− let contents = doc.text();
3036− let selection = doc.selection(view.id);
3037−
3038− let language_config = doc.language_config();
3039− let syntax = doc.syntax();
3040− let tab_width = doc.tab_width();
3041−
3042− let mut ranges = SmallVec::with_capacity(selection.len());
3043− let mut offs = 0;
3044−
3045− let mut transaction = Transaction::change_by_selection(contents, selection, |range| {
3046− let cursor_line = range.cursor_line(text);
3047− let cursor_line_start = text.line_to_char(cursor_line);
3048−
3049− if line_end_char_index(&text, cursor_line) == cursor_line_start {
3050− // line is empty => auto indent
3051− let line_end_index = cursor_line_start;
3052−
3053− let indent = indent::indent_for_newline(
3054− language_config,
3055− syntax,
3056− &doc.config.load().indent_heuristic,
3057− &doc.indent_style,
3058− tab_width,
3059− text,
3060− cursor_line,
3061− line_end_index,
3062− cursor_line,
3063− );
3064−
3065− // calculate new selection ranges
3066− let pos = offs + cursor_line_start;
3067− let indent_width = indent.chars().count();
3068− ranges.push(Range::point(pos + indent_width));
3069− offs += indent_width;
3070−
3071− (line_end_index, line_end_index, Some(indent.into()))
3072− } else {
3073− // move cursor to the fallback position
3074− let pos = match cursor_fallback {
3075− IndentFallbackPos::LineStart => {
3076− find_first_non_whitespace_char(text.line(cursor_line))
3077− .map(|ws_offset| ws_offset + cursor_line_start)
3078− .unwrap_or(cursor_line_start)
3079− }
3080− IndentFallbackPos::LineEnd => line_end_char_index(&text, cursor_line),
3081− };
3082−
3083− ranges.push(range.put_cursor(text, pos + offs, cx.editor.mode == Mode::Select));
3084−
3085− (cursor_line_start, cursor_line_start, None)
3086− }
2776+ let selection = doc.selection(view.id).clone().transform(|range| {
2777+ let text = doc.text().slice(..);
2778+ let line = range.cursor_line(text);
2779+ let pos = line_end_char_index(&text, line);
2780+ Range::new(pos, pos)
30872781 });
3088−
3089− transaction = transaction.with_selection(Selection::new(ranges, selection.primary_index()));
3090− doc.apply(&transaction, view.id);
2782+ doc.set_selection(view.id, selection);
30912783}
30922784
30932785// Creates an LspCallback that waits for formatting changes to be computed. When they're done,
@@ -3158,7 +2850,6 @@ fn open(cx: &mut Context, open: Open) {
31582850 Open::Below => graphemes::prev_grapheme_boundary(text, range.to()),
31592851 Open::Above => range.from(),
31602852 });
3161−
31622853 let new_line = match open {
31632854 // adjust position to the end of the line (next line - 1)
31642855 Open::Below => cursor_line + 1,
@@ -3166,15 +2857,13 @@ fn open(cx: &mut Context, open: Open) {
31662857 Open::Above => cursor_line,
31672858 };
31682859
3169− let line_num = new_line.saturating_sub(1);
3170−
31712860 // Index to insert newlines after, as well as the char width
31722861 // to use to compensate for those inserted newlines.
31732862 let (line_end_index, line_end_offset_width) = if new_line == 0 {
31742863 (0, 0)
31752864 } else {
31762865 (
3177− line_end_char_index(&text, line_num),
2866+ line_end_char_index(&doc.text().slice(..), new_line.saturating_sub(1)),
31782867 doc.line_ending.len_chars(),
31792868 )
31802869 };
@@ -3182,15 +2871,13 @@ fn open(cx: &mut Context, open: Open) {
31822871 let indent = indent::indent_for_newline(
31832872 doc.language_config(),
31842873 doc.syntax(),
3185− &doc.config.load().indent_heuristic,
31862874 &doc.indent_style,
31872875 doc.tab_width(),
31882876 text,
3189− line_num,
2877+ new_line.saturating_sub(1),
31902878 line_end_index,
31912879 cursor_line,
31922880 );
3193−
31942881 let indent_len = indent.len();
31952882 let mut text = String::with_capacity(1 + indent_len);
31962883 text.push_str(doc.line_ending.as_str());
@@ -3489,7 +3176,8 @@ fn goto_next_change_impl(cx: &mut Context, direction: Direction) {
34893176
34903177 doc.set_selection(view.id, selection)
34913178 };
3492− cx.editor.apply_motion(motion);
3179+ motion(cx.editor);
3180+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
34933181}
34943182
34953183/// Returns the [Range] for a [Hunk] in the given text.
@@ -3616,7 +3304,6 @@ pub mod insert {
36163304 }
36173305
36183306 use helix_core::auto_pairs;
3619− use helix_view::editor::SmartTabConfig;
36203307
36213308 pub fn insert_char(cx: &mut Context, c: char) {
36223309 let (view, doc) = current_ref!(cx.editor);
@@ -3642,31 +3329,6 @@ pub mod insert {
36423329 }
36433330 }
36443331
3645− pub fn smart_tab(cx: &mut Context) {
3646− let (view, doc) = current_ref!(cx.editor);
3647− let view_id = view.id;
3648−
3649− if matches!(
3650− cx.editor.config().smart_tab,
3651− Some(SmartTabConfig { enable: true, .. })
3652− ) {
3653− let cursors_after_whitespace = doc.selection(view_id).ranges().iter().all(|range| {
3654− let cursor = range.cursor(doc.text().slice(..));
3655− let current_line_num = doc.text().char_to_line(cursor);
3656− let current_line_start = doc.text().line_to_char(current_line_num);
3657− let left = doc.text().slice(current_line_start..cursor);
3658− left.chars().all(|c| c.is_whitespace())
3659− });
3660−
3661− if !cursors_after_whitespace {
3662− move_parent_node_end(cx);
3663− return;
3664− }
3665− }
3666−
3667− insert_tab(cx);
3668− }
3669−
36703332 pub fn insert_tab(cx: &mut Context) {
36713333 let (view, doc) = current!(cx.editor);
36723334 // TODO: round out to nearest indentation level (for example a line with 3 spaces should
@@ -3722,7 +3384,6 @@ pub mod insert {
37223384 let indent = indent::indent_for_newline(
37233385 doc.language_config(),
37243386 doc.syntax(),
3725− &doc.config.load().indent_heuristic,
37263387 &doc.indent_style,
37273388 doc.tab_width(),
37283389 text,
@@ -3963,21 +3624,34 @@ fn commit_undo_checkpoint(cx: &mut Context) {
39633624// Yank / Paste
39643625
39653626fn yank(cx: &mut Context) {
3966− yank_impl(cx.editor, cx.register.unwrap_or('"'));
3967− exit_select_mode(cx);
3968−}
3627+ let (view, doc) = current!(cx.editor);
3628+ let text = doc.text().slice(..);
39693629
3970−fn yank_to_clipboard(cx: &mut Context) {
3971− yank_impl(cx.editor, '+');
3972− exit_select_mode(cx);
3973−}
3630+ let values: Vec<String> = doc
3631+ .selection(view.id)
3632+ .fragments(text)
3633+ .map(Cow::into_owned)
3634+ .collect();
39743635
3975−fn yank_to_primary_clipboard(cx: &mut Context) {
3976− yank_impl(cx.editor, '*');
3636+ let msg = format!(
3637+ "yanked {} selection(s) to register {}",
3638+ values.len(),
3639+ cx.register.unwrap_or('"')
3640+ );
3641+
3642+ cx.editor
3643+ .registers
3644+ .write(cx.register.unwrap_or('"'), values);
3645+
3646+ cx.editor.set_status(msg);
39773647 exit_select_mode(cx);
39783648}
39793649
3980−fn yank_impl(editor: &mut Editor, register: char) {
3650+fn yank_joined_to_clipboard_impl(
3651+ editor: &mut Editor,
3652+ separator: &str,
3653+ clipboard_type: ClipboardType,
3654+) -> anyhow::Result<()> {
39813655 let (view, doc) = current!(editor);
39823656 let text = doc.text().slice(..);
39833657
@@ -3986,79 +3660,74 @@ fn yank_impl(editor: &mut Editor, register: char) {
39863660 .fragments(text)
39873661 .map(Cow::into_owned)
39883662 .collect();
3989− let selections = values.len();
39903663
3991− match editor.registers.write(register, values) {
3992− Ok(_) => editor.set_status(format!(
3993− "yanked {selections} selection{} to register {register}",
3994− if selections == 1 { "" } else { "s" }
3995− )),
3996− Err(err) => editor.set_error(err.to_string()),
3997− }
3998−}
3664+ let clipboard_text = match clipboard_type {
3665+ ClipboardType::Clipboard => "system clipboard",
3666+ ClipboardType::Selection => "primary clipboard",
3667+ };
39993668
4000−fn yank_joined_impl(editor: &mut Editor, separator: &str, register: char) {
4001− let (view, doc) = current!(editor);
4002− let text = doc.text().slice(..);
3669+ let msg = format!(
3670+ "joined and yanked {} selection(s) to {}",
3671+ values.len(),
3672+ clipboard_text,
3673+ );
40033674
4004− let selection = doc.selection(view.id);
4005− let selections = selection.len();
4006− let joined = selection
4007− .fragments(text)
4008− .fold(String::new(), |mut acc, fragment| {
4009− if !acc.is_empty() {
4010− acc.push_str(separator);
4011− }
4012− acc.push_str(&fragment);
4013− acc
4014− });
3675+ let joined = values.join(separator);
40153676
4016− match editor.registers.write(register, vec![joined]) {
4017− Ok(_) => editor.set_status(format!(
4018− "joined and yanked {selections} selection{} to register {register}",
4019− if selections == 1 { "" } else { "s" }
4020− )),
4021− Err(err) => editor.set_error(err.to_string()),
4022− }
4023−}
3677+ editor
3678+ .clipboard_provider
3679+ .set_contents(joined, clipboard_type)
3680+ .context("Couldn't set system clipboard content")?;
40243681
4025−fn yank_joined(cx: &mut Context) {
4026− let separator = doc!(cx.editor).line_ending.as_str();
4027− yank_joined_impl(cx.editor, separator, cx.register.unwrap_or('"'));
4028− exit_select_mode(cx);
4029−}
3682+ editor.set_status(msg);
40303683
4031−fn yank_joined_to_clipboard(cx: &mut Context) {
4032− let line_ending = doc!(cx.editor).line_ending;
4033− yank_joined_impl(cx.editor, line_ending.as_str(), '+');
4034− exit_select_mode(cx);
3684+ Ok(())
40353685}
40363686
4037−fn yank_joined_to_primary_clipboard(cx: &mut Context) {
3687+fn yank_joined_to_clipboard(cx: &mut Context) {
40383688 let line_ending = doc!(cx.editor).line_ending;
4039− yank_joined_impl(cx.editor, line_ending.as_str(), '*');
3689+ let _ =
3690+ yank_joined_to_clipboard_impl(cx.editor, line_ending.as_str(), ClipboardType::Clipboard);
40403691 exit_select_mode(cx);
40413692}
40423693
4043−fn yank_primary_selection_impl(editor: &mut Editor, register: char) {
3694+fn yank_main_selection_to_clipboard_impl(
3695+ editor: &mut Editor,
3696+ clipboard_type: ClipboardType,
3697+) -> anyhow::Result<()> {
40443698 let (view, doc) = current!(editor);
40453699 let text = doc.text().slice(..);
40463700
4047− let selection = doc.selection(view.id).primary().fragment(text).to_string();
3701+ let message_text = match clipboard_type {
3702+ ClipboardType::Clipboard => "yanked main selection to system clipboard",
3703+ ClipboardType::Selection => "yanked main selection to primary clipboard",
3704+ };
3705+
3706+ let value = doc.selection(view.id).primary().fragment(text);
40483707
4049− match editor.registers.write(register, vec![selection]) {
4050− Ok(_) => editor.set_status(format!("yanked primary selection to register {register}",)),
4051− Err(err) => editor.set_error(err.to_string()),
3708+ if let Err(e) = editor
3709+ .clipboard_provider
3710+ .set_contents(value.into_owned(), clipboard_type)
3711+ {
3712+ bail!("Couldn't set system clipboard content: {}", e);
40523713 }
3714+
3715+ editor.set_status(message_text);
3716+ Ok(())
40533717}
40543718
40553719fn yank_main_selection_to_clipboard(cx: &mut Context) {
4056− yank_primary_selection_impl(cx.editor, '+');
4057− exit_select_mode(cx);
3720+ let _ = yank_main_selection_to_clipboard_impl(cx.editor, ClipboardType::Clipboard);
3721+}
3722+
3723+fn yank_joined_to_primary_clipboard(cx: &mut Context) {
3724+ let line_ending = doc!(cx.editor).line_ending;
3725+ let _ =
3726+ yank_joined_to_clipboard_impl(cx.editor, line_ending.as_str(), ClipboardType::Selection);
40583727}
40593728
40603729fn yank_main_selection_to_primary_clipboard(cx: &mut Context) {
4061− yank_primary_selection_impl(cx.editor, '*');
3730+ let _ = yank_main_selection_to_clipboard_impl(cx.editor, ClipboardType::Selection);
40623731 exit_select_mode(cx);
40633732}
40643733
@@ -4156,99 +3825,146 @@ pub(crate) fn paste_bracketed_value(cx: &mut Context, contents: String) {
41563825 };
41573826 let (view, doc) = current!(cx.editor);
41583827 paste_impl(&[contents], doc, view, paste, count, cx.editor.mode);
4159− exit_select_mode(cx);
3828+}
3829+
3830+fn paste_clipboard_impl(
3831+ editor: &mut Editor,
3832+ action: Paste,
3833+ clipboard_type: ClipboardType,
3834+ count: usize,
3835+) -> anyhow::Result<()> {
3836+ let (view, doc) = current!(editor);
3837+ match editor.clipboard_provider.get_contents(clipboard_type) {
3838+ Ok(contents) => {
3839+ paste_impl(&[contents], doc, view, action, count, editor.mode);
3840+ Ok(())
3841+ }
3842+ Err(e) => Err(e.context("Couldn't get system clipboard contents")),
3843+ }
41603844}
41613845
41623846fn paste_clipboard_after(cx: &mut Context) {
4163− paste(cx.editor, '+', Paste::After, cx.count());
4164− exit_select_mode(cx);
3847+ let _ = paste_clipboard_impl(
3848+ cx.editor,
3849+ Paste::After,
3850+ ClipboardType::Clipboard,
3851+ cx.count(),
3852+ );
41653853}
41663854
41673855fn paste_clipboard_before(cx: &mut Context) {
4168− paste(cx.editor, '+', Paste::Before, cx.count());
4169− exit_select_mode(cx);
3856+ let _ = paste_clipboard_impl(
3857+ cx.editor,
3858+ Paste::Before,
3859+ ClipboardType::Clipboard,
3860+ cx.count(),
3861+ );
41703862}
41713863
41723864fn paste_primary_clipboard_after(cx: &mut Context) {
4173− paste(cx.editor, '*', Paste::After, cx.count());
4174− exit_select_mode(cx);
3865+ let _ = paste_clipboard_impl(
3866+ cx.editor,
3867+ Paste::After,
3868+ ClipboardType::Selection,
3869+ cx.count(),
3870+ );
41753871}
41763872
41773873fn paste_primary_clipboard_before(cx: &mut Context) {
4178− paste(cx.editor, '*', Paste::Before, cx.count());
4179− exit_select_mode(cx);
3874+ let _ = paste_clipboard_impl(
3875+ cx.editor,
3876+ Paste::Before,
3877+ ClipboardType::Selection,
3878+ cx.count(),
3879+ );
41803880}
41813881
41823882fn replace_with_yanked(cx: &mut Context) {
4183− replace_with_yanked_impl(cx.editor, cx.register.unwrap_or('"'), cx.count());
4184− exit_select_mode(cx);
3883+ let count = cx.count();
3884+ let reg_name = cx.register.unwrap_or('"');
3885+ let (view, doc) = current!(cx.editor);
3886+ let registers = &mut cx.editor.registers;
3887+
3888+ if let Some(values) = registers.read(reg_name) {
3889+ if !values.is_empty() {
3890+ let repeat = std::iter::repeat(
3891+ values
3892+ .last()
3893+ .map(|value| Tendril::from(&value.repeat(count)))
3894+ .unwrap(),
3895+ );
3896+ let mut values = values
3897+ .iter()
3898+ .map(|value| Tendril::from(&value.repeat(count)))
3899+ .chain(repeat);
3900+ let selection = doc.selection(view.id);
3901+ let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
3902+ if !range.is_empty() {
3903+ (range.from(), range.to(), Some(values.next().unwrap()))
3904+ } else {
3905+ (range.from(), range.to(), None)
3906+ }
3907+ });
3908+
3909+ doc.apply(&transaction, view.id);
3910+ exit_select_mode(cx);
3911+ }
3912+ }
41853913}
41863914
4187−fn replace_with_yanked_impl(editor: &mut Editor, register: char, count: usize) {
4188− let Some(values) = editor.registers
4189− .read(register, editor)
4190− .filter(|values| values.len() > 0) else { return };
4191− let values: Vec<_> = values.map(|value| value.to_string()).collect();
3915+fn replace_selections_with_clipboard_impl(
3916+ cx: &mut Context,
3917+ clipboard_type: ClipboardType,
3918+) -> anyhow::Result<()> {
3919+ let count = cx.count();
3920+ let (view, doc) = current!(cx.editor);
41923921
4193− let (view, doc) = current!(editor);
4194− let repeat = std::iter::repeat(
4195− values
4196− .last()
4197− .map(|value| Tendril::from(&value.repeat(count)))
4198− .unwrap(),
4199− );
4200− let mut values = values
4201− .iter()
4202− .map(|value| Tendril::from(&value.repeat(count)))
4203− .chain(repeat);
4204− let selection = doc.selection(view.id);
4205− let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
4206− if !range.is_empty() {
4207− (range.from(), range.to(), Some(values.next().unwrap()))
4208− } else {
4209− (range.from(), range.to(), None)
3922+ match cx.editor.clipboard_provider.get_contents(clipboard_type) {
3923+ Ok(contents) => {
3924+ let selection = doc.selection(view.id);
3925+ let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
3926+ (
3927+ range.from(),
3928+ range.to(),
3929+ Some(contents.repeat(count).as_str().into()),
3930+ )
3931+ });
3932+
3933+ doc.apply(&transaction, view.id);
3934+ doc.append_changes_to_history(view);
42103935 }
4211− });
3936+ Err(e) => return Err(e.context("Couldn't get system clipboard contents")),
3937+ }
42123938
4213− doc.apply(&transaction, view.id);
3939+ exit_select_mode(cx);
3940+ Ok(())
42143941}
42153942
42163943fn replace_selections_with_clipboard(cx: &mut Context) {
4217− replace_with_yanked_impl(cx.editor, '+', cx.count());
4218− exit_select_mode(cx);
3944+ let _ = replace_selections_with_clipboard_impl(cx, ClipboardType::Clipboard);
42193945}
42203946
42213947fn replace_selections_with_primary_clipboard(cx: &mut Context) {
4222− replace_with_yanked_impl(cx.editor, '*', cx.count());
4223− exit_select_mode(cx);
3948+ let _ = replace_selections_with_clipboard_impl(cx, ClipboardType::Selection);
42243949}
42253950
4226−fn paste(editor: &mut Editor, register: char, pos: Paste, count: usize) {
4227− let Some(values) = editor.registers.read(register, editor) else { return };
4228− let values: Vec<_> = values.map(|value| value.to_string()).collect();
3951+fn paste(cx: &mut Context, pos: Paste) {
3952+ let count = cx.count();
3953+ let reg_name = cx.register.unwrap_or('"');
3954+ let (view, doc) = current!(cx.editor);
3955+ let registers = &mut cx.editor.registers;
42293956
4230− let (view, doc) = current!(editor);
4231− paste_impl(&values, doc, view, pos, count, editor.mode);
3957+ if let Some(values) = registers.read(reg_name) {
3958+ paste_impl(values, doc, view, pos, count, cx.editor.mode);
3959+ }
42323960}
42333961
42343962fn paste_after(cx: &mut Context) {
4235− paste(
4236− cx.editor,
4237− cx.register.unwrap_or('"'),
4238− Paste::After,
4239− cx.count(),
4240− );
4241− exit_select_mode(cx);
3963+ paste(cx, Paste::After)
42423964}
42433965
42443966fn paste_before(cx: &mut Context) {
4245− paste(
4246− cx.editor,
4247− cx.register.unwrap_or('"'),
4248− Paste::Before,
4249− cx.count(),
4250− );
4251− exit_select_mode(cx);
3967+ paste(cx, Paste::Before)
42523968}
42533969
42543970fn get_lines(doc: &Document, view_id: ViewId) -> Vec<usize> {
@@ -4287,7 +4003,6 @@ fn indent(cx: &mut Context) {
42874003 }),
42884004 );
42894005 doc.apply(&transaction, view.id);
4290− exit_select_mode(cx);
42914006}
42924007
42934008fn unindent(cx: &mut Context) {
@@ -4327,7 +4042,6 @@ fn unindent(cx: &mut Context) {
43274042 let transaction = Transaction::change(doc.text(), changes.into_iter());
43284043
43294044 doc.apply(&transaction, view.id);
4330− exit_select_mode(cx);
43314045}
43324046
43334047fn format_selections(cx: &mut Context) {
@@ -4357,7 +4071,7 @@ fn format_selections(cx: &mut Context) {
43574071 })
43584072 else {
43594073 cx.editor
4360− .set_error("No configured language server supports range formatting");
4074+ .set_error("No configured language server does not support range formatting");
43614075 return;
43624076 };
43634077
@@ -4394,9 +4108,10 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
43944108 use movement::skip_while;
43954109 let (view, doc) = current!(cx.editor);
43964110 let text = doc.text();
4397− let slice = text.slice(..);
4111+ let slice = doc.text().slice(..);
43984112
43994113 let mut changes = Vec::new();
4114+ let fragment = Tendril::from(" ");
44004115
44014116 for selection in doc.selection(view.id) {
44024117 let (start, mut end) = selection.line_range(slice);
@@ -4412,13 +4127,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44124127 let mut end = text.line_to_char(line + 1);
44134128 end = skip_while(slice, end, |ch| matches!(ch, ' ' | '\t')).unwrap_or(end);
44144129
4415− let separator = if end == line_end_char_index(&slice, line + 1) {
4416− // the joining line contains only space-characters => don't include a whitespace when joining
4417− None
4418− } else {
4419− Some(Tendril::from(" "))
4420− };
4421− changes.push((start, end, separator));
4130+ // need to skip from start, not end
4131+ let change = (start, end, Some(fragment.clone()));
4132+ changes.push(change);
44224133 }
44234134 }
44244135
@@ -4430,6 +4141,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44304141 changes.sort_unstable_by_key(|(from, _to, _text)| *from);
44314142 changes.dedup();
44324143
4144+ // TODO: joining multiple empty lines should be replaced by a single space.
4145+ // need to merge change ranges that touch
4146+
44334147 // select inserted spaces
44344148 let transaction = if select_space {
44354149 let ranges: SmallVec<_> = changes
@@ -4441,9 +4155,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44414155 })
44424156 .collect();
44434157 let selection = Selection::new(ranges, 0);
4444− Transaction::change(text, changes.into_iter()).with_selection(selection)
4158+ Transaction::change(doc.text(), changes.into_iter()).with_selection(selection)
44454159 } else {
4446− Transaction::change(text, changes.into_iter())
4160+ Transaction::change(doc.text(), changes.into_iter())
44474161 };
44484162
44494163 doc.apply(&transaction, view.id);
@@ -4457,8 +4171,8 @@ fn keep_or_remove_selections_impl(cx: &mut Context, remove: bool) {
44574171 if remove { "remove:" } else { "keep:" }.into(),
44584172 Some(reg),
44594173 ui::completers::none,
4460− move |cx, regex, event| {
4461− let (view, doc) = current!(cx.editor);
4174+ move |editor, regex, event| {
4175+ let (view, doc) = current!(editor);
44624176 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
44634177 return;
44644178 }
@@ -4692,13 +4406,7 @@ fn rotate_selections_backward(cx: &mut Context) {
46924406 rotate_selections(cx, Direction::Backward)
46934407}
46944408
4695−enum ReorderStrategy {
4696− RotateForward,
4697− RotateBackward,
4698− Reverse,
4699−}
4700−
4701−fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
4409+fn rotate_selection_contents(cx: &mut Context, direction: Direction) {
47024410 let count = cx.count;
47034411 let (view, doc) = current!(cx.editor);
47044412 let text = doc.text().slice(..);
@@ -4716,10 +4424,9 @@ fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
47164424
47174425 for chunk in fragments.chunks_mut(group) {
47184426 // TODO: also modify main index
4719− match strategy {
4720− ReorderStrategy::RotateForward => chunk.rotate_right(1),
4721− ReorderStrategy::RotateBackward => chunk.rotate_left(1),
4722− ReorderStrategy::Reverse => chunk.reverse(),
4427+ match direction {
4428+ Direction::Forward => chunk.rotate_right(1),
4429+ Direction::Backward => chunk.rotate_left(1),
47234430 };
47244431 }
47254432
@@ -4736,13 +4443,10 @@ fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
47364443}
47374444
47384445fn rotate_selection_contents_forward(cx: &mut Context) {
4739− reorder_selection_contents(cx, ReorderStrategy::RotateForward)
4446+ rotate_selection_contents(cx, Direction::Forward)
47404447}
47414448fn rotate_selection_contents_backward(cx: &mut Context) {
4742− reorder_selection_contents(cx, ReorderStrategy::RotateBackward)
4743−}
4744−fn reverse_selection_contents(cx: &mut Context) {
4745− reorder_selection_contents(cx, ReorderStrategy::Reverse)
4449+ rotate_selection_contents(cx, Direction::Backward)
47464450}
47474451
47484452// tree sitter node selection
@@ -4766,7 +4470,8 @@ fn expand_selection(cx: &mut Context) {
47664470 }
47674471 }
47684472 };
4769− cx.editor.apply_motion(motion);
4473+ motion(cx.editor);
4474+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
47704475}
47714476
47724477fn shrink_selection(cx: &mut Context) {
@@ -4790,7 +4495,8 @@ fn shrink_selection(cx: &mut Context) {
47904495 doc.set_selection(view.id, selection);
47914496 }
47924497 };
4793− cx.editor.apply_motion(motion);
4498+ motion(cx.editor);
4499+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
47944500}
47954501
47964502fn select_sibling_impl<F>(cx: &mut Context, sibling_fn: &'static F)
@@ -4808,7 +4514,8 @@ where
48084514 doc.set_selection(view.id, selection);
48094515 }
48104516 };
4811− cx.editor.apply_motion(motion);
4517+ motion(cx.editor);
4518+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
48124519}
48134520
48144521fn select_next_sibling(cx: &mut Context) {
@@ -4819,68 +4526,22 @@ fn select_prev_sibling(cx: &mut Context) {
48194526 select_sibling_impl(cx, &|node| Node::prev_sibling(&node))
48204527}
48214528
4822−fn move_node_bound_impl(cx: &mut Context, dir: Direction, movement: Movement) {
4823− let motion = move |editor: &mut Editor| {
4824− let (view, doc) = current!(editor);
4825−
4826− if let Some(syntax) = doc.syntax() {
4827− let text = doc.text().slice(..);
4828− let current_selection = doc.selection(view.id);
4829−
4830− let selection = movement::move_parent_node_end(
4831− syntax,
4832− text,
4833− current_selection.clone(),
4834− dir,
4835− movement,
4836− );
4837−
4838− doc.set_selection(view.id, selection);
4839−
4840− // [TODO] temporary workaround until we're not using the idle timer to
4841− // trigger auto completions any more
4842− editor.clear_idle_timer();
4843− }
4844− };
4845−
4846− cx.editor.apply_motion(motion);
4847−}
4848−
4849−pub fn move_parent_node_end(cx: &mut Context) {
4850− move_node_bound_impl(cx, Direction::Forward, Movement::Move)
4851−}
4852−
4853−pub fn move_parent_node_start(cx: &mut Context) {
4854− move_node_bound_impl(cx, Direction::Backward, Movement::Move)
4855−}
4856−
4857−pub fn extend_parent_node_end(cx: &mut Context) {
4858− move_node_bound_impl(cx, Direction::Forward, Movement::Extend)
4859−}
4860−
4861−pub fn extend_parent_node_start(cx: &mut Context) {
4862− move_node_bound_impl(cx, Direction::Backward, Movement::Extend)
4863−}
4864−
48654529fn match_brackets(cx: &mut Context) {
48664530 let (view, doc) = current!(cx.editor);
4867− let is_select = cx.editor.mode == Mode::Select;
4868− let text = doc.text();
4869− let text_slice = text.slice(..);
4870−
4871− let selection = doc.selection(view.id).clone().transform(|range| {
4872− let pos = range.cursor(text_slice);
4873− if let Some(matched_pos) = doc.syntax().map_or_else(
4874− || match_brackets::find_matching_bracket_plaintext(text.slice(..), pos),
4875− |syntax| match_brackets::find_matching_bracket_fuzzy(syntax, text.slice(..), pos),
4876− ) {
4877− range.put_cursor(text_slice, matched_pos, is_select)
4878− } else {
4879− range
4880− }
4881− });
48824531
4883− doc.set_selection(view.id, selection);
4532+ if let Some(syntax) = doc.syntax() {
4533+ let text = doc.text().slice(..);
4534+ let selection = doc.selection(view.id).clone().transform(|range| {
4535+ if let Some(pos) =
4536+ match_brackets::find_matching_bracket_fuzzy(syntax, doc.text(), range.cursor(text))
4537+ {
4538+ range.put_cursor(text, pos, cx.editor.mode == Mode::Select)
4539+ } else {
4540+ range
4541+ }
4542+ });
4543+ doc.set_selection(view.id, selection);
4544+ }
48844545}
48854546
48864547//
@@ -4975,19 +4636,17 @@ fn transpose_view(cx: &mut Context) {
49754636 cx.editor.transpose_view()
49764637}
49774638
4978−/// Open a new split in the given direction specified by the action.
4979−///
4980−/// Maintain the current view (both the cursor's position and view in document).
4981−fn split(editor: &mut Editor, action: Action) {
4982− let (view, doc) = current!(editor);
4639+// split helper, clear it later
4640+fn split(cx: &mut Context, action: Action) {
4641+ let (view, doc) = current!(cx.editor);
49834642 let id = doc.id();
49844643 let selection = doc.selection(view.id).clone();
49854644 let offset = view.offset;
49864645
4987− editor.switch(id, action);
4646+ cx.editor.switch(id, action);
49884647
49894648 // match the selection in the previous view
4990− let (view, doc) = current!(editor);
4649+ let (view, doc) = current!(cx.editor);
49914650 doc.set_selection(view.id, selection);
49924651 // match the view scroll offset (switch doesn't handle this fully
49934652 // since the selection is only matched after the split)
@@ -4995,7 +4654,7 @@ fn split(editor: &mut Editor, action: Action) {
49954654}
49964655
49974656fn hsplit(cx: &mut Context) {
4998− split(cx.editor, Action::HorizontalSplit);
4657+ split(cx, Action::HorizontalSplit);
49994658}
50004659
50014660fn hsplit_new(cx: &mut Context) {
@@ -5003,7 +4662,7 @@ fn hsplit_new(cx: &mut Context) {
50034662}
50044663
50054664fn vsplit(cx: &mut Context) {
5006− split(cx.editor, Action::VerticalSplit);
4665+ split(cx, Action::VerticalSplit);
50074666}
50084667
50094668fn vsplit_new(cx: &mut Context) {
@@ -5052,12 +4711,7 @@ fn insert_register(cx: &mut Context) {
50524711 if let Some(ch) = event.char() {
50534712 cx.editor.autoinfo = None;
50544713 cx.register = Some(ch);
5055− paste(
5056− cx.editor,
5057− cx.register.unwrap_or('"'),
5058− Paste::Cursor,
5059− cx.count(),
5060− );
4714+ paste(cx, Paste::Cursor);
50614715 }
50624716 })
50634717}
@@ -5141,7 +4795,8 @@ fn goto_ts_object_impl(cx: &mut Context, object: &'static str, direction: Direct
51414795 editor.set_status("Syntax-tree is not available in current buffer");
51424796 }
51434797 };
5144− cx.editor.apply_motion(motion);
4798+ motion(cx.editor);
4799+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
51454800}
51464801
51474802fn goto_next_function(cx: &mut Context) {
@@ -5262,7 +4917,8 @@ fn select_textobject(cx: &mut Context, objtype: textobject::TextObject) {
52624917 });
52634918 doc.set_selection(view.id, selection);
52644919 };
5265− cx.editor.apply_motion(textobject);
4920+ textobject(cx.editor);
4921+ cx.editor.last_motion = Some(Motion(Box::new(textobject)));
52664922 }
52674923 });
52684924
@@ -5352,18 +5008,11 @@ fn surround_replace(cx: &mut Context) {
53525008 }
53535009 };
53545010
5355− let selection = selection.clone();
5356− let ranges: SmallVec<[Range; 1]> = change_pos.iter().map(|&p| Range::point(p)).collect();
5357− doc.set_selection(
5358− view.id,
5359− Selection::new(ranges, selection.primary_index() * 2),
5360− );
5361−
53625011 cx.on_next_key(move |cx, event| {
53635012 let (view, doc) = current!(cx.editor);
53645013 let to = match event.char() {
53655014 Some(to) => to,
5366− None => return doc.set_selection(view.id, selection),
5015+ None => return,
53675016 };
53685017 let (open, close) = surround::get_pair(to);
53695018 let transaction = Transaction::change(
@@ -5374,7 +5023,6 @@ fn surround_replace(cx: &mut Context) {
53745023 (pos, pos + 1, Some(t))
53755024 }),
53765025 );
5377− doc.set_selection(view.id, selection);
53785026 doc.apply(&transaction, view.id);
53795027 exit_select_mode(cx);
53805028 });
@@ -5609,18 +5257,12 @@ fn shell(cx: &mut compositor::Context, cmd: &str, behavior: &ShellBehavior) {
56095257 };
56105258
56115259 // These `usize`s cannot underflow because selection ranges cannot overlap.
5612− let anchor = to
5613− .checked_add_signed(offset)
5614− .expect("Selection ranges cannot overlap")
5615− .checked_sub(deleted_len)
5616− .expect("Selection ranges cannot overlap");
5260+ // Once the MSRV is 1.66.0 (mixed_integer_ops is stabilized), we can use checked
5261+ // arithmetic to assert this.
5262+ let anchor = (to as isize + offset - deleted_len as isize) as usize;
56175263 let new_range = Range::new(anchor, anchor + output_len).with_direction(range.direction());
56185264 ranges.push(new_range);
5619− offset = offset
5620− .checked_add_unsigned(output_len)
5621− .expect("Selection ranges cannot overlap")
5622− .checked_sub_unsigned(deleted_len)
5623− .expect("Selection ranges cannot overlap");
5265+ offset = offset + output_len as isize - deleted_len as isize;
56245266
56255267 changes.push((from, to, Some(output)));
56265268 }
@@ -5642,7 +5284,7 @@ fn shell_prompt(cx: &mut Context, prompt: Cow<'static, str>, behavior: ShellBeha
56425284 cx,
56435285 prompt,
56445286 Some('|'),
5645− ui::completers::filename,
5287+ ui::completers::none,
56465288 move |cx, input: &str, event: PromptEvent| {
56475289 if event != PromptEvent::Validate {
56485290 return;
@@ -5759,7 +5401,6 @@ fn increment_impl(cx: &mut Context, increment_direction: IncrementDirection) {
57595401 let transaction = Transaction::change(doc.text(), changes.into_iter());
57605402 let transaction = transaction.with_selection(new_selection);
57615403 doc.apply(&transaction, view.id);
5762− exit_select_mode(cx);
57635404 }
57645405}
57655406
@@ -5778,12 +5419,9 @@ fn record_macro(cx: &mut Context) {
57785419 }
57795420 })
57805421 .collect::<String>();
5781− match cx.editor.registers.write(reg, vec![s]) {
5782− Ok(_) => cx
5783− .editor
5784− .set_status(format!("Recorded to register [{}]", reg)),
5785− Err(err) => cx.editor.set_error(err.to_string()),
5786− }
5422+ cx.editor.registers.write(reg, vec![s]);
5423+ cx.editor
5424+ .set_status(format!("Recorded to register [{}]", reg));
57875425 } else {
57885426 let reg = cx.register.take().unwrap_or('@');
57895427 cx.editor.macro_recording = Some((reg, Vec::new()));
@@ -5803,14 +5441,8 @@ fn replay_macro(cx: &mut Context) {
58035441 return;
58045442 }
58055443
5806− let keys: Vec<KeyEvent> = if let Some(keys) = cx
5807− .editor
5808− .registers
5809− .read(reg, cx.editor)
5810− .filter(|values| values.len() == 1)
5811− .map(|mut values| values.next().unwrap())
5812− {
5813− match helix_view::input::parse_macro(&keys) {
5444+ let keys: Vec<KeyEvent> = if let Some([keys_str]) = cx.editor.registers.read(reg) {
5445+ match helix_view::input::parse_macro(keys_str) {
58145446 Ok(keys) => keys,
58155447 Err(err) => {
58165448 cx.editor.set_error(format!("Invalid macro: {}", err));