@@ -29,11 +29,12 @@ use helix_core::{
2929 tree_sitter::Node,
3030 unicode::width::UnicodeWidthChar,
3131 visual_offset_from_block, Deletion, LineEnding, Position, Range, Rope, RopeGraphemes,
32− RopeReader, RopeSlice, Selection, SmallVec, Tendril, Transaction,
32+ RopeSlice, Selection, SmallVec, Tendril, Transaction,
3333};
3434use helix_view::{
35+ clipboard::ClipboardType,
3536 document::{FormatterError, Mode, SCRATCH_BUFFER_NAME},
36− editor::{Action, CompleteAction},
37+ editor::{Action, CompleteAction, Motion},
3738 info::Info,
3839 input::KeyEvent,
3940 keyboard::KeyCode,
@@ -43,6 +44,7 @@ use helix_view::{
4344};
4445
4546use anyhow::{anyhow, bail, ensure, Context as _};
47+use fuzzy_matcher::FuzzyMatcher;
4648use insert::*;
4749use movement::Movement;
4850
@@ -53,20 +55,15 @@ use crate::{
5355 job::Callback,
5456 keymap::ReverseKeymap,
5557 ui::{
56− self, editor::InsertEvent, lsp::SignatureHelp, overlay::overlaid, CompletionItem, Picker,
57− Popup, Prompt, PromptEvent,
58+ self, editor::InsertEvent, lsp::SignatureHelp, overlay::overlaid, CompletionItem,
59+ FilePicker, Picker, Popup, Prompt, PromptEvent,
5860 },
5961};
6062
6163use crate::job::{self, Jobs};
62−use futures_util::{stream::FuturesUnordered, TryStreamExt};
63−use std::{
64− collections::{HashMap, HashSet},
65− fmt,
66− future::Future,
67− io::Read,
68− num::NonZeroUsize,
69−};
64+use futures_util::{stream::FuturesUnordered, StreamExt, TryStreamExt};
65+use std::{collections::HashMap, fmt, future::Future};
66+use std::{collections::HashSet, num::NonZeroUsize};
7067
7168use std::{
7269 borrow::Cow,
@@ -75,11 +72,11 @@ use std::{
7572
7673use once_cell::sync::Lazy;
7774use serde::de::{self, Deserialize, Deserializer};
78−use url::Url;
7975
8076use grep_regex::RegexMatcherBuilder;
8177use grep_searcher::{sinks, BinaryDetection, SearcherBuilder};
8278use ignore::{DirEntry, WalkBuilder, WalkState};
79+use tokio_stream::wrappers::UnboundedReceiverStream;
8380
8481pub type OnKeyCallback = Box<dyn FnOnce(&mut Context, KeyEvent)>;
8582
@@ -251,8 +248,6 @@ impl MappableCommand {
251248 move_prev_long_word_start, "Move to start of previous long word",
252249 move_next_long_word_end, "Move to end of next long word",
253250 move_prev_long_word_end, "Move to end of previous long word",
254− move_parent_node_end, "Move to end of the parent node",
255− move_parent_node_start, "Move to beginning of the parent node",
256251 extend_next_word_start, "Extend to start of next word",
257252 extend_prev_word_start, "Extend to start of previous word",
258253 extend_next_word_end, "Extend to end of next word",
@@ -261,8 +256,6 @@ impl MappableCommand {
261256 extend_prev_long_word_start, "Extend to start of previous long word",
262257 extend_next_long_word_end, "Extend to end of next long word",
263258 extend_prev_long_word_end, "Extend to end of prev long word",
264− extend_parent_node_end, "Extend to end of the parent node",
265− extend_parent_node_start, "Extend to beginning of the parent node",
266259 find_till_char, "Move till next occurrence of char",
267260 find_next_char, "Move to next occurrence of char",
268261 extend_till_char, "Extend till next occurrence of char",
@@ -337,7 +330,7 @@ impl MappableCommand {
337330 goto_implementation, "Goto implementation",
338331 goto_file_start, "Goto line number <n> else file start",
339332 goto_file_end, "Goto file end",
340− goto_file, "Goto files/URLs in selection",
333+ goto_file, "Goto files in selection",
341334 goto_file_hsplit, "Goto files in selection (hsplit)",
342335 goto_file_vsplit, "Goto files in selection (vsplit)",
343336 goto_reference, "Goto references",
@@ -369,7 +362,6 @@ impl MappableCommand {
369362 extend_to_line_end, "Extend to line end",
370363 extend_to_line_end_newline, "Extend to line end",
371364 signature_help, "Show signature help",
372− smart_tab, "Insert tab if all cursors have all whitespace to their left; otherwise, run a separate command.",
373365 insert_tab, "Insert tab char",
374366 insert_newline, "Insert newline char",
375367 delete_char_backward, "Delete previous char",
@@ -384,9 +376,6 @@ impl MappableCommand {
384376 later, "Move forward in history",
385377 commit_undo_checkpoint, "Commit changes to new checkpoint",
386378 yank, "Yank selection",
387− yank_to_clipboard, "Yank selections to clipboard",
388− yank_to_primary_clipboard, "Yank selections to primary clipboard",
389− yank_joined, "Join and yank selections",
390379 yank_joined_to_clipboard, "Join and yank selections to clipboard",
391380 yank_main_selection_to_clipboard, "Yank main selection to clipboard",
392381 yank_joined_to_primary_clipboard, "Join and yank selections to primary clipboard",
@@ -417,7 +406,6 @@ impl MappableCommand {
417406 rotate_selections_backward, "Rotate selections backward",
418407 rotate_selection_contents_forward, "Rotate selection contents forward",
419408 rotate_selection_contents_backward, "Rotate selections contents backward",
420− reverse_selection_contents, "Reverse selections contents",
421409 expand_selection, "Expand selection to parent syntax node",
422410 shrink_selection, "Shrink selection to previously expanded syntax node",
423411 select_next_sibling, "Select next sibling in syntax tree",
@@ -990,7 +978,6 @@ fn align_selections(cx: &mut Context) {
990978
991979 let transaction = Transaction::change(doc.text(), changes.into_iter());
992980 doc.apply(&transaction, view.id);
993− exit_select_mode(cx);
994981}
995982
996983fn goto_window(cx: &mut Context, align: Align) {
@@ -1110,7 +1097,8 @@ where
11101097 .transform(|range| move_fn(text, range, count, behavior));
11111098 doc.set_selection(view.id, selection);
11121099 };
1113− cx.editor.apply_motion(motion)
1100+ motion(cx.editor);
1101+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
11141102}
11151103
11161104fn goto_prev_paragraph(cx: &mut Context) {
@@ -1165,10 +1153,6 @@ fn goto_file_impl(cx: &mut Context, action: Action) {
11651153 let (view, doc) = current_ref!(cx.editor);
11661154 let text = doc.text();
11671155 let selections = doc.selection(view.id);
1168− let rel_path = doc
1169− .relative_path()
1170− .map(|path| path.parent().unwrap().to_path_buf())
1171− .unwrap_or_default();
11721156 let mut paths: Vec<_> = selections
11731157 .iter()
11741158 .map(|r| text.slice(r.from()..r.to()).to_string())
@@ -1196,80 +1180,16 @@ fn goto_file_impl(cx: &mut Context, action: Action) {
11961180 .to_string(),
11971181 );
11981182 }
1199−
12001183 for sel in paths {
12011184 let p = sel.trim();
1202− if p.is_empty() {
1203− continue;
1204− }
1205−
1206− if let Ok(url) = Url::parse(p) {
1207− return open_url(cx, url, action);
1208− }
1209−
1210− let path = &rel_path.join(p);
1211− if path.is_dir() {
1212− let picker = ui::file_picker(path.into(), &cx.editor.config());
1213− cx.push_layer(Box::new(overlaid(picker)));
1214− } else if let Err(e) = cx.editor.open(path, action) {
1215− cx.editor.set_error(format!("Open file failed: {:?}", e));
1216− }
1217− }
1218−}
1219−
1220−/// Opens the given url. If the URL points to a valid textual file it is open in helix.
1221−// Otherwise, the file is open using external program.
1222−fn open_url(cx: &mut Context, url: Url, action: Action) {
1223− let doc = doc!(cx.editor);
1224− let rel_path = doc
1225− .relative_path()
1226− .map(|path| path.parent().unwrap().to_path_buf())
1227− .unwrap_or_default();
1228−
1229− if url.scheme() != "file" {
1230− return open_external_url(cx, url);
1231− }
1232−
1233− let content_type = std::fs::File::open(url.path()).and_then(|file| {
1234− // Read up to 1kb to detect the content type
1235− let mut read_buffer = Vec::new();
1236− let n = file.take(1024).read_to_end(&mut read_buffer)?;
1237− Ok(content_inspector::inspect(&read_buffer[..n]))
1238− });
1239−
1240− // we attempt to open binary files - files that can't be open in helix - using external
1241− // program as well, e.g. pdf files or images
1242− match content_type {
1243− Ok(content_inspector::ContentType::BINARY) => open_external_url(cx, url),
1244− Ok(_) | Err(_) => {
1245− let path = &rel_path.join(url.path());
1246− if path.is_dir() {
1247− let picker = ui::file_picker(path.into(), &cx.editor.config());
1248− cx.push_layer(Box::new(overlaid(picker)));
1249− } else if let Err(e) = cx.editor.open(path, action) {
1185+ if !p.is_empty() {
1186+ if let Err(e) = cx.editor.open(&PathBuf::from(p), action) {
12501187 cx.editor.set_error(format!("Open file failed: {:?}", e));
12511188 }
12521189 }
12531190 }
12541191}
12551192
1256−/// Opens URL in external program.
1257−fn open_external_url(cx: &mut Context, url: Url) {
1258− let commands = open::commands(url.as_str());
1259− cx.jobs.callback(async {
1260− for cmd in commands {
1261− let mut command = tokio::process::Command::new(cmd.get_program());
1262− command.args(cmd.get_args());
1263− if command.output().await.is_ok() {
1264− return Ok(job::Callback::Editor(Box::new(|_| {})));
1265− }
1266− }
1267− Ok(job::Callback::Editor(Box::new(move |editor| {
1268− editor.set_error("Opening URL in external program failed")
1269− })))
1270− });
1271−}
1272−
12731193fn extend_word_impl<F>(cx: &mut Context, extend_fn: F)
12741194where
12751195 F: Fn(RopeSlice, Range, usize) -> Range,
@@ -1318,66 +1238,10 @@ fn extend_next_long_word_end(cx: &mut Context) {
13181238 extend_word_impl(cx, movement::move_next_long_word_end)
13191239}
13201240
1321−/// Separate branch to find_char designed only for `<ret>` char.
1322−//
1323−// This is necessary because the one document can have different line endings inside. And we
1324−// cannot predict what character to find when <ret> is pressed. On the current line it can be `lf`
1325−// but on the next line it can be `crlf`. That's why [`find_char_impl`] cannot be applied here.
1326−fn find_char_line_ending(
1327− cx: &mut Context,
1328− count: usize,
1329− direction: Direction,
1330− inclusive: bool,
1331− extend: bool,
1332−) {
1333− let (view, doc) = current!(cx.editor);
1334− let text = doc.text().slice(..);
1335−
1336− let selection = doc.selection(view.id).clone().transform(|range| {
1337− let cursor = range.cursor(text);
1338− let cursor_line = range.cursor_line(text);
1339−
1340− // Finding the line where we're going to find <ret>. Depends mostly on
1341− // `count`, but also takes into account edge cases where we're already at the end
1342− // of a line or the beginning of a line
1343− let find_on_line = match direction {
1344− Direction::Forward => {
1345− let on_edge = line_end_char_index(&text, cursor_line) == cursor;
1346− let line = cursor_line + count - 1 + (on_edge as usize);
1347− if line >= text.len_lines() - 1 {
1348− return range;
1349− } else {
1350− line
1351− }
1352− }
1353− Direction::Backward => {
1354− let on_edge = text.line_to_char(cursor_line) == cursor && !inclusive;
1355− let line = cursor_line as isize - (count as isize - 1 + on_edge as isize);
1356− if line <= 0 {
1357− return range;
1358− } else {
1359− line as usize
1360− }
1361− }
1362− };
1363−
1364− let pos = match (direction, inclusive) {
1365− (Direction::Forward, true) => line_end_char_index(&text, find_on_line),
1366− (Direction::Forward, false) => line_end_char_index(&text, find_on_line) - 1,
1367− (Direction::Backward, true) => line_end_char_index(&text, find_on_line - 1),
1368− (Direction::Backward, false) => text.line_to_char(find_on_line),
1369− };
1370−
1371− if extend {
1372− range.put_cursor(text, pos, true)
1373− } else {
1374− Range::point(range.cursor(text)).put_cursor(text, pos, true)
1375− }
1376− });
1377− doc.set_selection(view.id, selection);
1378−}
1379−
1380−fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bool) {
1241+fn will_find_char<F>(cx: &mut Context, search_fn: F, inclusive: bool, extend: bool)
1242+where
1243+ F: Fn(RopeSlice, char, usize, usize, bool) -> Option<usize> + 'static,
1244+{
13811245 // TODO: count is reset to 1 before next key so we move it into the closure here.
13821246 // Would be nice to carry over.
13831247 let count = cx.count();
@@ -1390,9 +1254,13 @@ fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bo
13901254 KeyEvent {
13911255 code: KeyCode::Enter,
13921256 ..
1393− } => {
1394− find_char_line_ending(cx, count, direction, inclusive, extend);
1395− return;
1257+ } =>
1258+ // TODO: this isn't quite correct when CRLF is involved.
1259+ // This hack will work in most cases, since documents don't
1260+ // usually mix line endings. But we should fix it eventually
1261+ // anyway.
1262+ {
1263+ doc!(cx.editor).line_ending.as_str().chars().next().unwrap()
13961264 }
13971265
13981266 KeyEvent {
@@ -1405,18 +1273,11 @@ fn find_char(cx: &mut Context, direction: Direction, inclusive: bool, extend: bo
14051273 } => ch,
14061274 _ => return,
14071275 };
1408− let motion = move |editor: &mut Editor| {
1409− match direction {
1410− Direction::Forward => {
1411− find_char_impl(editor, &find_next_char_impl, inclusive, extend, ch, count)
1412− }
1413− Direction::Backward => {
1414− find_char_impl(editor, &find_prev_char_impl, inclusive, extend, ch, count)
1415− }
1416− };
1417− };
14181276
1419− cx.editor.apply_motion(motion);
1277+ find_char_impl(cx.editor, &search_fn, inclusive, extend, ch, count);
1278+ cx.editor.last_motion = Some(Motion(Box::new(move |editor: &mut Editor| {
1279+ find_char_impl(editor, &search_fn, inclusive, extend, ch, 1);
1280+ })));
14201281 })
14211282}
14221283
@@ -1495,39 +1356,46 @@ fn find_prev_char_impl(
14951356}
14961357
14971358fn find_till_char(cx: &mut Context) {
1498− find_char(cx, Direction::Forward, false, false);
1359+ will_find_char(cx, find_next_char_impl, false, false)
14991360}
15001361
15011362fn find_next_char(cx: &mut Context) {
1502− find_char(cx, Direction::Forward, true, false)
1363+ will_find_char(cx, find_next_char_impl, true, false)
15031364}
15041365
15051366fn extend_till_char(cx: &mut Context) {
1506− find_char(cx, Direction::Forward, false, true)
1367+ will_find_char(cx, find_next_char_impl, false, true)
15071368}
15081369
15091370fn extend_next_char(cx: &mut Context) {
1510− find_char(cx, Direction::Forward, true, true)
1371+ will_find_char(cx, find_next_char_impl, true, true)
15111372}
15121373
15131374fn till_prev_char(cx: &mut Context) {
1514− find_char(cx, Direction::Backward, false, false)
1375+ will_find_char(cx, find_prev_char_impl, false, false)
15151376}
15161377
15171378fn find_prev_char(cx: &mut Context) {
1518− find_char(cx, Direction::Backward, true, false)
1379+ will_find_char(cx, find_prev_char_impl, true, false)
15191380}
15201381
15211382fn extend_till_prev_char(cx: &mut Context) {
1522− find_char(cx, Direction::Backward, false, true)
1383+ will_find_char(cx, find_prev_char_impl, false, true)
15231384}
15241385
15251386fn extend_prev_char(cx: &mut Context) {
1526− find_char(cx, Direction::Backward, true, true)
1387+ will_find_char(cx, find_prev_char_impl, true, true)
15271388}
15281389
15291390fn repeat_last_motion(cx: &mut Context) {
1530− cx.editor.repeat_last_motion(cx.count())
1391+ let count = cx.count();
1392+ let last_motion = cx.editor.last_motion.take();
1393+ if let Some(m) = &last_motion {
1394+ for _ in 0..count {
1395+ m.run(cx.editor);
1396+ }
1397+ cx.editor.last_motion = last_motion;
1398+ }
15311399}
15321400
15331401fn replace(cx: &mut Context) {
@@ -1594,7 +1462,6 @@ where
15941462 });
15951463
15961464 doc.apply(&transaction, view.id);
1597− exit_select_mode(cx);
15981465}
15991466
16001467fn switch_case(cx: &mut Context) {
@@ -1836,8 +1703,8 @@ fn select_regex(cx: &mut Context) {
18361703 "select:".into(),
18371704 Some(reg),
18381705 ui::completers::none,
1839− move |cx, regex, event| {
1840− let (view, doc) = current!(cx.editor);
1706+ move |editor, regex, event| {
1707+ let (view, doc) = current!(editor);
18411708 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
18421709 return;
18431710 }
@@ -1858,8 +1725,8 @@ fn split_selection(cx: &mut Context) {
18581725 "split:".into(),
18591726 Some(reg),
18601727 ui::completers::none,
1861− move |cx, regex, event| {
1862− let (view, doc) = current!(cx.editor);
1728+ move |editor, regex, event| {
1729+ let (view, doc) = current!(editor);
18631730 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
18641731 return;
18651732 }
@@ -1982,11 +1849,11 @@ fn search_impl(
19821849
19831850fn search_completions(cx: &mut Context, reg: Option<char>) -> Vec<String> {
19841851 let mut items = reg
1985− .and_then(|reg| cx.editor.registers.read(reg, cx.editor))
1986− .map_or(Vec::new(), |reg| reg.take(200).collect());
1852+ .and_then(|reg| cx.editor.registers.get(reg))
1853+ .map_or(Vec::new(), |reg| reg.read().iter().take(200).collect());
19871854 items.sort_unstable();
19881855 items.dedup();
1989− items.into_iter().map(|value| value.to_string()).collect()
1856+ items.into_iter().cloned().collect()
19901857}
19911858
19921859fn search(cx: &mut Context) {
@@ -2023,14 +1890,12 @@ fn searcher(cx: &mut Context, direction: Direction) {
20231890 .map(|comp| (0.., std::borrow::Cow::Owned(comp.clone())))
20241891 .collect()
20251892 },
2026− move |cx, regex, event| {
2027− if event == PromptEvent::Validate {
2028− cx.editor.registers.last_search_register = reg;
2029− } else if event != PromptEvent::Update {
1893+ move |editor, regex, event| {
1894+ if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
20301895 return;
20311896 }
20321897 search_impl(
2033− cx.editor,
1898+ editor,
20341899 &contents,
20351900 ®ex,
20361901 Movement::Move,
@@ -2045,13 +1910,11 @@ fn searcher(cx: &mut Context, direction: Direction) {
20451910
20461911fn search_next_or_prev_impl(cx: &mut Context, movement: Movement, direction: Direction) {
20471912 let count = cx.count();
2048− let register = cx
2049− .register
2050− .unwrap_or(cx.editor.registers.last_search_register);
20511913 let config = cx.editor.config();
20521914 let scrolloff = config.scrolloff;
2053− if let Some(query) = cx.editor.registers.first(register, cx.editor) {
2054− let doc = doc!(cx.editor);
1915+ let (_, doc) = current!(cx.editor);
1916+ let registers = &cx.editor.registers;
1917+ if let Some(query) = registers.read('/').and_then(|query| query.last()) {
20551918 let contents = doc.text().slice(..).to_string();
20561919 let search_config = &config.search;
20571920 let case_insensitive = if search_config.smart_case {
@@ -2060,7 +1923,7 @@ fn search_next_or_prev_impl(cx: &mut Context, movement: Movement, direction: Dir
20601923 false
20611924 };
20621925 let wrap_around = search_config.wrap_around;
2063− if let Ok(regex) = RegexBuilder::new(&query)
1926+ if let Ok(regex) = RegexBuilder::new(query)
20641927 .case_insensitive(case_insensitive)
20651928 .multi_line(true)
20661929 .build()
@@ -2100,7 +1963,6 @@ fn extend_search_prev(cx: &mut Context) {
21001963}
21011964
21021965fn search_selection(cx: &mut Context) {
2103− let register = cx.register.unwrap_or('/');
21041966 let (view, doc) = current!(cx.editor);
21051967 let contents = doc.text().slice(..);
21061968
@@ -2113,24 +1975,13 @@ fn search_selection(cx: &mut Context) {
21131975 .collect::<Vec<_>>()
21141976 .join("|");
21151977
2116− let msg = format!("register '{}' set to '{}'", register, ®ex);
2117− match cx.editor.registers.push(register, regex) {
2118− Ok(_) => {
2119− cx.editor.registers.last_search_register = register;
2120− cx.editor.set_status(msg)
2121− }
2122− Err(err) => cx.editor.set_error(err.to_string()),
2123− }
1978+ let msg = format!("register '{}' set to '{}'", '/', ®ex);
1979+ cx.editor.registers.push('/', regex);
1980+ cx.editor.set_status(msg);
21241981}
21251982
21261983fn make_search_word_bounded(cx: &mut Context) {
2127− // Defaults to the active search register instead `/` to be more ergonomic assuming most people
2128− // would use this command following `search_selection`. This avoids selecting the register
2129− // twice.
2130− let register = cx
2131− .register
2132− .unwrap_or(cx.editor.registers.last_search_register);
2133− let regex = match cx.editor.registers.first(register, cx.editor) {
1984+ let regex = match cx.editor.registers.last('/') {
21341985 Some(regex) => regex,
21351986 None => return,
21361987 };
@@ -2148,19 +1999,14 @@ fn make_search_word_bounded(cx: &mut Context) {
21481999 if !start_anchored {
21492000 new_regex.push_str("\\b");
21502001 }
2151− new_regex.push_str(®ex);
2002+ new_regex.push_str(regex);
21522003 if !end_anchored {
21532004 new_regex.push_str("\\b");
21542005 }
21552006
2156− let msg = format!("register '{}' set to '{}'", register, &new_regex);
2157− match cx.editor.registers.push(register, new_regex) {
2158− Ok(_) => {
2159− cx.editor.registers.last_search_register = register;
2160− cx.editor.set_status(msg)
2161− }
2162− Err(err) => cx.editor.set_error(err.to_string()),
2163− }
2007+ let msg = format!("register '{}' set to '{}'", '/', &new_regex);
2008+ cx.editor.registers.push('/', new_regex);
2009+ cx.editor.set_status(msg);
21642010}
21652011
21662012fn global_search(cx: &mut Context) {
@@ -2199,11 +2045,13 @@ fn global_search(cx: &mut Context) {
21992045 }
22002046 }
22012047
2048+ let (all_matches_sx, all_matches_rx) = tokio::sync::mpsc::unbounded_channel::<FileResult>();
22022049 let config = cx.editor.config();
22032050 let smart_case = config.search.smart_case;
22042051 let file_picker_config = config.file_picker.clone();
22052052
22062053 let reg = cx.register.unwrap_or('/');
2054+
22072055 let completions = search_completions(cx, Some(reg));
22082056 ui::regex_prompt(
22092057 cx,
@@ -2216,67 +2064,43 @@ fn global_search(cx: &mut Context) {
22162064 .map(|comp| (0.., std::borrow::Cow::Owned(comp.clone())))
22172065 .collect()
22182066 },
2219− move |cx, regex, event| {
2067+ move |_editor, regex, event| {
22202068 if event != PromptEvent::Validate {
22212069 return;
22222070 }
2223− cx.editor.registers.last_search_register = reg;
2224−
2225− let current_path = doc_mut!(cx.editor).path().cloned();
2226− let documents: Vec<_> = cx
2227− .editor
2228− .documents()
2229− .map(|doc| (doc.path().cloned(), doc.text().to_owned()))
2230− .collect();
22312071
22322072 if let Ok(matcher) = RegexMatcherBuilder::new()
22332073 .case_smart(smart_case)
22342074 .build(regex.as_str())
22352075 {
2236− let search_root = helix_loader::current_working_dir();
2237− if !search_root.exists() {
2238− cx.editor
2239− .set_error("Current working directory does not exist");
2240− return;
2241− }
2242−
2243− let (picker, injector) = Picker::stream(current_path);
2076+ let searcher = SearcherBuilder::new()
2077+ .binary_detection(BinaryDetection::quit(b'\x00'))
2078+ .build();
22442079
2080+ let search_root = std::env::current_dir()
2081+ .expect("Global search error: Failed to get current dir");
22452082 let dedup_symlinks = file_picker_config.deduplicate_links;
22462083 let absolute_root = search_root
22472084 .canonicalize()
22482085 .unwrap_or_else(|_| search_root.clone());
2249− let injector_ = injector.clone();
2250−
2251− std::thread::spawn(move || {
2252− let searcher = SearcherBuilder::new()
2253− .binary_detection(BinaryDetection::quit(b'\x00'))
2254− .build();
2255−
2256− let mut walk_builder = WalkBuilder::new(search_root);
2257−
2258− walk_builder
2259− .hidden(file_picker_config.hidden)
2260− .parents(file_picker_config.parents)
2261− .ignore(file_picker_config.ignore)
2262− .follow_links(file_picker_config.follow_symlinks)
2263− .git_ignore(file_picker_config.git_ignore)
2264− .git_global(file_picker_config.git_global)
2265− .git_exclude(file_picker_config.git_exclude)
2266− .max_depth(file_picker_config.max_depth)
2267− .filter_entry(move |entry| {
2268− filter_picker_entry(entry, &absolute_root, dedup_symlinks)
2269− });
2270−
2271− walk_builder
2272− .add_custom_ignore_filename(helix_loader::config_dir().join("ignore"));
2273− walk_builder.add_custom_ignore_filename(".helix/ignore");
2274−
2275− walk_builder.build_parallel().run(|| {
2086+
2087+ WalkBuilder::new(search_root)
2088+ .hidden(file_picker_config.hidden)
2089+ .parents(file_picker_config.parents)
2090+ .ignore(file_picker_config.ignore)
2091+ .follow_links(file_picker_config.follow_symlinks)
2092+ .git_ignore(file_picker_config.git_ignore)
2093+ .git_global(file_picker_config.git_global)
2094+ .git_exclude(file_picker_config.git_exclude)
2095+ .max_depth(file_picker_config.max_depth)
2096+ .filter_entry(move |entry| {
2097+ filter_picker_entry(entry, &absolute_root, dedup_symlinks)
2098+ })
2099+ .build_parallel()
2100+ .run(|| {
22762101 let mut searcher = searcher.clone();
22772102 let matcher = matcher.clone();
2278− let injector = injector_.clone();
2279− let documents = &documents;
2103+ let all_matches_sx = all_matches_sx.clone();
22802104 Box::new(move |entry: Result<DirEntry, ignore::Error>| -> WalkState {
22812105 let entry = match entry {
22822106 Ok(entry) => entry,
@@ -2289,39 +2113,17 @@ fn global_search(cx: &mut Context) {
22892113 _ => return WalkState::Continue,
22902114 };
22912115
2292− let mut stop = false;
2293− let sink = sinks::UTF8(|line_num, _| {
2294− stop = injector
2295− .push(FileResult::new(entry.path(), line_num as usize - 1))
2296− .is_err();
2297−
2298− Ok(!stop)
2299− });
2300− let doc = documents.iter().find(|&(doc_path, _)| {
2301− doc_path
2302− .as_ref()
2303− .map_or(false, |doc_path| doc_path == entry.path())
2304− });
2305−
2306− let result = if let Some((_, doc)) = doc {
2307− // there is already a buffer for this file
2308− // search the buffer instead of the file because it's faster
2309− // and captures new edits without requiring a save
2310− if searcher.multi_line_with_matcher(&matcher) {
2311− // in this case a continous buffer is required
2312− // convert the rope to a string
2313− let text = doc.to_string();
2314− searcher.search_slice(&matcher, text.as_bytes(), sink)
2315− } else {
2316− searcher.search_reader(
2317− &matcher,
2318− RopeReader::new(doc.slice(..)),
2319− sink,
2320− )
2321− }
2322− } else {
2323− searcher.search_path(&matcher, entry.path(), sink)
2324− };
2116+ let result = searcher.search_path(
2117+ &matcher,
2118+ entry.path(),
2119+ sinks::UTF8(|line_num, _| {
2120+ all_matches_sx
2121+ .send(FileResult::new(entry.path(), line_num as usize - 1))
2122+ .unwrap();
2123+
2124+ Ok(true)
2125+ }),
2126+ );
23252127
23262128 if let Err(err) = result {
23272129 log::error!(
@@ -2330,66 +2132,67 @@ fn global_search(cx: &mut Context) {
23302132 err
23312133 );
23322134 }
2333− if stop {
2334− WalkState::Quit
2335− } else {
2336− WalkState::Continue
2337− }
2135+ WalkState::Continue
23382136 })
23392137 });
2340− });
2341−
2342− cx.jobs.callback(async move {
2343− let call = move |_: &mut Editor, compositor: &mut Compositor| {
2344− let picker = Picker::with_stream(
2345− picker,
2346− injector,
2347− move |cx, FileResult { path, line_num }, action| {
2348− let doc = match cx.editor.open(path, action) {
2349− Ok(id) => doc_mut!(cx.editor, &id),
2350− Err(e) => {
2351− cx.editor.set_error(format!(
2352− "Failed to open file '{}': {}",
2353− path.display(),
2354− e
2355− ));
2356− return;
2357− }
2358− };
2359−
2360− let line_num = *line_num;
2361− let view = view_mut!(cx.editor);
2362− let text = doc.text();
2363− if line_num >= text.len_lines() {
2364− cx.editor.set_error(
2365− "The line you jumped to does not exist anymore because the file has changed.",
2366− );
2367− return;
2368− }
2369− let start = text.line_to_char(line_num);
2370− let end = text.line_to_char((line_num + 1).min(text.len_lines()));
2371−
2372− doc.set_selection(view.id, Selection::single(start, end));
2373− if action.align_view(view, doc.id()) {
2374− align_view(doc, view, Align::Center);
2375− }
2376− },
2377− )
2378− .with_preview(
2379− |_editor, FileResult { path, line_num }| {
2380− Some((path.clone().into(), Some((*line_num, *line_num))))
2381− },
2382− );
2383− compositor.push(Box::new(overlaid(picker)))
2384− };
2385− Ok(Callback::EditorCompositor(Box::new(call)))
2386− })
23872138 } else {
23882139 // Otherwise do nothing
23892140 // log::warn!("Global Search Invalid Pattern")
23902141 }
23912142 },
23922143 );
2144+
2145+ let current_path = doc_mut!(cx.editor).path().cloned();
2146+
2147+ let show_picker = async move {
2148+ let all_matches: Vec<FileResult> =
2149+ UnboundedReceiverStream::new(all_matches_rx).collect().await;
2150+ let call: job::Callback = Callback::EditorCompositor(Box::new(
2151+ move |editor: &mut Editor, compositor: &mut Compositor| {
2152+ if all_matches.is_empty() {
2153+ editor.set_status("No matches found");
2154+ return;
2155+ }
2156+
2157+ let picker = FilePicker::new(
2158+ all_matches,
2159+ current_path,
2160+ move |cx, FileResult { path, line_num }, action| {
2161+ match cx.editor.open(path, action) {
2162+ Ok(_) => {}
2163+ Err(e) => {
2164+ cx.editor.set_error(format!(
2165+ "Failed to open file '{}': {}",
2166+ path.display(),
2167+ e
2168+ ));
2169+ return;
2170+ }
2171+ }
2172+
2173+ let line_num = *line_num;
2174+ let (view, doc) = current!(cx.editor);
2175+ let text = doc.text();
2176+ if line_num >= text.len_lines() {
2177+ cx.editor.set_error("The line you jumped to does not exist anymore because the file has changed.");
2178+ return;
2179+ }
2180+ let start = text.line_to_char(line_num);
2181+ let end = text.line_to_char((line_num + 1).min(text.len_lines()));
2182+
2183+ doc.set_selection(view.id, Selection::single(start, end));
2184+ align_view(doc, view, Align::Center);
2185+ },
2186+ |_editor, FileResult { path, line_num }| {
2187+ Some((path.clone().into(), Some((*line_num, *line_num))))
2188+ },
2189+ );
2190+ compositor.push(Box::new(overlaid(picker)));
2191+ },
2192+ ));
2193+ Ok(call)
2194+ };
2195+ cx.jobs.callback(show_picker);
23932196}
23942197
23952198enum Extend {
@@ -2512,35 +2315,17 @@ enum Operation {
25122315 Change,
25132316}
25142317
2515−fn selection_is_linewise(selection: &Selection, text: &Rope) -> bool {
2516− selection.ranges().iter().all(|range| {
2517− let text = text.slice(..);
2518− if range.slice(text).len_lines() < 2 {
2519− return false;
2520− }
2521− // If the start of the selection is at the start of a line and the end at the end of a line.
2522− let (start_line, end_line) = range.line_range(text);
2523− let start = text.line_to_char(start_line);
2524− let end = text.line_to_char((end_line + 1).min(text.len_lines()));
2525− start == range.from() && end == range.to()
2526− })
2527−}
2528−
25292318fn delete_selection_impl(cx: &mut Context, op: Operation) {
25302319 let (view, doc) = current!(cx.editor);
25312320
25322321 let selection = doc.selection(view.id);
2533− let only_whole_lines = selection_is_linewise(selection, doc.text());
25342322
25352323 if cx.register != Some('_') {
25362324 // first yank the selection
25372325 let text = doc.text().slice(..);
25382326 let values: Vec<String> = selection.fragments(text).map(Cow::into_owned).collect();
25392327 let reg_name = cx.register.unwrap_or('"');
2540− if let Err(err) = cx.editor.registers.write(reg_name, values) {
2541− cx.editor.set_error(err.to_string());
2542− return;
2543− }
2328+ cx.editor.registers.write(reg_name, values);
25442329 };
25452330
25462331 // then delete
@@ -2554,11 +2339,7 @@ fn delete_selection_impl(cx: &mut Context, op: Operation) {
25542339 exit_select_mode(cx);
25552340 }
25562341 Operation::Change => {
2557− if only_whole_lines {
2558− open_above(cx);
2559− } else {
2560− enter_insert_mode(cx);
2561− }
2342+ enter_insert_mode(cx);
25622343 }
25632344 }
25642345}
@@ -2680,10 +2461,6 @@ fn insert_mode(cx: &mut Context) {
26802461 .transform(|range| Range::new(range.to(), range.from()));
26812462
26822463 doc.set_selection(view.id, selection);
2683−
2684− // [TODO] temporary workaround until we're not using the idle timer to
2685− // trigger auto completions any more
2686− cx.editor.clear_idle_timer();
26872464}
26882465
26892466// inserts at the end of each selection
@@ -2720,10 +2497,6 @@ fn append_mode(cx: &mut Context) {
27202497
27212498fn file_picker(cx: &mut Context) {
27222499 let root = find_workspace().0;
2723− if !root.exists() {
2724− cx.editor.set_error("Workspace directory does not exist");
2725− return;
2726− }
27272500 let picker = ui::file_picker(root, &cx.editor.config());
27282501 cx.push_layer(Box::new(overlaid(picker)));
27292502}
@@ -2744,14 +2517,8 @@ fn file_picker_in_current_buffer_directory(cx: &mut Context) {
27442517 let picker = ui::file_picker(path, &cx.editor.config());
27452518 cx.push_layer(Box::new(overlaid(picker)));
27462519}
2747−
27482520fn file_picker_in_current_directory(cx: &mut Context) {
2749− let cwd = helix_loader::current_working_dir();
2750− if !cwd.exists() {
2751− cx.editor
2752− .set_error("Current working directory does not exist");
2753− return;
2754− }
2521+ let cwd = std::env::current_dir().unwrap_or_else(|_| PathBuf::from("./"));
27552522 let picker = ui::file_picker(cwd, &cx.editor.config());
27562523 cx.push_layer(Box::new(overlaid(picker)));
27572524}
@@ -2810,18 +2577,22 @@ fn buffer_picker(cx: &mut Context) {
28102577 // mru
28112578 items.sort_unstable_by_key(|item| std::cmp::Reverse(item.focused_at));
28122579
2813− let picker = Picker::new(items, (), |cx, meta, action| {
2814− cx.editor.switch(meta.id, action);
2815− })
2816− .with_preview(|editor, meta| {
2817− let doc = &editor.documents.get(&meta.id)?;
2818− let &view_id = doc.selections().keys().next()?;
2819− let line = doc
2820− .selection(view_id)
2821− .primary()
2822− .cursor_line(doc.text().slice(..));
2823− Some((meta.id.into(), Some((line, line))))
2824− });
2580+ let picker = FilePicker::new(
2581+ items,
2582+ (),
2583+ |cx, meta, action| {
2584+ cx.editor.switch(meta.id, action);
2585+ },
2586+ |editor, meta| {
2587+ let doc = &editor.documents.get(&meta.id)?;
2588+ let &view_id = doc.selections().keys().next()?;
2589+ let line = doc
2590+ .selection(view_id)
2591+ .primary()
2592+ .cursor_line(doc.text().slice(..));
2593+ Some((meta.id.into(), Some((line, line))))
2594+ },
2595+ );
28252596 cx.push_layer(Box::new(overlaid(picker)));
28262597}
28272598
@@ -2887,7 +2658,7 @@ fn jumplist_picker(cx: &mut Context) {
28872658 }
28882659 };
28892660
2890− let picker = Picker::new(
2661+ let picker = FilePicker::new(
28912662 cx.editor
28922663 .tree
28932664 .views()
@@ -2901,18 +2672,16 @@ fn jumplist_picker(cx: &mut Context) {
29012672 |cx, meta, action| {
29022673 cx.editor.switch(meta.id, action);
29032674 let config = cx.editor.config();
2904− let (view, doc) = (view_mut!(cx.editor), doc_mut!(cx.editor, &meta.id));
2675+ let (view, doc) = current!(cx.editor);
29052676 doc.set_selection(view.id, meta.selection.clone());
2906− if action.align_view(view, doc.id()) {
2907− view.ensure_cursor_in_view_center(doc, config.scrolloff);
2908− }
2677+ view.ensure_cursor_in_view_center(doc, config.scrolloff);
29092678 },
2910− )
2911− .with_preview(|editor, meta| {
2912− let doc = &editor.documents.get(&meta.id)?;
2913− let line = meta.selection.primary().cursor_line(doc.text().slice(..));
2914− Some((meta.id.into(), Some((line, line))))
2915− });
2679+ |editor, meta| {
2680+ let doc = &editor.documents.get(&meta.id)?;
2681+ let line = meta.selection.primary().cursor_line(doc.text().slice(..));
2682+ Some((meta.path.clone()?.into(), Some((line, line))))
2683+ },
2684+ );
29162685 cx.push_layer(Box::new(overlaid(picker)));
29172686}
29182687
@@ -3006,88 +2775,24 @@ fn last_picker(cx: &mut Context) {
30062775 }));
30072776}
30082777
3009−/// Fallback position to use for [`insert_with_indent`].
3010−enum IndentFallbackPos {
3011− LineStart,
3012− LineEnd,
3013−}
3014−
3015−// `I` inserts at the first nonwhitespace character of each line with a selection.
3016−// If the line is empty, automatically indent.
2778+// I inserts at the first nonwhitespace character of each line with a selection
30172779fn insert_at_line_start(cx: &mut Context) {
3018− insert_with_indent(cx, IndentFallbackPos::LineStart);
2780+ goto_first_nonwhitespace(cx);
2781+ enter_insert_mode(cx);
30192782}
30202783
3021−// `A` inserts at the end of each line with a selection.
3022−// If the line is empty, automatically indent.
2784+// A inserts at the end of each line with a selection
30232785fn insert_at_line_end(cx: &mut Context) {
3024− insert_with_indent(cx, IndentFallbackPos::LineEnd);
3025−}
3026−
3027−// Enter insert mode and auto-indent the current line if it is empty.
3028−// If the line is not empty, move the cursor to the specified fallback position.
3029−fn insert_with_indent(cx: &mut Context, cursor_fallback: IndentFallbackPos) {
30302786 enter_insert_mode(cx);
3031−
30322787 let (view, doc) = current!(cx.editor);
30332788
3034− let text = doc.text().slice(..);
3035− let contents = doc.text();
3036− let selection = doc.selection(view.id);
3037−
3038− let language_config = doc.language_config();
3039− let syntax = doc.syntax();
3040− let tab_width = doc.tab_width();
3041−
3042− let mut ranges = SmallVec::with_capacity(selection.len());
3043− let mut offs = 0;
3044−
3045− let mut transaction = Transaction::change_by_selection(contents, selection, |range| {
3046− let cursor_line = range.cursor_line(text);
3047− let cursor_line_start = text.line_to_char(cursor_line);
3048−
3049− if line_end_char_index(&text, cursor_line) == cursor_line_start {
3050− // line is empty => auto indent
3051− let line_end_index = cursor_line_start;
3052−
3053− let indent = indent::indent_for_newline(
3054− language_config,
3055− syntax,
3056− &doc.config.load().indent_heuristic,
3057− &doc.indent_style,
3058− tab_width,
3059− text,
3060− cursor_line,
3061− line_end_index,
3062− cursor_line,
3063− );
3064−
3065− // calculate new selection ranges
3066− let pos = offs + cursor_line_start;
3067− let indent_width = indent.chars().count();
3068− ranges.push(Range::point(pos + indent_width));
3069− offs += indent_width;
3070−
3071− (line_end_index, line_end_index, Some(indent.into()))
3072− } else {
3073− // move cursor to the fallback position
3074− let pos = match cursor_fallback {
3075− IndentFallbackPos::LineStart => {
3076− find_first_non_whitespace_char(text.line(cursor_line))
3077− .map(|ws_offset| ws_offset + cursor_line_start)
3078− .unwrap_or(cursor_line_start)
3079− }
3080− IndentFallbackPos::LineEnd => line_end_char_index(&text, cursor_line),
3081− };
3082−
3083− ranges.push(range.put_cursor(text, pos + offs, cx.editor.mode == Mode::Select));
3084−
3085− (cursor_line_start, cursor_line_start, None)
3086− }
2789+ let selection = doc.selection(view.id).clone().transform(|range| {
2790+ let text = doc.text().slice(..);
2791+ let line = range.cursor_line(text);
2792+ let pos = line_end_char_index(&text, line);
2793+ Range::new(pos, pos)
30872794 });
3088−
3089− transaction = transaction.with_selection(Selection::new(ranges, selection.primary_index()));
3090− doc.apply(&transaction, view.id);
2795+ doc.set_selection(view.id, selection);
30912796}
30922797
30932798// Creates an LspCallback that waits for formatting changes to be computed. When they're done,
@@ -3158,7 +2863,6 @@ fn open(cx: &mut Context, open: Open) {
31582863 Open::Below => graphemes::prev_grapheme_boundary(text, range.to()),
31592864 Open::Above => range.from(),
31602865 });
3161−
31622866 let new_line = match open {
31632867 // adjust position to the end of the line (next line - 1)
31642868 Open::Below => cursor_line + 1,
@@ -3166,15 +2870,13 @@ fn open(cx: &mut Context, open: Open) {
31662870 Open::Above => cursor_line,
31672871 };
31682872
3169− let line_num = new_line.saturating_sub(1);
3170−
31712873 // Index to insert newlines after, as well as the char width
31722874 // to use to compensate for those inserted newlines.
31732875 let (line_end_index, line_end_offset_width) = if new_line == 0 {
31742876 (0, 0)
31752877 } else {
31762878 (
3177− line_end_char_index(&text, line_num),
2879+ line_end_char_index(&doc.text().slice(..), new_line.saturating_sub(1)),
31782880 doc.line_ending.len_chars(),
31792881 )
31802882 };
@@ -3182,15 +2884,13 @@ fn open(cx: &mut Context, open: Open) {
31822884 let indent = indent::indent_for_newline(
31832885 doc.language_config(),
31842886 doc.syntax(),
3185− &doc.config.load().indent_heuristic,
31862887 &doc.indent_style,
31872888 doc.tab_width(),
31882889 text,
3189− line_num,
2890+ new_line.saturating_sub(1),
31902891 line_end_index,
31912892 cursor_line,
31922893 );
3193−
31942894 let indent_len = indent.len();
31952895 let mut text = String::with_capacity(1 + indent_len);
31962896 text.push_str(doc.line_ending.as_str());
@@ -3489,7 +3189,8 @@ fn goto_next_change_impl(cx: &mut Context, direction: Direction) {
34893189
34903190 doc.set_selection(view.id, selection)
34913191 };
3492− cx.editor.apply_motion(motion);
3192+ motion(cx.editor);
3193+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
34933194}
34943195
34953196/// Returns the [Range] for a [Hunk] in the given text.
@@ -3616,7 +3317,6 @@ pub mod insert {
36163317 }
36173318
36183319 use helix_core::auto_pairs;
3619− use helix_view::editor::SmartTabConfig;
36203320
36213321 pub fn insert_char(cx: &mut Context, c: char) {
36223322 let (view, doc) = current_ref!(cx.editor);
@@ -3642,31 +3342,6 @@ pub mod insert {
36423342 }
36433343 }
36443344
3645− pub fn smart_tab(cx: &mut Context) {
3646− let (view, doc) = current_ref!(cx.editor);
3647− let view_id = view.id;
3648−
3649− if matches!(
3650− cx.editor.config().smart_tab,
3651− Some(SmartTabConfig { enable: true, .. })
3652− ) {
3653− let cursors_after_whitespace = doc.selection(view_id).ranges().iter().all(|range| {
3654− let cursor = range.cursor(doc.text().slice(..));
3655− let current_line_num = doc.text().char_to_line(cursor);
3656− let current_line_start = doc.text().line_to_char(current_line_num);
3657− let left = doc.text().slice(current_line_start..cursor);
3658− left.chars().all(|c| c.is_whitespace())
3659− });
3660−
3661− if !cursors_after_whitespace {
3662− move_parent_node_end(cx);
3663− return;
3664− }
3665− }
3666−
3667− insert_tab(cx);
3668− }
3669−
36703345 pub fn insert_tab(cx: &mut Context) {
36713346 let (view, doc) = current!(cx.editor);
36723347 // TODO: round out to nearest indentation level (for example a line with 3 spaces should
@@ -3722,7 +3397,6 @@ pub mod insert {
37223397 let indent = indent::indent_for_newline(
37233398 doc.language_config(),
37243399 doc.syntax(),
3725− &doc.config.load().indent_heuristic,
37263400 &doc.indent_style,
37273401 doc.tab_width(),
37283402 text,
@@ -3963,21 +3637,34 @@ fn commit_undo_checkpoint(cx: &mut Context) {
39633637// Yank / Paste
39643638
39653639fn yank(cx: &mut Context) {
3966− yank_impl(cx.editor, cx.register.unwrap_or('"'));
3967− exit_select_mode(cx);
3968−}
3640+ let (view, doc) = current!(cx.editor);
3641+ let text = doc.text().slice(..);
39693642
3970−fn yank_to_clipboard(cx: &mut Context) {
3971− yank_impl(cx.editor, '+');
3972− exit_select_mode(cx);
3973−}
3643+ let values: Vec<String> = doc
3644+ .selection(view.id)
3645+ .fragments(text)
3646+ .map(Cow::into_owned)
3647+ .collect();
3648+
3649+ let msg = format!(
3650+ "yanked {} selection(s) to register {}",
3651+ values.len(),
3652+ cx.register.unwrap_or('"')
3653+ );
3654+
3655+ cx.editor
3656+ .registers
3657+ .write(cx.register.unwrap_or('"'), values);
39743658
3975−fn yank_to_primary_clipboard(cx: &mut Context) {
3976− yank_impl(cx.editor, '*');
3659+ cx.editor.set_status(msg);
39773660 exit_select_mode(cx);
39783661}
39793662
3980−fn yank_impl(editor: &mut Editor, register: char) {
3663+fn yank_joined_to_clipboard_impl(
3664+ editor: &mut Editor,
3665+ separator: &str,
3666+ clipboard_type: ClipboardType,
3667+) -> anyhow::Result<()> {
39813668 let (view, doc) = current!(editor);
39823669 let text = doc.text().slice(..);
39833670
@@ -3986,79 +3673,74 @@ fn yank_impl(editor: &mut Editor, register: char) {
39863673 .fragments(text)
39873674 .map(Cow::into_owned)
39883675 .collect();
3989− let selections = values.len();
39903676
3991− match editor.registers.write(register, values) {
3992− Ok(_) => editor.set_status(format!(
3993− "yanked {selections} selection{} to register {register}",
3994− if selections == 1 { "" } else { "s" }
3995− )),
3996− Err(err) => editor.set_error(err.to_string()),
3997− }
3998−}
3677+ let clipboard_text = match clipboard_type {
3678+ ClipboardType::Clipboard => "system clipboard",
3679+ ClipboardType::Selection => "primary clipboard",
3680+ };
39993681
4000−fn yank_joined_impl(editor: &mut Editor, separator: &str, register: char) {
4001− let (view, doc) = current!(editor);
4002− let text = doc.text().slice(..);
3682+ let msg = format!(
3683+ "joined and yanked {} selection(s) to {}",
3684+ values.len(),
3685+ clipboard_text,
3686+ );
40033687
4004− let selection = doc.selection(view.id);
4005− let selections = selection.len();
4006− let joined = selection
4007− .fragments(text)
4008− .fold(String::new(), |mut acc, fragment| {
4009− if !acc.is_empty() {
4010− acc.push_str(separator);
4011− }
4012− acc.push_str(&fragment);
4013− acc
4014− });
3688+ let joined = values.join(separator);
40153689
4016− match editor.registers.write(register, vec![joined]) {
4017− Ok(_) => editor.set_status(format!(
4018− "joined and yanked {selections} selection{} to register {register}",
4019− if selections == 1 { "" } else { "s" }
4020− )),
4021− Err(err) => editor.set_error(err.to_string()),
4022− }
4023−}
3690+ editor
3691+ .clipboard_provider
3692+ .set_contents(joined, clipboard_type)
3693+ .context("Couldn't set system clipboard content")?;
40243694
4025−fn yank_joined(cx: &mut Context) {
4026− let separator = doc!(cx.editor).line_ending.as_str();
4027− yank_joined_impl(cx.editor, separator, cx.register.unwrap_or('"'));
4028− exit_select_mode(cx);
4029−}
3695+ editor.set_status(msg);
40303696
4031−fn yank_joined_to_clipboard(cx: &mut Context) {
4032− let line_ending = doc!(cx.editor).line_ending;
4033− yank_joined_impl(cx.editor, line_ending.as_str(), '+');
4034− exit_select_mode(cx);
3697+ Ok(())
40353698}
40363699
4037−fn yank_joined_to_primary_clipboard(cx: &mut Context) {
3700+fn yank_joined_to_clipboard(cx: &mut Context) {
40383701 let line_ending = doc!(cx.editor).line_ending;
4039− yank_joined_impl(cx.editor, line_ending.as_str(), '*');
3702+ let _ =
3703+ yank_joined_to_clipboard_impl(cx.editor, line_ending.as_str(), ClipboardType::Clipboard);
40403704 exit_select_mode(cx);
40413705}
40423706
4043−fn yank_primary_selection_impl(editor: &mut Editor, register: char) {
3707+fn yank_main_selection_to_clipboard_impl(
3708+ editor: &mut Editor,
3709+ clipboard_type: ClipboardType,
3710+) -> anyhow::Result<()> {
40443711 let (view, doc) = current!(editor);
40453712 let text = doc.text().slice(..);
40463713
4047− let selection = doc.selection(view.id).primary().fragment(text).to_string();
3714+ let message_text = match clipboard_type {
3715+ ClipboardType::Clipboard => "yanked main selection to system clipboard",
3716+ ClipboardType::Selection => "yanked main selection to primary clipboard",
3717+ };
3718+
3719+ let value = doc.selection(view.id).primary().fragment(text);
40483720
4049− match editor.registers.write(register, vec![selection]) {
4050− Ok(_) => editor.set_status(format!("yanked primary selection to register {register}",)),
4051− Err(err) => editor.set_error(err.to_string()),
3721+ if let Err(e) = editor
3722+ .clipboard_provider
3723+ .set_contents(value.into_owned(), clipboard_type)
3724+ {
3725+ bail!("Couldn't set system clipboard content: {}", e);
40523726 }
3727+
3728+ editor.set_status(message_text);
3729+ Ok(())
40533730}
40543731
40553732fn yank_main_selection_to_clipboard(cx: &mut Context) {
4056− yank_primary_selection_impl(cx.editor, '+');
4057− exit_select_mode(cx);
3733+ let _ = yank_main_selection_to_clipboard_impl(cx.editor, ClipboardType::Clipboard);
3734+}
3735+
3736+fn yank_joined_to_primary_clipboard(cx: &mut Context) {
3737+ let line_ending = doc!(cx.editor).line_ending;
3738+ let _ =
3739+ yank_joined_to_clipboard_impl(cx.editor, line_ending.as_str(), ClipboardType::Selection);
40583740}
40593741
40603742fn yank_main_selection_to_primary_clipboard(cx: &mut Context) {
4061− yank_primary_selection_impl(cx.editor, '*');
3743+ let _ = yank_main_selection_to_clipboard_impl(cx.editor, ClipboardType::Selection);
40623744 exit_select_mode(cx);
40633745}
40643746
@@ -4156,99 +3838,146 @@ pub(crate) fn paste_bracketed_value(cx: &mut Context, contents: String) {
41563838 };
41573839 let (view, doc) = current!(cx.editor);
41583840 paste_impl(&[contents], doc, view, paste, count, cx.editor.mode);
4159− exit_select_mode(cx);
3841+}
3842+
3843+fn paste_clipboard_impl(
3844+ editor: &mut Editor,
3845+ action: Paste,
3846+ clipboard_type: ClipboardType,
3847+ count: usize,
3848+) -> anyhow::Result<()> {
3849+ let (view, doc) = current!(editor);
3850+ match editor.clipboard_provider.get_contents(clipboard_type) {
3851+ Ok(contents) => {
3852+ paste_impl(&[contents], doc, view, action, count, editor.mode);
3853+ Ok(())
3854+ }
3855+ Err(e) => Err(e.context("Couldn't get system clipboard contents")),
3856+ }
41603857}
41613858
41623859fn paste_clipboard_after(cx: &mut Context) {
4163− paste(cx.editor, '+', Paste::After, cx.count());
4164− exit_select_mode(cx);
3860+ let _ = paste_clipboard_impl(
3861+ cx.editor,
3862+ Paste::After,
3863+ ClipboardType::Clipboard,
3864+ cx.count(),
3865+ );
41653866}
41663867
41673868fn paste_clipboard_before(cx: &mut Context) {
4168− paste(cx.editor, '+', Paste::Before, cx.count());
4169− exit_select_mode(cx);
3869+ let _ = paste_clipboard_impl(
3870+ cx.editor,
3871+ Paste::Before,
3872+ ClipboardType::Clipboard,
3873+ cx.count(),
3874+ );
41703875}
41713876
41723877fn paste_primary_clipboard_after(cx: &mut Context) {
4173− paste(cx.editor, '*', Paste::After, cx.count());
4174− exit_select_mode(cx);
3878+ let _ = paste_clipboard_impl(
3879+ cx.editor,
3880+ Paste::After,
3881+ ClipboardType::Selection,
3882+ cx.count(),
3883+ );
41753884}
41763885
41773886fn paste_primary_clipboard_before(cx: &mut Context) {
4178− paste(cx.editor, '*', Paste::Before, cx.count());
4179− exit_select_mode(cx);
3887+ let _ = paste_clipboard_impl(
3888+ cx.editor,
3889+ Paste::Before,
3890+ ClipboardType::Selection,
3891+ cx.count(),
3892+ );
41803893}
41813894
41823895fn replace_with_yanked(cx: &mut Context) {
4183− replace_with_yanked_impl(cx.editor, cx.register.unwrap_or('"'), cx.count());
4184− exit_select_mode(cx);
3896+ let count = cx.count();
3897+ let reg_name = cx.register.unwrap_or('"');
3898+ let (view, doc) = current!(cx.editor);
3899+ let registers = &mut cx.editor.registers;
3900+
3901+ if let Some(values) = registers.read(reg_name) {
3902+ if !values.is_empty() {
3903+ let repeat = std::iter::repeat(
3904+ values
3905+ .last()
3906+ .map(|value| Tendril::from(&value.repeat(count)))
3907+ .unwrap(),
3908+ );
3909+ let mut values = values
3910+ .iter()
3911+ .map(|value| Tendril::from(&value.repeat(count)))
3912+ .chain(repeat);
3913+ let selection = doc.selection(view.id);
3914+ let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
3915+ if !range.is_empty() {
3916+ (range.from(), range.to(), Some(values.next().unwrap()))
3917+ } else {
3918+ (range.from(), range.to(), None)
3919+ }
3920+ });
3921+
3922+ doc.apply(&transaction, view.id);
3923+ exit_select_mode(cx);
3924+ }
3925+ }
41853926}
41863927
4187−fn replace_with_yanked_impl(editor: &mut Editor, register: char, count: usize) {
4188− let Some(values) = editor.registers
4189− .read(register, editor)
4190− .filter(|values| values.len() > 0) else { return };
4191− let values: Vec<_> = values.map(|value| value.to_string()).collect();
3928+fn replace_selections_with_clipboard_impl(
3929+ cx: &mut Context,
3930+ clipboard_type: ClipboardType,
3931+) -> anyhow::Result<()> {
3932+ let count = cx.count();
3933+ let (view, doc) = current!(cx.editor);
41923934
4193− let (view, doc) = current!(editor);
4194− let repeat = std::iter::repeat(
4195− values
4196− .last()
4197− .map(|value| Tendril::from(&value.repeat(count)))
4198− .unwrap(),
4199− );
4200− let mut values = values
4201− .iter()
4202− .map(|value| Tendril::from(&value.repeat(count)))
4203− .chain(repeat);
4204− let selection = doc.selection(view.id);
4205− let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
4206− if !range.is_empty() {
4207− (range.from(), range.to(), Some(values.next().unwrap()))
4208− } else {
4209− (range.from(), range.to(), None)
3935+ match cx.editor.clipboard_provider.get_contents(clipboard_type) {
3936+ Ok(contents) => {
3937+ let selection = doc.selection(view.id);
3938+ let transaction = Transaction::change_by_selection(doc.text(), selection, |range| {
3939+ (
3940+ range.from(),
3941+ range.to(),
3942+ Some(contents.repeat(count).as_str().into()),
3943+ )
3944+ });
3945+
3946+ doc.apply(&transaction, view.id);
3947+ doc.append_changes_to_history(view);
42103948 }
4211− });
3949+ Err(e) => return Err(e.context("Couldn't get system clipboard contents")),
3950+ }
42123951
4213− doc.apply(&transaction, view.id);
3952+ exit_select_mode(cx);
3953+ Ok(())
42143954}
42153955
42163956fn replace_selections_with_clipboard(cx: &mut Context) {
4217− replace_with_yanked_impl(cx.editor, '+', cx.count());
4218− exit_select_mode(cx);
3957+ let _ = replace_selections_with_clipboard_impl(cx, ClipboardType::Clipboard);
42193958}
42203959
42213960fn replace_selections_with_primary_clipboard(cx: &mut Context) {
4222− replace_with_yanked_impl(cx.editor, '*', cx.count());
4223− exit_select_mode(cx);
3961+ let _ = replace_selections_with_clipboard_impl(cx, ClipboardType::Selection);
42243962}
42253963
4226−fn paste(editor: &mut Editor, register: char, pos: Paste, count: usize) {
4227− let Some(values) = editor.registers.read(register, editor) else { return };
4228− let values: Vec<_> = values.map(|value| value.to_string()).collect();
3964+fn paste(cx: &mut Context, pos: Paste) {
3965+ let count = cx.count();
3966+ let reg_name = cx.register.unwrap_or('"');
3967+ let (view, doc) = current!(cx.editor);
3968+ let registers = &mut cx.editor.registers;
42293969
4230− let (view, doc) = current!(editor);
4231− paste_impl(&values, doc, view, pos, count, editor.mode);
3970+ if let Some(values) = registers.read(reg_name) {
3971+ paste_impl(values, doc, view, pos, count, cx.editor.mode);
3972+ }
42323973}
42333974
42343975fn paste_after(cx: &mut Context) {
4235− paste(
4236− cx.editor,
4237− cx.register.unwrap_or('"'),
4238− Paste::After,
4239− cx.count(),
4240− );
4241− exit_select_mode(cx);
3976+ paste(cx, Paste::After)
42423977}
42433978
42443979fn paste_before(cx: &mut Context) {
4245− paste(
4246− cx.editor,
4247− cx.register.unwrap_or('"'),
4248− Paste::Before,
4249− cx.count(),
4250− );
4251− exit_select_mode(cx);
3980+ paste(cx, Paste::Before)
42523981}
42533982
42543983fn get_lines(doc: &Document, view_id: ViewId) -> Vec<usize> {
@@ -4287,7 +4016,6 @@ fn indent(cx: &mut Context) {
42874016 }),
42884017 );
42894018 doc.apply(&transaction, view.id);
4290− exit_select_mode(cx);
42914019}
42924020
42934021fn unindent(cx: &mut Context) {
@@ -4327,7 +4055,6 @@ fn unindent(cx: &mut Context) {
43274055 let transaction = Transaction::change(doc.text(), changes.into_iter());
43284056
43294057 doc.apply(&transaction, view.id);
4330− exit_select_mode(cx);
43314058}
43324059
43334060fn format_selections(cx: &mut Context) {
@@ -4357,7 +4084,7 @@ fn format_selections(cx: &mut Context) {
43574084 })
43584085 else {
43594086 cx.editor
4360− .set_error("No configured language server supports range formatting");
4087+ .set_error("No configured language server does not support range formatting");
43614088 return;
43624089 };
43634090
@@ -4394,9 +4121,10 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
43944121 use movement::skip_while;
43954122 let (view, doc) = current!(cx.editor);
43964123 let text = doc.text();
4397− let slice = text.slice(..);
4124+ let slice = doc.text().slice(..);
43984125
43994126 let mut changes = Vec::new();
4127+ let fragment = Tendril::from(" ");
44004128
44014129 for selection in doc.selection(view.id) {
44024130 let (start, mut end) = selection.line_range(slice);
@@ -4412,13 +4140,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44124140 let mut end = text.line_to_char(line + 1);
44134141 end = skip_while(slice, end, |ch| matches!(ch, ' ' | '\t')).unwrap_or(end);
44144142
4415− let separator = if end == line_end_char_index(&slice, line + 1) {
4416− // the joining line contains only space-characters => don't include a whitespace when joining
4417− None
4418− } else {
4419− Some(Tendril::from(" "))
4420− };
4421− changes.push((start, end, separator));
4143+ // need to skip from start, not end
4144+ let change = (start, end, Some(fragment.clone()));
4145+ changes.push(change);
44224146 }
44234147 }
44244148
@@ -4430,6 +4154,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44304154 changes.sort_unstable_by_key(|(from, _to, _text)| *from);
44314155 changes.dedup();
44324156
4157+ // TODO: joining multiple empty lines should be replaced by a single space.
4158+ // need to merge change ranges that touch
4159+
44334160 // select inserted spaces
44344161 let transaction = if select_space {
44354162 let ranges: SmallVec<_> = changes
@@ -4441,9 +4168,9 @@ fn join_selections_impl(cx: &mut Context, select_space: bool) {
44414168 })
44424169 .collect();
44434170 let selection = Selection::new(ranges, 0);
4444− Transaction::change(text, changes.into_iter()).with_selection(selection)
4171+ Transaction::change(doc.text(), changes.into_iter()).with_selection(selection)
44454172 } else {
4446− Transaction::change(text, changes.into_iter())
4173+ Transaction::change(doc.text(), changes.into_iter())
44474174 };
44484175
44494176 doc.apply(&transaction, view.id);
@@ -4457,8 +4184,8 @@ fn keep_or_remove_selections_impl(cx: &mut Context, remove: bool) {
44574184 if remove { "remove:" } else { "keep:" }.into(),
44584185 Some(reg),
44594186 ui::completers::none,
4460− move |cx, regex, event| {
4461− let (view, doc) = current!(cx.editor);
4187+ move |editor, regex, event| {
4188+ let (view, doc) = current!(editor);
44624189 if !matches!(event, PromptEvent::Update | PromptEvent::Validate) {
44634190 return;
44644191 }
@@ -4692,13 +4419,7 @@ fn rotate_selections_backward(cx: &mut Context) {
46924419 rotate_selections(cx, Direction::Backward)
46934420}
46944421
4695−enum ReorderStrategy {
4696− RotateForward,
4697− RotateBackward,
4698− Reverse,
4699−}
4700−
4701−fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
4422+fn rotate_selection_contents(cx: &mut Context, direction: Direction) {
47024423 let count = cx.count;
47034424 let (view, doc) = current!(cx.editor);
47044425 let text = doc.text().slice(..);
@@ -4716,10 +4437,9 @@ fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
47164437
47174438 for chunk in fragments.chunks_mut(group) {
47184439 // TODO: also modify main index
4719− match strategy {
4720− ReorderStrategy::RotateForward => chunk.rotate_right(1),
4721− ReorderStrategy::RotateBackward => chunk.rotate_left(1),
4722− ReorderStrategy::Reverse => chunk.reverse(),
4440+ match direction {
4441+ Direction::Forward => chunk.rotate_right(1),
4442+ Direction::Backward => chunk.rotate_left(1),
47234443 };
47244444 }
47254445
@@ -4736,13 +4456,10 @@ fn reorder_selection_contents(cx: &mut Context, strategy: ReorderStrategy) {
47364456}
47374457
47384458fn rotate_selection_contents_forward(cx: &mut Context) {
4739− reorder_selection_contents(cx, ReorderStrategy::RotateForward)
4459+ rotate_selection_contents(cx, Direction::Forward)
47404460}
47414461fn rotate_selection_contents_backward(cx: &mut Context) {
4742− reorder_selection_contents(cx, ReorderStrategy::RotateBackward)
4743−}
4744−fn reverse_selection_contents(cx: &mut Context) {
4745− reorder_selection_contents(cx, ReorderStrategy::Reverse)
4462+ rotate_selection_contents(cx, Direction::Backward)
47464463}
47474464
47484465// tree sitter node selection
@@ -4766,7 +4483,8 @@ fn expand_selection(cx: &mut Context) {
47664483 }
47674484 }
47684485 };
4769− cx.editor.apply_motion(motion);
4486+ motion(cx.editor);
4487+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
47704488}
47714489
47724490fn shrink_selection(cx: &mut Context) {
@@ -4790,7 +4508,8 @@ fn shrink_selection(cx: &mut Context) {
47904508 doc.set_selection(view.id, selection);
47914509 }
47924510 };
4793− cx.editor.apply_motion(motion);
4511+ motion(cx.editor);
4512+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
47944513}
47954514
47964515fn select_sibling_impl<F>(cx: &mut Context, sibling_fn: &'static F)
@@ -4808,7 +4527,8 @@ where
48084527 doc.set_selection(view.id, selection);
48094528 }
48104529 };
4811− cx.editor.apply_motion(motion);
4530+ motion(cx.editor);
4531+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
48124532}
48134533
48144534fn select_next_sibling(cx: &mut Context) {
@@ -4819,49 +4539,6 @@ fn select_prev_sibling(cx: &mut Context) {
48194539 select_sibling_impl(cx, &|node| Node::prev_sibling(&node))
48204540}
48214541
4822−fn move_node_bound_impl(cx: &mut Context, dir: Direction, movement: Movement) {
4823− let motion = move |editor: &mut Editor| {
4824− let (view, doc) = current!(editor);
4825−
4826− if let Some(syntax) = doc.syntax() {
4827− let text = doc.text().slice(..);
4828− let current_selection = doc.selection(view.id);
4829−
4830− let selection = movement::move_parent_node_end(
4831− syntax,
4832− text,
4833− current_selection.clone(),
4834− dir,
4835− movement,
4836− );
4837−
4838− doc.set_selection(view.id, selection);
4839−
4840− // [TODO] temporary workaround until we're not using the idle timer to
4841− // trigger auto completions any more
4842− editor.clear_idle_timer();
4843− }
4844− };
4845−
4846− cx.editor.apply_motion(motion);
4847−}
4848−
4849−pub fn move_parent_node_end(cx: &mut Context) {
4850− move_node_bound_impl(cx, Direction::Forward, Movement::Move)
4851−}
4852−
4853−pub fn move_parent_node_start(cx: &mut Context) {
4854− move_node_bound_impl(cx, Direction::Backward, Movement::Move)
4855−}
4856−
4857−pub fn extend_parent_node_end(cx: &mut Context) {
4858− move_node_bound_impl(cx, Direction::Forward, Movement::Extend)
4859−}
4860−
4861−pub fn extend_parent_node_start(cx: &mut Context) {
4862− move_node_bound_impl(cx, Direction::Backward, Movement::Extend)
4863−}
4864−
48654542fn match_brackets(cx: &mut Context) {
48664543 let (view, doc) = current!(cx.editor);
48674544 let is_select = cx.editor.mode == Mode::Select;
@@ -4871,8 +4548,8 @@ fn match_brackets(cx: &mut Context) {
48714548 let selection = doc.selection(view.id).clone().transform(|range| {
48724549 let pos = range.cursor(text_slice);
48734550 if let Some(matched_pos) = doc.syntax().map_or_else(
4874− || match_brackets::find_matching_bracket_plaintext(text.slice(..), pos),
4875− |syntax| match_brackets::find_matching_bracket_fuzzy(syntax, text.slice(..), pos),
4551+ || match_brackets::find_matching_bracket_current_line_plaintext(text, pos),
4552+ |syntax| match_brackets::find_matching_bracket_fuzzy(syntax, text, pos),
48764553 ) {
48774554 range.put_cursor(text_slice, matched_pos, is_select)
48784555 } else {
@@ -4975,19 +4652,17 @@ fn transpose_view(cx: &mut Context) {
49754652 cx.editor.transpose_view()
49764653}
49774654
4978−/// Open a new split in the given direction specified by the action.
4979−///
4980−/// Maintain the current view (both the cursor's position and view in document).
4981−fn split(editor: &mut Editor, action: Action) {
4982− let (view, doc) = current!(editor);
4655+// split helper, clear it later
4656+fn split(cx: &mut Context, action: Action) {
4657+ let (view, doc) = current!(cx.editor);
49834658 let id = doc.id();
49844659 let selection = doc.selection(view.id).clone();
49854660 let offset = view.offset;
49864661
4987− editor.switch(id, action);
4662+ cx.editor.switch(id, action);
49884663
49894664 // match the selection in the previous view
4990− let (view, doc) = current!(editor);
4665+ let (view, doc) = current!(cx.editor);
49914666 doc.set_selection(view.id, selection);
49924667 // match the view scroll offset (switch doesn't handle this fully
49934668 // since the selection is only matched after the split)
@@ -4995,7 +4670,7 @@ fn split(editor: &mut Editor, action: Action) {
49954670}
49964671
49974672fn hsplit(cx: &mut Context) {
4998− split(cx.editor, Action::HorizontalSplit);
4673+ split(cx, Action::HorizontalSplit);
49994674}
50004675
50014676fn hsplit_new(cx: &mut Context) {
@@ -5003,7 +4678,7 @@ fn hsplit_new(cx: &mut Context) {
50034678}
50044679
50054680fn vsplit(cx: &mut Context) {
5006− split(cx.editor, Action::VerticalSplit);
4681+ split(cx, Action::VerticalSplit);
50074682}
50084683
50094684fn vsplit_new(cx: &mut Context) {
@@ -5052,12 +4727,7 @@ fn insert_register(cx: &mut Context) {
50524727 if let Some(ch) = event.char() {
50534728 cx.editor.autoinfo = None;
50544729 cx.register = Some(ch);
5055− paste(
5056− cx.editor,
5057− cx.register.unwrap_or('"'),
5058− Paste::Cursor,
5059− cx.count(),
5060− );
4730+ paste(cx, Paste::Cursor);
50614731 }
50624732 })
50634733}
@@ -5141,7 +4811,8 @@ fn goto_ts_object_impl(cx: &mut Context, object: &'static str, direction: Direct
51414811 editor.set_status("Syntax-tree is not available in current buffer");
51424812 }
51434813 };
5144− cx.editor.apply_motion(motion);
4814+ motion(cx.editor);
4815+ cx.editor.last_motion = Some(Motion(Box::new(motion)));
51454816}
51464817
51474818fn goto_next_function(cx: &mut Context) {
@@ -5262,7 +4933,8 @@ fn select_textobject(cx: &mut Context, objtype: textobject::TextObject) {
52624933 });
52634934 doc.set_selection(view.id, selection);
52644935 };
5265− cx.editor.apply_motion(textobject);
4936+ textobject(cx.editor);
4937+ cx.editor.last_motion = Some(Motion(Box::new(textobject)));
52664938 }
52674939 });
52684940
@@ -5352,18 +5024,11 @@ fn surround_replace(cx: &mut Context) {
53525024 }
53535025 };
53545026
5355− let selection = selection.clone();
5356− let ranges: SmallVec<[Range; 1]> = change_pos.iter().map(|&p| Range::point(p)).collect();
5357− doc.set_selection(
5358− view.id,
5359− Selection::new(ranges, selection.primary_index() * 2),
5360− );
5361−
53625027 cx.on_next_key(move |cx, event| {
53635028 let (view, doc) = current!(cx.editor);
53645029 let to = match event.char() {
53655030 Some(to) => to,
5366− None => return doc.set_selection(view.id, selection),
5031+ None => return,
53675032 };
53685033 let (open, close) = surround::get_pair(to);
53695034 let transaction = Transaction::change(
@@ -5374,7 +5039,6 @@ fn surround_replace(cx: &mut Context) {
53745039 (pos, pos + 1, Some(t))
53755040 }),
53765041 );
5377− doc.set_selection(view.id, selection);
53785042 doc.apply(&transaction, view.id);
53795043 exit_select_mode(cx);
53805044 });
@@ -5609,18 +5273,12 @@ fn shell(cx: &mut compositor::Context, cmd: &str, behavior: &ShellBehavior) {
56095273 };
56105274
56115275 // These `usize`s cannot underflow because selection ranges cannot overlap.
5612− let anchor = to
5613− .checked_add_signed(offset)
5614− .expect("Selection ranges cannot overlap")
5615− .checked_sub(deleted_len)
5616− .expect("Selection ranges cannot overlap");
5276+ // Once the MSRV is 1.66.0 (mixed_integer_ops is stabilized), we can use checked
5277+ // arithmetic to assert this.
5278+ let anchor = (to as isize + offset - deleted_len as isize) as usize;
56175279 let new_range = Range::new(anchor, anchor + output_len).with_direction(range.direction());
56185280 ranges.push(new_range);
5619− offset = offset
5620− .checked_add_unsigned(output_len)
5621− .expect("Selection ranges cannot overlap")
5622− .checked_sub_unsigned(deleted_len)
5623− .expect("Selection ranges cannot overlap");
5281+ offset = offset + output_len as isize - deleted_len as isize;
56245282
56255283 changes.push((from, to, Some(output)));
56265284 }
@@ -5642,7 +5300,7 @@ fn shell_prompt(cx: &mut Context, prompt: Cow<'static, str>, behavior: ShellBeha
56425300 cx,
56435301 prompt,
56445302 Some('|'),
5645− ui::completers::filename,
5303+ ui::completers::none,
56465304 move |cx, input: &str, event: PromptEvent| {
56475305 if event != PromptEvent::Validate {
56485306 return;
@@ -5759,7 +5417,6 @@ fn increment_impl(cx: &mut Context, increment_direction: IncrementDirection) {
57595417 let transaction = Transaction::change(doc.text(), changes.into_iter());
57605418 let transaction = transaction.with_selection(new_selection);
57615419 doc.apply(&transaction, view.id);
5762− exit_select_mode(cx);
57635420 }
57645421}
57655422
@@ -5778,12 +5435,9 @@ fn record_macro(cx: &mut Context) {
57785435 }
57795436 })
57805437 .collect::<String>();
5781− match cx.editor.registers.write(reg, vec![s]) {
5782− Ok(_) => cx
5783− .editor
5784− .set_status(format!("Recorded to register [{}]", reg)),
5785− Err(err) => cx.editor.set_error(err.to_string()),
5786− }
5438+ cx.editor.registers.write(reg, vec![s]);
5439+ cx.editor
5440+ .set_status(format!("Recorded to register [{}]", reg));
57875441 } else {
57885442 let reg = cx.register.take().unwrap_or('@');
57895443 cx.editor.macro_recording = Some((reg, Vec::new()));
@@ -5803,14 +5457,8 @@ fn replay_macro(cx: &mut Context) {
58035457 return;
58045458 }
58055459
5806− let keys: Vec<KeyEvent> = if let Some(keys) = cx
5807− .editor
5808− .registers
5809− .read(reg, cx.editor)
5810− .filter(|values| values.len() == 1)
5811− .map(|mut values| values.next().unwrap())
5812− {
5813− match helix_view::input::parse_macro(&keys) {
5460+ let keys: Vec<KeyEvent> = if let Some([keys_str]) = cx.editor.registers.read(reg) {
5461+ match helix_view::input::parse_macro(keys_str) {
58145462 Ok(keys) => keys,
58155463 Err(err) => {
58165464 cx.editor.set_error(format!("Invalid macro: {}", err));