From 5517cc506b2754cb2485b1bf3e46918ee638ea6d Mon Sep 17 00:00:00 2001 From: Vaxry Date: Mon, 3 Jun 2024 21:13:38 +0200 Subject: [PATCH] xwayland: don't destroy server client this potentially leaks, but avoids a UAF ref #6323 --- src/xwayland/Server.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xwayland/Server.cpp b/src/xwayland/Server.cpp index 510ad737..26010cfb 100644 --- a/src/xwayland/Server.cpp +++ b/src/xwayland/Server.cpp @@ -262,8 +262,9 @@ void CXWaylandServer::die() { if (xwmFDs[1]) close(xwmFDs[1]); - if (xwaylandClient) - wl_client_destroy(xwaylandClient); + // possible crash. Better to leak a bit. + //if (xwaylandClient) + // wl_client_destroy(xwaylandClient); xwaylandClient = nullptr; waylandFDs = {-1, -1};