PParser.hs: filename: Report the specific failed check on error

This makes the error message more specific and so more useful to the
person trying to debug their iPKG file.

src/Pkg/PParser.hs

@@ -15,6 +15,7 @@ import Idris.CmdOptions
 import Control.Monad.State.Strict
 import Control.Applicative
 import System.FilePath (takeFileName, isValid)
+import Data.Maybe (isNothing, fromJust)
 
 import Util.System
 
@@ -79,18 +80,33 @@ filename = (do
         -- Through at least version 0.9.19.1, IPKG executable values were
         -- possibly namespaced identifiers, like foo.bar.baz.
         show <$> fst <$> iName []
-    if isValidFilename filename
+    let errorMessage = filenameErrorMessage filename
+    if isNothing errorMessage
       then return filename
-      else fail "a filename must be non-empty and have no directory component")
+      else fail $ fromJust errorMessage)
     <?> "filename"
     where
-        isValidFilename :: FilePath -> Bool
+        -- TODO: Report failing span better! We could lookAhead,
-        isValidFilename path =
+        -- or do something with DeltaParsing?
-            and [isNonEmpty, isValidPath, hasNoDirectoryComponent]
+        filenameErrorMessage :: FilePath -> Maybe String
+        filenameErrorMessage path = either Just (const Nothing) $ do
+            checkEmpty path
+            checkValid path
+            checkNoDirectoryComponent path
             where
-                isNonEmpty = path /= ""
+                checkThat ok message =
-                isValidPath = System.FilePath.isValid path
+                    if ok then Right () else Left message
-                hasNoDirectoryComponent = path == takeFileName path
+
+                checkEmpty path =
+                    checkThat (path /= "") "filename must not be empty"
+
+                checkValid path =
+                    checkThat (System.FilePath.isValid path)
+                        "filename must contain only valid characters"
+
+                checkNoDirectoryComponent path =
+                    checkThat (path == takeFileName path)
+                        "filename must contain no directory component"
 
 
 pClause :: PParser ()