From 0b74d423d017b8b201cf9a471f8c1fb1e96de148 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bla=C5=BE=20Hrastnik?= <blaz@mxxn.io>
Date: Wed, 14 Oct 2020 11:55:24 +0900
Subject: [PATCH] Validate compose len after applying a is same as before
 applying b.

---
 helix-core/src/transaction.rs | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/helix-core/src/transaction.rs b/helix-core/src/transaction.rs
index c888de3a..6f3956aa 100644
--- a/helix-core/src/transaction.rs
+++ b/helix-core/src/transaction.rs
@@ -41,11 +41,26 @@ impl ChangeSet {
 
     // TODO: from iter
 
+    #[must_use]
+    fn len_after(&self) -> usize {
+        use Operation::*;
+
+        let mut len = 0;
+        for change in &self.changes {
+            match change {
+                Retain(i) => len += i,
+                Insert(s) => len += s.chars().count(),
+                Delete(_) => (),
+            }
+        }
+        len
+    }
+
     /// Combine two changesets together.
     /// In other words,  If `this` goes `docA` → `docB` and `other` represents `docB` → `docC`, the
     /// returned value will represent the change `docA` → `docC`.
     pub fn compose(self, other: ChangeSet) -> Result<Self, ()> {
-        // TODO: len before b should match len after a
+        debug_assert!(self.len_after() == other.len);
 
         let len = self.changes.len();
 
@@ -182,10 +197,7 @@ impl ChangeSet {
     /// Returns a new changeset that reverts this one. Useful for `undo` implementation.
     /// The document parameter expects the original document before this change was applied.
     pub fn invert(&self, original_doc: &Rope) -> Self {
-        if original_doc.len_chars() != self.len {
-            panic!("Document length mismatch");
-            // return false;
-        }
+        assert!(original_doc.len_chars() == self.len);
 
         let mut changes = Vec::with_capacity(self.changes.len());
         let mut pos = 0;