ilyakooo0/helix
1
0
Fork 0
mirror of https://github.com/ilyakooo0/helix.git synced 2024-11-28 21:20:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove some TODOs

Browse Source
This commit is contained in:
Blaž Hrastnik 2022-01-23 16:08:36 +09:00
parent 80e920ba36
commit 7c9ebd05b8
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
TODO.md
View File

@ -1,25 +1,12 @@
- tree sitter:
- markdown
- regex
- kotlin
- clojure
- erlang
- [ ] completion isIncomplete support - [ ] completion isIncomplete support
1
- [ ] respect view fullscreen flag - [ ] respect view fullscreen flag
- [ ] Implement marks (superset of Selection/Range) - [ ] Implement marks (superset of Selection/Range)
- [ ] = for auto indent line/selection - [ ] = for auto indent line/selection
- [ ] :x for closing buffers
- [ ] lsp: signature help - [ ] lsp: signature help
2 2
- [ ] macro recording
- [ ] extend selection (treesitter select parent node) (replaces viw, vi(, va( etc )
- [ ] selection align
- [ ] store some state between restarts: file positions, prompt history - [ ] store some state between restarts: file positions, prompt history
- [ ] highlight matched characters in picker - [ ] highlight matched characters in picker

8
helix-core/src/syntax.rs
View File

@ -665,14 +665,10 @@ impl Syntax {
layer.depth == depth && // TODO: track parent id instead layer.depth == depth && // TODO: track parent id instead
layer.config.language == config.language && layer.ranges == ranges layer.config.language == config.language && layer.ranges == ranges
}) })
.map(|(id, _layer)| { .map(|(id, _layer)| id);
log::info!("match! {:?}", id);
id
});
// ...or insert a new one. // ...or insert a new one.
let layer_id = layer.unwrap_or_else(|| { let layer_id = layer.unwrap_or_else(|| {
log::info!("miss! {:?}", ranges);
self.layers.insert(LanguageLayer { self.layers.insert(LanguageLayer {
tree: None, tree: None,
config, config,
@ -714,7 +710,6 @@ impl Syntax {
.iter() .iter()
.filter_map(|(_, layer)| { .filter_map(|(_, layer)| {
// TODO: if range doesn't overlap layer range, skip it // TODO: if range doesn't overlap layer range, skip it
// we can calculate intersection and use it later for set_byte_range
// Reuse a cursor from the pool if available. // Reuse a cursor from the pool if available.
let mut cursor = PARSER.with(|ts_parser| { let mut cursor = PARSER.with(|ts_parser| {
@ -729,7 +724,6 @@ impl Syntax {
unsafe { mem::transmute::<_, &'static mut QueryCursor>(&mut cursor) }; unsafe { mem::transmute::<_, &'static mut QueryCursor>(&mut cursor) };
// if reusing cursors & no range this resets to whole range // if reusing cursors & no range this resets to whole range
// TODO: handle intersect (range & layer.range)
cursor_ref.set_byte_range(range.clone().unwrap_or(0..usize::MAX)); cursor_ref.set_byte_range(range.clone().unwrap_or(0..usize::MAX));
let mut captures = cursor_ref let mut captures = cursor_ref