mirror of
https://github.com/ilyakooo0/helix.git
synced 2025-01-06 06:14:37 +03:00
filter git revision on git command success exit code (#1674)
The unwrap (or '.ok()' rather) triggers for some errors but not negative status codes. In the case where helix is being packaged in an empty git repository, the existing mechanism will fail because git init git rev-parse HEAD gives a negative exit code and prints to stderr stderr: "fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.... with a stdout of "HEAD\n" (too short to slice with [..8]).
This commit is contained in:
parent
368064e316
commit
a8cf0c6b90
@ -6,6 +6,7 @@ fn main() {
|
||||
.args(&["rev-parse", "HEAD"])
|
||||
.output()
|
||||
.ok()
|
||||
.filter(|output| output.status.success())
|
||||
.and_then(|x| String::from_utf8(x.stdout).ok());
|
||||
|
||||
let version: Cow<_> = match git_hash {
|
||||
|
Loading…
Reference in New Issue
Block a user