mirror of
https://github.com/ilyakooo0/helix.git
synced 2024-09-11 16:07:00 +03:00
Apply all review suggestions (doc_id -> id, error message, unnecessary if)
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
This commit is contained in:
parent
656ee24966
commit
f45bbf165e
@ -220,7 +220,7 @@ macro_rules! language_server {
|
||||
{
|
||||
Some(ls) => ls,
|
||||
None => {
|
||||
editor.set_error("language server disappeared between completion request and application");
|
||||
editor.set_error("completions are outdated");
|
||||
// TODO close the completion menu somehow,
|
||||
// currently there is no trivial way to access the EditorView to close the completion menu
|
||||
return;
|
||||
|
@ -1353,10 +1353,10 @@ pub fn open(&mut self, path: &Path, action: Action) -> Result<DocumentId, Error>
|
||||
}
|
||||
doc.set_version_control_head(self.diff_providers.get_current_head_name(&path));
|
||||
|
||||
let doc_id = self.new_document(doc);
|
||||
let _ = self.launch_language_servers(doc_id);
|
||||
let id = self.new_document(doc);
|
||||
let _ = self.launch_language_servers(id);
|
||||
|
||||
doc_id
|
||||
id
|
||||
};
|
||||
|
||||
self.switch(id, action);
|
||||
|
@ -66,9 +66,6 @@ pub fn diagnostic<'doc>(
|
||||
}
|
||||
use helix_core::diagnostic::Severity;
|
||||
let first_diag_idx_maybe_on_line = diagnostics.partition_point(|d| d.line < line);
|
||||
if first_diag_idx_maybe_on_line == diagnostics.len() {
|
||||
return None;
|
||||
}
|
||||
let diagnostics_on_line = diagnostics[first_diag_idx_maybe_on_line..]
|
||||
.iter()
|
||||
.take_while(|d| {
|
||||
|
Loading…
Reference in New Issue
Block a user