ilyakooo0/helix
1
0
Fork 0
mirror of https://github.com/ilyakooo0/helix.git synced 2024-09-11 16:07:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Apply all review suggestions (doc_id -> id, error message, unnecessary if)

Browse Source 
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
This commit is contained in:
Philipp Mildenberger 2023-04-06 02:37:43 +02:00
parent 656ee24966
commit f45bbf165e
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
helix-term/src/ui/completion.rs
View File

@ -220,7 +220,7 @@ macro_rules! language_server {
{
Some(ls) => ls,
None => {
editor.set_error("language server disappeared between completion request and application");
editor.set_error("completions are outdated");
// TODO close the completion menu somehow,
// currently there is no trivial way to access the EditorView to close the completion menu
return;

6
helix-view/src/editor.rs
View File

@ -1353,10 +1353,10 @@ pub fn open(&mut self, path: &Path, action: Action) -> Result<DocumentId, Error>
}
doc.set_version_control_head(self.diff_providers.get_current_head_name(&path));
let doc_id = self.new_document(doc);
let _ = self.launch_language_servers(doc_id);
let id = self.new_document(doc);
let _ = self.launch_language_servers(id);
doc_id
id
};
self.switch(id, action);

3
helix-view/src/gutter.rs
View File

@ -66,9 +66,6 @@ pub fn diagnostic<'doc>(
}
use helix_core::diagnostic::Severity;
let first_diag_idx_maybe_on_line = diagnostics.partition_point(|d| d.line < line);
if first_diag_idx_maybe_on_line == diagnostics.len() {
return None;
}
let diagnostics_on_line = diagnostics[first_diag_idx_maybe_on_line..]
.iter()
.take_while(|d| {