ilyakooo0/nixpkgs
1
0
Fork 0
mirror of https://github.com/ilyakooo0/nixpkgs.git synced 2025-01-04 01:42:53 +03:00
Code Issues Projects Releases Wiki Activity

nixos/weechat: add setuid wrapper for `screen' to ensure true multiuser capabilities

Browse Source 
Previously you either had to set the setuid bit yourself or workaround
`isSystemUser = true` (for a loginable shell) to access the weechat
screen.

`programs.screen` shouldn't do this by default to avoid taking too much
assumptions about the setup, however `services.weechat` explicitly
requires tihs.

See #45728
This commit is contained in:
Maximilian Bosch 2018-10-10 01:20:42 +02:00
parent fc847785d8
commit 018573b757
No known key found for this signature in database
GPG Key ID: 091DBF4D1FC46B8E
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nixos/modules/services/misc/weechat.nix
View File

@ -46,10 +46,12 @@ in
Group = "weechat"; Group = "weechat";
RemainAfterExit = "yes"; RemainAfterExit = "yes";
}; };
script = "exec ${pkgs.screen}/bin/screen -Dm -S ${cfg.sessionName} ${cfg.binary}"; script = "exec ${config.security.wrapperDir}/screen -Dm -S ${cfg.sessionName} ${cfg.binary}";
wantedBy = [ "multi-user.target" ]; wantedBy = [ "multi-user.target" ];
wants = [ "network.target" ]; wants = [ "network.target" ];
}; };
security.wrappers.screen.source = "${pkgs.screen}/bin/screen";
}; };
meta.doc = ./weechat.xml; meta.doc = ./weechat.xml;

2
nixos/modules/services/misc/weechat.xml
View File

@ -54,7 +54,7 @@
</programlisting> </programlisting>
Now, the session can be re-attached like this: Now, the session can be re-attached like this:
<programlisting> <programlisting>
screen -r weechat-screen screen -x weechat/weechat-screen
</programlisting> </programlisting>
</para> </para>