Merge pull request #336143 from NixOS/revert-284085-thorium-browser

Revert "thorium-browser: init at 120.0.6099.235" While this fixes eval, the bigger issue at play is that the security posture of the upstream project does not feel adequate through a cursory inspection. We need to be much more restrictive with browsers that we accept into nixpkgs.
2024-10-05 12:08:02 +03:00 · 2024-08-20 21:44:08 +02:00 · 2024-08-20 21:44:08 +02:00 · 18319f5a22
commit 18319f5a22
parent ebb49d7305 9f58544a25
1 changed files with 0 additions and 173 deletions
--- a/pkgs/by-name/th/thorium-browser/package.nix
+++ b/pkgs/by-name/th/thorium-browser/package.nix
@ -1,173 +0,0 @@
-{
-  lib,
-  stdenv,
-  fetchurl,
-  autoPatchelfHook,
-  dpkg,
-  wrapGAppsHook,
-  alsa-lib,
-  at-spi2-atk,
-  at-spi2-core,
-  cairo,
-  cups,
-  curl,
-  dbus,
-  expat,
-  ffmpeg,
-  fontconfig,
-  freetype,
-  glib,
-  glibc,
-  gtk3,
-  gtk4,
-  libcanberra,
-  liberation_ttf,
-  libexif,
-  libglvnd,
-  libkrb5,
-  libnotify,
-  libpulseaudio,
-  libu2f-host,
-  libva,
-  libxkbcommon,
-  mesa,
-  nspr,
-  nss,
-  pango,
-  pciutils,
-  pipewire,
-  qt6,
-  speechd,
-  systemd,
-  udev,
-  _7zz,
-  vaapiVdpau,
-  vulkan-loader,
-  wayland,
-  wget,
-  xdg-utils,
-  xfce,
-  xorg,
-}:
-stdenv.mkDerivation rec {
-  pname = "thorium-browser";
-  version = "120.0.6099.235";
-
-  src = fetchurl {
-    url = "https://github.com/Alex313031/thorium/releases/download/M${version}/thorium-browser_${version}_amd64.deb";
-    hash = "sha256-UQqYXlkjXuZ3Vkcie0SNp4AMnBjemavW2G7dKGTxVAc=";
-  };
-
-  nativeBuildInputs = [
-    autoPatchelfHook
-    dpkg
-    wrapGAppsHook
-    qt6.wrapQtAppsHook
-  ];
-
-  buildInputs = [
-    stdenv.cc.cc.lib
-    alsa-lib
-    at-spi2-atk
-    at-spi2-core
-    cairo
-    cups
-    curl
-    dbus
-    expat
-    ffmpeg
-    fontconfig
-    freetype
-    glib
-    glibc
-    gtk3
-    gtk4
-    libcanberra
-    liberation_ttf
-    libexif
-    libglvnd
-    libkrb5
-    libnotify
-    libpulseaudio
-    libu2f-host
-    libva
-    libxkbcommon
-    mesa
-    nspr
-    nss
-    qt6.qtbase
-    pango
-    pciutils
-    pipewire
-    speechd
-    udev
-    _7zz
-    vaapiVdpau
-    vulkan-loader
-    wayland
-    wget
-    xdg-utils
-    xfce.exo
-    xorg.libxcb
-    xorg.libX11
-    xorg.libXcursor
-    xorg.libXcomposite
-    xorg.libXdamage
-    xorg.libXext
-    xorg.libXfixes
-    xorg.libXi
-    xorg.libXrandr
-    xorg.libXrender
-    xorg.libXtst
-    xorg.libXxf86vm
-  ];
-
-  # Needed to make the process get past zygote_linux fork()'ing
-  runtimeDependencies = [
-    systemd
-  ];
-
-  autoPatchelfIgnoreMissingDeps = [
-    "libQt5Widgets.so.5"
-    "libQt5Gui.so.5"
-    "libQt5Core.so.5"
-  ];
-
-  installPhase = ''
-    runHook preInstall
-    mkdir -p $out
-    cp -vr usr/* $out
-    cp -vr etc $out
-    cp -vr opt $out
-    ln -sf $out/opt/chromium.org/thorium/thorium-browser $out/bin/thorium-browser
-    substituteInPlace $out/share/applications/thorium-shell.desktop \
-      --replace /usr/bin $out/bin \
-      --replace /opt $out/opt
-    substituteInPlace $out/share/applications/thorium-browser.desktop \
-      --replace /usr/bin $out/bin \
-      --replace StartupWMClass=thorium StartupWMClass=thorium-browser \
-      --replace Icon=thorium-browser Icon=$out/opt/chromium.org/thorium/product_logo_256.png
-    addAutoPatchelfSearchPath $out/chromium.org/thorium
-    addAutoPatchelfSearchPath $out/chromium.org/thorium/lib
-    substituteInPlace $out/opt/chromium.org/thorium/thorium-browser \
-      --replace 'export LD_LIBRARY_PATH' "export LD_LIBRARY_PATH=\$LD_LIBRARY_PATH:${lib.makeLibraryPath buildInputs}:$out/chromium.org/thorium:$out/chromium.org/thorium/lib"
-    makeWrapper "$out/opt/chromium.org/thorium/thorium-browser" "$out/bin/thorium-browser" \
-      --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}"
-    runHook postInstall
-  '';
-
-  postPatchMkspecs = ''
-    substituteInPlace $out/bin/..thorium-shell-wrapped-wrapped \
-      --replace /opt $out/opt
-  '';
-
-  meta = with lib; {
-    description = "Compiler-optimized Chromium fork";
-    homepage = "https://thorium.rocks";
-    sourceProvenance = with sourceTypes; [ binaryNativeCode ];
-    maintainers = with maintainers; [ rgri ];
-    license = licenses.bsd3;
-    platforms = ["x86_64-linux"];
-    mainProgram = "thorium-browser";
-  };
-}