From 3e9c2bf4b5d55c2a8f8e944e6b8335761a40efb9 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 25 Jul 2014 10:54:00 +0200 Subject: [PATCH] nix-ssh-serve.nix: Remove unnecessary check ForceCommand ensures that we always run nix-store --serve, so there is no need to check SSH_ORIGINAL_COMMAND. --- nixos/modules/services/misc/nix-ssh-serve.nix | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/nixos/modules/services/misc/nix-ssh-serve.nix b/nixos/modules/services/misc/nix-ssh-serve.nix index 80e7961b1f82..51fe79270a66 100644 --- a/nixos/modules/services/misc/nix-ssh-serve.nix +++ b/nixos/modules/services/misc/nix-ssh-serve.nix @@ -1,21 +1,12 @@ { config, lib, pkgs, ... }: -let - serveOnly = pkgs.writeScript "nix-store-serve" '' - #!${pkgs.stdenv.shell} - if [ "$SSH_ORIGINAL_COMMAND" != "nix-store --serve" ]; then - echo 'Error: You are only allowed to run `nix-store --serve'\'''!' >&2 - exit 1 - fi - exec /run/current-system/sw/bin/nix-store --serve - ''; +with lib; - inherit (lib) mkIf mkOption types; -in { +{ options = { nix.sshServe = { enable = mkOption { - description = "Whether to enable serving the nix store over ssh."; + description = "Whether to enable serving the Nix store as a binary cache via SSH."; default = false; type = types.bool; }; @@ -24,7 +15,7 @@ in { config = mkIf config.nix.sshServe.enable { users.extraUsers.nix-ssh = { - description = "User for running nix-store --serve."; + description = "Nix SSH substituter user"; uid = config.ids.uids.nix-ssh; shell = pkgs.stdenv.shell; }; @@ -38,7 +29,7 @@ in { PermitTTY no PermitTunnel no X11Forwarding no - ForceCommand ${serveOnly} + ForceCommand ${config.nix.package}/bin/nix-store --serve Match All ''; };