gftp: 2.0.19 -> 2.7.0b

pkgs/applications/networking/gftp/default.nix

@@ -1,25 +1,56 @@
-{ lib, stdenv, fetchurl, gtk2, readline, ncurses, gettext, openssl, pkg-config }:
+{ lib
+, stdenv
+, fetchFromGitHub
+, autoconf
+, automake
+, gettext
+, gtk
+, intltool
+, libtool
+, ncurses
+, openssl
+, pkg-config
+, readline
+}:
 
 stdenv.mkDerivation rec {
   pname = "gftp";
-  version = "2.0.19";
+  version = "2.7.0b";
 
-  src = fetchurl {
+  src = fetchFromGitHub {
-    url = "https://www.gftp.org/gftp-${version}.tar.bz2";
+    owner = "masneyb";
-    sha256 = "1z8b26n23k0sjbxgrix646b06cnpndpq7cbcj0ilsvvdx5ms81jk";
+    repo = pname;
+    rev = version;
+    hash = "sha256-cIB3SneYKavgdI8eTtM1qsOrBJJ0c7/3CEvNPishNog=";
   };
 
-  postPatch = ''
+  nativeBuildInputs = [
-    sed -i -e '/<stropts.h>/d' lib/pty.c
+    autoconf
+    automake
+    gettext
+    intltool
+    libtool
+    pkg-config
+  ];
+  buildInputs = [
+    gtk
+    ncurses
+    openssl
+    readline
+  ];
+
+  hardeningDisable = [ "format" ];
+
+  preConfigure = ''
+    ./autogen.sh
   '';
 
-  nativeBuildInputs = [ pkg-config ];
+  meta = with lib; {
-  buildInputs = [ gtk2 readline ncurses gettext openssl ];
+    homepage = "https://github.com/masneyb/gftp";
-
+    description = "GTK-based multithreaded FTP client for *nix-based machines";
-  meta = {
+    license = licenses.gpl2Plus;
-    description = "GTK-based FTP client";
+    maintainers = with maintainers; [ AndersonTorres ];
-    homepage = "http://www.gftp.org";
+    platforms = platforms.unix;
-    license = lib.licenses.gpl2Plus;
-    platforms = lib.platforms.unix;
   };
 }
+# TODO: report the hardeningDisable to upstream

pkgs/top-level/all-packages.nix

@@ -5147,7 +5147,9 @@ in
 
   gexiv2 = callPackage ../development/libraries/gexiv2 { };
 
-  gftp = callPackage ../applications/networking/gftp { };
+  gftp = callPackage ../applications/networking/gftp {
+    gtk = gtk2;
+  };
 
   gfbgraph = callPackage ../development/libraries/gfbgraph { };